src/bin/ls, branch stable/14 FreeBSD source tree ls: check fts_children() for errors that may not surface otherwise 2026-04-12T13:43:45+00:00 Kyle Evans kevans@FreeBSD.org 2026-02-11T19:55:55+00:00 6c92918fa159e974322c5e09ac6cffa9d807b0f2 In particular, if one simply does a non-recursive `ls` on a directory that is not accessible, there are some classes of errors that may cause it to fail that wouldn't be surfaced unless we do an fts_read() that will recurse into the inaccessible directory. Catch those kinds of errors here since we cannot expect to an FTS_ERR/FTS_DNR entry to follow up on them. PR: 287451 Reviewed by: kib Discusssed with: des (cherry picked from commit 7bf81e39d83087dc7f984077b5eed5a48df794d4) 
In particular, if one simply does a non-recursive `ls` on a directory
that is not accessible, there are some classes of errors that may cause
it to fail that wouldn't be surfaced unless we do an fts_read() that
will recurse into the inaccessible directory.  Catch those kinds of
errors here since we cannot expect to an FTS_ERR/FTS_DNR entry to follow
up on them.

PR:		287451
Reviewed by:	kib
Discusssed with:	des

(cherry picked from commit 7bf81e39d83087dc7f984077b5eed5a48df794d4)
ls: Release resources before returning from traverse() 2025-01-28T16:00:12+00:00 Mark Johnston markj@FreeBSD.org 2025-01-14T14:20:26+00:00 66ff03065defb26bc2cdec5874c0be88343541c8 PR: 278476 MFC after: 2 weeks Reported by: valgrind (cherry picked from commit e6c9c463384d11a44af3e5f2cc947fb69f3a1968) 
PR:		278476
MFC after:	2 weeks
Reported by:	valgrind

(cherry picked from commit e6c9c463384d11a44af3e5f2cc947fb69f3a1968)
ls: Make -, apply to -s as well as -l. 2024-08-01T16:15:57+00:00 Dag-Erling Smørgrav des@FreeBSD.org 2024-07-24T20:06:39+00:00 e6d9c11666f785ec45cb6f7e05fc87012d6bb4d5 While here, remove a bogus comment about a gcc bug. The bug was in ls, which used an incorrect format string, and in libc, which accepted it. MFC after: 1 week Reviewed by: brooks Differential Revision: https://reviews.freebsd.org/D46067 (cherry picked from commit 647d4a8cafd2c9b291cab388191bc7fcfe12a66b) 
While here, remove a bogus comment about a gcc bug.  The bug was in ls,
which used an incorrect format string, and in libc, which accepted it.

MFC after:	1 week
Reviewed by:	brooks
Differential Revision:	https://reviews.freebsd.org/D46067

(cherry picked from commit 647d4a8cafd2c9b291cab388191bc7fcfe12a66b)
ls.1: Mention CLICOLOR environment variable 2024-02-28T12:48:42+00:00 Gordon Bergling gbe@FreeBSD.org 2024-02-21T10:54:58+00:00 d19769300126426cc59b83036d3ba3e3d8425c16 Mention CLICOLOR environment variable in the manual page. PR: 276556 Submitted by: bsdcode at disroot dot org Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D43970 (cherry picked from commit ffea732c5192070a6877409428b0a2cc1728aa16) 
Mention CLICOLOR environment variable in the manual page.

PR:	276556
Submitted by:	bsdcode at disroot dot org
Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D43970

(cherry picked from commit ffea732c5192070a6877409428b0a2cc1728aa16)
ls: Fix -v and associated test 2024-02-28T12:47:33+00:00 Warner Losh imp@FreeBSD.org 2024-02-19T16:48:05+00:00 fa399b889f70dafb429e548919b0677a619677ef The cleanup of d854370fa86b7 had a cut and paste error (so f_verssort was set to 1 and then to 0 rather thame f_timesort being set to 0). Fixes: d854370fa86b7 Sponsored by: Netflix (cherry picked from commit ef75877fc2d93199aab2b509089136c433af1f20) 
The cleanup of d854370fa86b7 had a cut and paste error (so f_verssort
was set to 1 and then to 0 rather thame f_timesort being set to 0).

Fixes: d854370fa86b7
Sponsored by: Netflix

(cherry picked from commit ef75877fc2d93199aab2b509089136c433af1f20)
ls: versort incompatible w/ timesort and sizesort 2024-02-28T12:47:08+00:00 Alexander Ziaee concussious@runbox.com 2024-02-02T20:19:07+00:00 ff86c97bfa54f1e305f4ce07e560a4b3780a6477 ls.1: versort incompatible w/ timesort and sizesort Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/825 (cherry picked from commit d854370fa86b74527e57145955b1fa3ca75643a2) 
ls.1: versort incompatible w/ timesort and sizesort

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/825

(cherry picked from commit d854370fa86b74527e57145955b1fa3ca75643a2)
Correct the grammo in "will underlined". 2024-02-28T12:40:51+00:00 Jens Schweikhardt schweikh@FreeBSD.org 2023-09-10T09:00:21+00:00 e6c0ce9e37f573700df133f4e00f71f0915cc9f0 (cherry picked from commit 4fc08109fe32264485a54a7ea45f4ec09a8fcf86) 
(cherry picked from commit 4fc08109fe32264485a54a7ea45f4ec09a8fcf86)
Fix "version introduced" in numerous manual pages 2024-01-15T15:20:56+00:00 Tom Hukins tom@FreeBSD.org 2023-09-25T15:22:51+00:00 554b8bc90704e06434a0e775092a8eca6d319031 Pull request: https://github.com/freebsd/freebsd-src/pull/853 (cherry picked from commit ba719a0fec8f831aef4b23de0ff36fd47bb26651) 
Pull request:	https://github.com/freebsd/freebsd-src/pull/853

(cherry picked from commit ba719a0fec8f831aef4b23de0ff36fd47bb26651)
Remove $FreeBSD$: one-line nroff pattern 2023-08-16T17:55:15+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:55:15+00:00 b2c76c41be32f904179efed29c0ca04d53f3996c Remove /^\.\\"\s*\$FreeBSD\$$\n/ 
Remove /^\.\\"\s*\$FreeBSD\$$\n/
Remove $FreeBSD$: one-line sh pattern 2023-08-16T17:55:03+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:55:03+00:00 d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ 
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/