<feed xmlns='http://www.w3.org/2005/Atom'>
<title>src/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD, branch main</title>
<subtitle>FreeBSD source tree</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/'/>
<entry>
<title>Move all sources from the llvm project into contrib/llvm-project.</title>
<updated>2019-12-20T19:53:05+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2019-12-20T19:53:05+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=0b57cec536236d46e3dba9bd041533462f33dbb7'/>
<id>0b57cec536236d46e3dba9bd041533462f33dbb7</id>
<content type='text'>
This uses the new layout of the upstream repository, which was recently
migrated to GitHub, and converted into a "monorepo".  That is, most of
the earlier separate sub-projects with their own branches and tags were
consolidated into one top-level directory, and are now branched and
tagged together.

Updating the vendor area to match this layout is next.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This uses the new layout of the upstream repository, which was recently
migrated to GitHub, and converted into a "monorepo".  That is, most of
the earlier separate sub-projects with their own branches and tags were
consolidated into one top-level directory, and are now branched and
tagged together.

Updating the vendor area to match this layout is next.
</pre>
</div>
</content>
</entry>
<entry>
<title>Pull in r374444 from upstream lldb trunk (by me):</title>
<updated>2019-10-10T20:33:55+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2019-10-10T20:33:55+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=390ceeb43794b1836d06992965944db9fe6931ea'/>
<id>390ceeb43794b1836d06992965944db9fe6931ea</id>
<content type='text'>
  Fix process launch failure on FreeBSD after r365761

  Summary:
  After rLLDB365761, and with `LLVM_ENABLE_ABI_BREAKING_CHECKS`
  enabled, launching any process on FreeBSD crashes lldb with:

  ```
  Expected&lt;T&gt; must be checked before access or destruction.
  Expected&lt;T&gt; value was in success state. (Note: Expected&lt;T&gt; values in
  success mode must still be checked prior to being destroyed).
  ```

  This is because `m_operation_thread` and `m_monitor_thread` were
  wrapped in `llvm::Expected&lt;&gt;`, but this requires the objects to be
  correctly initialized before accessing them.

  To fix the crashes, use `llvm::Optional&lt;&gt;` for the members (as
  indicated by labath), and use local variables to store the return
  values of `LaunchThread` and `StartMonitoringChildProcess`.  Then,
  only assign to the member variables after checking if the return
  values indicated success.

  Reviewers: devnexen, emaste, MaskRay, mgorny

  Reviewed By: devnexen

  Subscribers: jfb, labath, krytarowski, lldb-commits

  Differential Revision: https://reviews.llvm.org/D68723

PR:		241137
MFC after:	1 month
X-MFC-With:	r353358
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  Fix process launch failure on FreeBSD after r365761

  Summary:
  After rLLDB365761, and with `LLVM_ENABLE_ABI_BREAKING_CHECKS`
  enabled, launching any process on FreeBSD crashes lldb with:

  ```
  Expected&lt;T&gt; must be checked before access or destruction.
  Expected&lt;T&gt; value was in success state. (Note: Expected&lt;T&gt; values in
  success mode must still be checked prior to being destroyed).
  ```

  This is because `m_operation_thread` and `m_monitor_thread` were
  wrapped in `llvm::Expected&lt;&gt;`, but this requires the objects to be
  correctly initialized before accessing them.

  To fix the crashes, use `llvm::Optional&lt;&gt;` for the members (as
  indicated by labath), and use local variables to store the return
  values of `LaunchThread` and `StartMonitoringChildProcess`.  Then,
  only assign to the member variables after checking if the return
  values indicated success.

  Reviewers: devnexen, emaste, MaskRay, mgorny

  Reviewed By: devnexen

  Subscribers: jfb, labath, krytarowski, lldb-commits

  Differential Revision: https://reviews.llvm.org/D68723

PR:		241137
MFC after:	1 month
X-MFC-With:	r353358
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert r353363 in preparation for applying upstream fix:</title>
<updated>2019-10-10T20:30:54+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2019-10-10T20:30:54+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=6cc0992fb57cc6e960bb0bdb4e6d6dd99d8beee7'/>
<id>6cc0992fb57cc6e960bb0bdb4e6d6dd99d8beee7</id>
<content type='text'>
Put in a band-aid fix for lldb 9 exiting with "Expected&lt;T&gt; must be
checked before access or destruction" when launching executables, while
we sort this out with upstream.

PR:		241137
MFC after:	1 month
X-MFC-With:	r353358
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Put in a band-aid fix for lldb 9 exiting with "Expected&lt;T&gt; must be
checked before access or destruction" when launching executables, while
we sort this out with upstream.

PR:		241137
MFC after:	1 month
X-MFC-With:	r353358
</pre>
</div>
</content>
</entry>
<entry>
<title>Put in a band-aid fix for lldb 9 exiting with "Expected&lt;T&gt; must be</title>
<updated>2019-10-09T19:51:41+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2019-10-09T19:51:41+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=a930ecddaa16ab5470cb50b1d8b359ea30b4dd60'/>
<id>a930ecddaa16ab5470cb50b1d8b359ea30b4dd60</id>
<content type='text'>
checked before access or destruction" when launching executables, while
we sort this out with upstream.

Reported by:	jbeich
PR:		241137
MFC after:	1 month
X-MFC-With:	r353358
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
checked before access or destruction" when launching executables, while
we sort this out with upstream.

Reported by:	jbeich
PR:		241137
MFC after:	1 month
X-MFC-With:	r353358
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge ^/head r351317 through r351731.</title>
<updated>2019-09-03T05:58:43+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2019-09-03T05:58:43+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=c5c3ba6b43cac20dc9432eac15758d41cb2b8b1f'/>
<id>c5c3ba6b43cac20dc9432eac15758d41cb2b8b1f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>lldb: shorten thread names to make logs easier to follow</title>
<updated>2019-09-01T16:50:34+00:00</updated>
<author>
<name>Ed Maste</name>
<email>emaste@FreeBSD.org</email>
</author>
<published>2019-09-01T16:50:34+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=aebac09b6f1f69c13e1f0c6c95eaef671751ba6e'/>
<id>aebac09b6f1f69c13e1f0c6c95eaef671751ba6e</id>
<content type='text'>
lldb prepends the thread name to log entries, and the existing thread
name for the FreeBSD ProcessMonitor thread was longer than the kernel's
supported thread name length, and so was truncated.  This made logs hard
to read, as the truncated thread name ran into the log message.  Shorten
"lldb.process.freebsd.operation" to just "freebsd.op" so that logs are
more readable.

(Upstreaming to lldb still to be done).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
lldb prepends the thread name to log entries, and the existing thread
name for the FreeBSD ProcessMonitor thread was longer than the kernel's
supported thread name length, and so was truncated.  This made logs hard
to read, as the truncated thread name ran into the log message.  Shorten
"lldb.process.freebsd.operation" to just "freebsd.op" so that logs are
more readable.

(Upstreaming to lldb still to be done).
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge lldb trunk r366426, resolve conflicts, and update FREEBSD-Xlist.</title>
<updated>2019-08-22T19:14:02+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2019-08-22T19:14:02+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=580d4aa65a2dadf52a0abc9451ab25918cb25125'/>
<id>580d4aa65a2dadf52a0abc9451ab25918cb25125</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge lldb trunk r351319, resolve conflicts, and update FREEBSD-Xlist.</title>
<updated>2019-01-20T15:00:15+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2019-01-20T15:00:15+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=763d4102c9736544f95a61d4d0a9a5be8c5a5df1'/>
<id>763d4102c9736544f95a61d4d0a9a5be8c5a5df1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge lldb trunk r338150, and resolve conflicts.</title>
<updated>2018-07-31T17:51:25+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2018-07-31T17:51:25+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=6492be7d57b91310e3f3b6fddb0dd747c4311b44'/>
<id>6492be7d57b91310e3f3b6fddb0dd747c4311b44</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>lldb: remove assertion that target_arch is FreeBSD</title>
<updated>2018-04-24T19:26:58+00:00</updated>
<author>
<name>Ed Maste</name>
<email>emaste@FreeBSD.org</email>
</author>
<published>2018-04-24T19:26:58+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=7165bb8cc62cc67fe628fbdc91a9c77697467fbd'/>
<id>7165bb8cc62cc67fe628fbdc91a9c77697467fbd</id>
<content type='text'>
The target is not necessarily a FreeBSD binary - for example, it may be
a Linux binary running under the linuxulator.  Basic ptrace (live)
debugging already worked in this case, except for the assertion.

Sponsored by:	Turing Robotic Industries Inc.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The target is not necessarily a FreeBSD binary - for example, it may be
a Linux binary running under the linuxulator.  Basic ptrace (live)
debugging already worked in this case, except for the assertion.

Sponsored by:	Turing Robotic Industries Inc.
</pre>
</div>
</content>
</entry>
</feed>
