src/lib/libc/db/hash, branch main

libc/dbm: Differentiate between uninitialized and end-of-db cursors

2026-06-20T14:27:44+00:00

Commit `3a686b851f8f` fixed a `dbm_nextkey` edge case when using
the function after reaching the end of the database, but it inadvertently
broke the following `R_NEXT` behaviour:
"If the cursor is not yet set, this is the same as the R_FIRST flag."

Fix this by adding a new cursor constant that allows us to differentiate
between an unset cursor and a cursor that overflowed.

Reported by:	ae
Fixes:	3a686b851f8f
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D57670
Reviewed by:	markj

libc/db: Remove unused hash functions in hash_func.c

2026-03-24T10:34:55+00:00

Prune unused code hidden behind 'notdef', bringing us in sync with
the changes in OpenBSD. Despite the `__default_hash` function pointer
having external linkage, no ABI change is expected since it was
never exported.

Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D55842
Reviewed by:	allanjude, des
MFC after:	2 weeks

db/hash.c: Fix flag check in hash_seq

2025-08-01T09:33:00+00:00

Fixes:	3a686b851f8f

dbm_nextkey: Always return an error if we've reached the end of the database

2025-07-31T15:27:24+00:00

POSIX.1 states that `dbm_nextkey` must return an invalid key
(i.e., `key.dptr == NULL`) after the end of the database was reached.
The current implementation of `hash_seq` will incorrectly restart
the key sequence after the end of the database is reached.

Fix this by checking the "current bucket" index when R_NEXT is passed.

Sponsored by:   Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D51635
Reviewed by:	markj

db/hash.c: Allow O_WRONLY in dbm_open

2025-07-30T09:31:16+00:00

The dbm(3) manpage explicitly states that O_WRONLY is not allowed in
dbm_open, but a more recent comment in ` __hash_open` suggests otherwise.
Furthermore, POSIX.1 allows O_WRONLY in dbm_open and states
that the underlying file must be opened for both reading and writing.

Fix this by correcting the O_WRONLY check and moving it further into
the function to make sure that the original flags are stored in hashp.

Sponsored by:   Klara, Inc.
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D51514

db/hash.c: Do not return an error when opening a missing database with O_CREAT

2025-07-25T09:22:44+00:00

dbm_open currently returns an error when opening a missing database
with O_CREAT but creates the request database file. This is caused
by a buggy check in __hash_open which attempts to detect a new
(or empty) database file, but fails to take the O_CREAT flag into
account.

Fix this by expanding the check to include O_CREAT.

Fixes:	edcdc752ecdd
Sponsored by:	Klara, Inc.
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D51491

Remove residual blank line at start of Makefile

2024-07-15T22:43:39+00:00

This is a residual of the $FreeBSD$ removal.

MFC After: 3 days (though I'll just run the command on the branches)
Sponsored by: Netflix

lib: Remove ancient SCCS tags.

2023-11-27T05:23:28+00:00

Remove ancient SCCS tags from the tree, automated scripting, with two
minor fixup to keep things compiling. All the common forms in the tree
were removed with a perl script.

Sponsored by:		Netflix

libc: Purge unneeded cdefs.h

2023-11-01T22:44:30+00:00

These sys/cdefs.h are not needed. Purge them. They are mostly left-over
from the $FreeBSD$ removal. A few in libc are still required for macros
that cdefs.h defines. Keep those.

Sponsored by:		Netflix
Differential Revision:	https://reviews.freebsd.org/D42385

Remove $FreeBSD$: one-line sh pattern

2023-08-16T17:55:03+00:00

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/