src/lib/libc/tests/string/memcmp_test.c, branch stable/15 FreeBSD source tree libc: Have memcmp test what the standard requires 2025-09-16T17:34:32+00:00 Ed Maste emaste@FreeBSD.org 2024-11-20T16:47:35+00:00 79e4dfe2a5f7079608b92d2d1fe38838e7601323 libc's C memcmp currently returns the difference in byte values rather than just -1/0/1 as the AArch64 assembly implementation, many non- FreeBSD implementations, and compiler built-in optimizations do. It is a bug for a user to expect memcmp to return the difference in the byte values as the compiler is free to inline memcmp() with an implementation that does not do this. Change the test to validate only what the standard requires. PR: 289084 Reviewed by: markj, fuz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52502 (cherry picked from commit e0eaabb80d1724acf88f04acbc2ca13d42270863) 
libc's C memcmp currently returns the difference in byte values rather
than just -1/0/1 as the AArch64 assembly implementation, many non-
FreeBSD implementations, and compiler built-in optimizations do.

It is a bug for a user to expect memcmp to return the difference in the
byte values as the compiler is free to inline memcmp() with an
implementation that does not do this.  Change the test to validate only
what the standard requires.

PR:		289084
Reviewed by:	markj, fuz
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D52502

(cherry picked from commit e0eaabb80d1724acf88f04acbc2ca13d42270863)
libc: Purge unneeded cdefs.h 2023-11-01T22:44:30+00:00 Warner Losh imp@FreeBSD.org 2023-11-01T22:43:37+00:00 559a218c9b257775fb249b67945fe4a05b7a6b9f These sys/cdefs.h are not needed. Purge them. They are mostly left-over from the $FreeBSD$ removal. A few in libc are still required for macros that cdefs.h defines. Keep those. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D42385 
These sys/cdefs.h are not needed. Purge them. They are mostly left-over
from the $FreeBSD$ removal. A few in libc are still required for macros
that cdefs.h defines. Keep those.

Sponsored by:		Netflix
Differential Revision:	https://reviews.freebsd.org/D42385
lib/libc/tests/string: expand memcmp test to bcmp, timingsafe_{b,mem}cmp 2023-10-02T19:25:31+00:00 Robert Clausecker fuz@FreeBSD.org 2023-08-30T15:30:24+00:00 c6cc06d465a98270ef734ffec7c9012ec3a1bd17 The four functions more or less perform the same operation. Reuse the same unit test with slight changes so we can cover them all. Constant-time operation is not verified for the timingsafe_* functions. Sponsored by: The FreeBSD Foundation Approved by: ngie MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D41528 
The four functions more or less perform the same operation.
Reuse the same unit test with slight changes so we can cover
them all.  Constant-time operation is not verified for the
timingsafe_* functions.

Sponsored by:	The FreeBSD Foundation
Approved by:	ngie
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D41528
lib/libc/tests/string/memcmp_test.c: extend test to support custom memcmp function 2023-10-02T19:25:21+00:00 Robert Clausecker fuz@FreeBSD.org 2023-07-14T11:56:12+00:00 b166580681e3af173ec368656019d02ba1cc55ad Extend the tests to permit loading an external memcmp function and testing it over using the libc version. This was added by the example of other tests in the test suite doing the same thing and helped tremendously in development. This change was originally part of D41442 but was taken out to permit separate review as extrapolated from @ngie's request in D41349. Sponsored by: FreeBSD Foundation Approved by: ngie Differential Revision: https://reviews.freebsd.org/D41528 
Extend the tests to permit loading an external memcmp function
and testing it over using the libc version. This was added by the
example of other tests in the test suite doing the same thing and
helped tremendously in development.

This change was originally part of D41442 but was taken out to
permit separate review as extrapolated from @ngie's request in
D41349.

Sponsored by:	FreeBSD Foundation
Approved by:	ngie
Differential Revision:	https://reviews.freebsd.org/D41528
Remove $FreeBSD$: one-line .c pattern 2023-08-16T17:54:42+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:42+00:00 1d386b48a555f61cb7325543adbbb5c3f3407a66 Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ 
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
libc: Add some tests for memcmp(). 2016-03-06T18:41:48+00:00 Jilles Tjoelker jilles@FreeBSD.org 2016-03-06T18:41:48+00:00 ee3147b53aa9c021cb65f4cccc086d8959a24feb