src/lib/libc/tests, branch main

libc/tests/string: add a more comprehensive unit test for strrchr()

2026-04-08T13:21:50+00:00

The unit tests are patterned after those for memrchr().
This catches the issue found in 293915.

PR:		293915
Reviewed by:	strajabot
Reported by:	safonov.paul@gmail.com
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D56037

libc: Fix cxa_thread_atexit{,nothr} test.

2026-03-22T02:48:24+00:00

After patch 9d26b82, we don't provide recursive call protection anymore.
Therefore, to pass the test, we adjust the testcase by protecting on
caller and the testcase is to make sure the dtors is properly handled.

Reported by:    siva
Reviewed by:    kib
Approved by:    markj (mentor)
Fixes:  9d26b82826d9 ("libc: Fix dtor order in __cxa_thread_atexit")
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D55893

system(3): Fix brain glitch in previous commit

2026-03-09T21:01:41+00:00

We were saving SIGINT twice instead of SIGINT and SIGQUIT.

Also restore original order of operations (SIGINT then SIGQUIT), which
matches the order in which they're discussed in the POSIX description
of system(3).

MFC after:	1 week
Sponsored by:	Klara, Inc.
Fixes:		48368f702423 ("system(3): Address test robustness issue")

system(3): Address test robustness issue

2026-03-09T20:41:04+00:00

Don't assume that SIGINT and SIGQUIT are set to SIG_DFL at the start
of the test.  Instead, retrieve their current dispositions and verify
that they are restored at the end of the test.

MFC after:	1 week
Sponsored by:	Klara, Inc.
Reviewed by:	kevans
Differential Revision:	https://reviews.freebsd.org/D55709

system(3): Fix null case

2026-02-25T21:12:42+00:00

Our manual page states that if given a null pointer, system() returns
non-zero if the shell is available and zero if it is not.  This is
consistent with the C standard's description of system(), but it is not
what we actually do.  What we actually do is always return non-zero, as
required by POSIX.

As the POSIX rationale explains, implementing the logic required by the
C standard does not violate POSIX, since a conforming system always has
a shell, therefore the logic will always return non-zero.

Since our libc is commonly used in non-conforming situations such as
chroots or thin jails, we should implement the full logic required by
the C standard.

MFC after:	1 week
Sponsored by:	Klara, Inc.
Reviewed by:	obiwac, bnovkov, kevans
Differential Revision:	https://reviews.freebsd.org/D55484

system(3): Write our own tests

2026-02-25T21:12:29+00:00

Replace the somewhat perfunctory NetBSD tests with our own.

MFC after:	1 week
Sponsored by:	Klara, Inc.
Reviewed by:	bnovkov, kevans
Differential Revision:	https://reviews.freebsd.org/D55482

libc/tests: Clean up *dir() tests

2026-02-03T14:39:32+00:00

Mainly, avoid reusing the name of one of the functions we should be
testing (but aren't) for local variables.

Sponsored by:	Klara, Inc.
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D55054

tdestroy(3): add tests

2025-12-29T17:18:55+00:00

Reviewed by:	alc, emaste
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D54365

libc/test: fix typo

2025-12-14T17:06:40+00:00

I misapplied ngie's recommended correction.

Fixes:	123c086200491819595abc271d360e605288fd18
Differential Revision:	https://reviews.freebsd.org/D54169

libc/tests/string: improve stpncpy() "bounds" unit test

2025-12-14T16:05:30+00:00

The test is extended the same way I previously extended the memccpy()
test to fix what is probably the same kind of bug.

PR:		291359
Reported by:	Collin Funk 
Reviewed by:	ngie
Approved by:	markj (mentor)
Fixes:		6fa9e7d8737548ef93c573387ce62402c368d486 (D42519)
See also:	61ed5748e4e9c7397fcb2638b442f46ac5c9e7c5 (D46051)
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D54169

lib/libc/tests/string/stpncpy_test.c: apply ngie's fixes