src/lib/libcrypt/crypt-md5.c, branch main

lib/libcrypt: use explicit_bzero() to clear sensitive buffers

2024-10-25T14:02:38Z

Prevent a potentially sufficiently smart compiler from optimising away our attempts to clear sensitive buffers. A related change was discussed and rejected in D16059, but I don't believe the reasoning there applies: the code clearly documents its intent that the `memset` calls clear sensitive buffers so they don't hang around. `explicit_bzero` is the appropriate function for this purpose. A potential performance disadvantage seems less important: the functions in crypt are specifically designed to be slow, so a few extra calls to guarantee that sensitive buffers are cleared does not significantly affect runtime. See also: D16059 Reviewed by: delphij, kevans MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D47037

lib: Automated cleanup of cdefs and other formatting

2023-11-27T05:23:59Z

Apply the following automated changes to try to eliminate no-longer-needed sys/cdefs.h includes as well as now-empty blank lines in a row. Remove /^#if.*\n#endif.*\n#include\s+.*\n/ Remove /\n+#include\s+.*\n+#if.*\n#endif.*\n+/ Remove /\n+#if.*\n#endif.*\n+/ Remove /^#if.*\n#endif.*\n/ Remove /\n+#include\s+\n#include\s+/ Remove /\n+#include\s+\n#include\s+/ Remove /\n+#include\s+\n#include\s+/ Sponsored by: Netflix

Remove $FreeBSD$: one-line .c pattern

2023-08-16T17:54:42Z

Remove /^[\s*]*__FBSDID$"\$FreeBSD\$"$;?\s*\n/

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

2023-05-12T16:44:03Z

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix

lib: further adoption of SPDX licensing ID tags.

2017-11-26T02:00:33Z

Mainly focus on files that use BSD 2-Clause license, however the tool I was using mis-identified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts.

Make libcrypt thread-safe. Add crypt_r(3).

2016-08-10T15:16:28Z

glibc has a pretty nice function called crypt_r(3), which is nothing more than crypt(3), but thread-safe. It accomplishes this by introducing a 'struct crypt_data' structure that contains a buffer that is large enough to hold the resulting string. Let's go ahead and also add this function. It would be a shame if a useful function like this wouldn't be usable in multithreaded apps. Refactor crypt.c and all of the backends to no longer declare static arrays, but write their output in a provided buffer. There is no need to do any buffer length computation here, as we'll just need to ensure that 'struct crypt_data' is large enough, which it is. _PASSWORD_LEN is defined to 128 bytes, but in this case I'm picking 256, as this is going to be part of the actual ABI. Differential Revision: https://reviews.freebsd.org/D7306

Tidy the code up a fraction. Re-release with a 2-clause BSD license

2003-06-02T21:43:14Z

with the kind permission of the author/copyright holder. Thanks to: phk

Fix grammer in comment.

2002-03-25T15:55:36Z

Submitted by: Engin Gunduz

Modernize my email-address.

2002-03-25T13:48:53Z

Darn. There is (now was) a signed/unsigned issue that resulted in a

2002-03-07T10:41:11Z

very long loop. Reported by: nnd@mail.nsk.ru (Nickolay Dudorov)