src/lib/libfetch/ftp.c, branch release/6.0.0_cvs

This commit was manufactured by cvs2svn to create tag

2005-11-03T00:35:26+00:00

'RELENG_6_0_0_RELEASE'.

This commit was manufactured to restore the state of the 6.0-RELEASE image.

Update copyright years.

2004-09-21T18:35:21+00:00

Don't close a FILE * which we know is bogus.

2003-08-29T15:54:12+00:00

Some servers respond to RETR in active mode with 125 (connection already

2003-08-19T11:43:11+00:00

open) rather than 150 (opening connection).  There's no reason why we
shouldn't accept that.

PR:		misc/42172
MFC in:		3 days

The flags passed in to _ftp_get_proxy may be null

2003-03-19T21:39:00+00:00

Approved by:	des, markm (mentor)(implicit)

Don't parse the proxy URL unless we're actually going to use it. No real

2003-03-11T08:20:58+00:00

functional difference, but debugging output will be less confusing.

style(9): add parentheses to sizeof even when not strictly required.

2003-01-28T08:04:40+00:00

MFC after:	3 days

Hook in the .netrc code + don't use pointers as if they were booleans.

2003-01-22T17:54:49+00:00

The FTP connection caching needs a better interface -- connections are

2002-10-25T01:17:32+00:00

closed through _fetch_close() which is the only one who knows the connection
REALLY was closed (since ref -> 0).  However, FTP keeps its own local
cached_connection and checks if it is valid by comparing it to NULL.  This
is bogus since it may have been freed elsewhere by _fetch_close().

This change checks if we are closing the cached_connection and the ref is 1
(soon to be 0).  If so, set cached_connection to NULL so we don't
accidentally reuse it.  The REAL fix should be to move connection caching
to the common.c level (_fetch_* functions) and NULL the cache(s) in
_fetch_close().  Then all layers could benefit from caching.

When recycling a cached connection, increment the reference count so that

2002-10-20T10:36:27+00:00

the heap block does not get freed and reused. This should fix the
pkg_add -r crashes that have been happening for months.