src/lib/libfetch/ftp.c, branch releng/12.2

Fix libfetch out of bounds read.

2021-08-24T18:02:27+00:00

Approved by:    so
Security:       SA-21:15.libfetch
Security:       CVE-2021-36159

Fix an inverted conditional in the netrc code, which would ignore the

2018-05-29T13:07:36+00:00

value of $HOME and always use the home directory from the passwd
database, unless $HOME was unset, in which case it would use (null).

While there, clean up handling of netrcfd and add debugging aids.

MFC after:	3 weeks

Use __VA_ARGS__ to simplify the DEBUG macro.

2018-05-29T10:28:20+00:00

MFC after:	3 weeks

SPDX: use the Beerware identifier.

2017-11-30T20:33:45+00:00

lib: further adoption of SPDX licensing ID tags.

2017-11-26T02:00:33+00:00

Mainly focus on files that use BSD 2-Clause license, however the tool I
was using mis-identified many licenses so this was mostly a manual - error
prone - task.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

Refactor fetch_connect() and fetch_bind() to improve readability and avoid

2016-11-22T13:30:07+00:00

repeating the same DNS lookups.

MFC after:	3 weeks

libfetch: replace 0 with NULL for pointers.

2016-04-09T18:08:21+00:00

Found with devel/coccinelle.

Reviewed by:	des

latin1 -> utf8

2011-10-19T11:43:51+00:00

Update copyright dates and strip my middle name.

2011-09-27T18:57:26+00:00

Think first, commit second.

2011-09-27T18:42:09+00:00

1. Allow the caller to select active mode.
2. Fix the envar logic so it *always* overrides the caller's flags.
3. Document the change from active to passive.