src/lib/libfetch/http.c, branch release/11.1.0

MFH (r313974,r314596): open .netrc early in case we want to drop privs

2017-03-24T14:19:52+00:00

MFH (r314396,r315143): fix a crash caused by an incorrect format string
MFH (r314701): fix handling of 416 errors when requesting a range
MFH (r315455): fix parsing of IP literals (square brackets)

PR:		212065, 217723

MFH (r310823): fix multi-line CONNECT responses

2017-01-09T14:13:47+00:00

PR:		194483

r169386 (PR 112515) was incomplete: it treated 307 as an error except

2016-05-31T08:27:39+00:00

in verbose mode, and did not handle 308 at all.

r241840 (PR 172451) added support for 308, but with the same bug.

Correctly handle both by recognizing them as redirects in all places
where we check the HTTP result code.

PR:		112515 173451 209546
Submitted by:	novel@
MFC after:	1 week

Use strlcpy() instead of strncpy() to copy the string returned by

2016-05-12T06:39:13+00:00

setlocale() so that static analyzers know that the string is NUL
terminated.  This was causing a false positive in Coverity even
though the longest string returned by setlocale() is ENCODING_LEN
(31) and we are copying into a 64 byte buffer.  This change is also
a bit of an optimization since we don't need the strncpy() feature
of padding the rest of the destination buffer with NUL characters.

Reported by:	Coverity
CID:		974654

Fix double-free error: r289419 moved all error handling in http_connect()

2016-02-11T17:48:15+00:00

to the end of the function, but did not remove a fetch_close() call which
was made redundant by the one in the shared error-handling code.

PR:		206774
Submitted by:	Christian Heckendorf 
MFC after:	3 days

As a followup to r292330, standardize on size_t and add a few comments.

2015-12-16T09:20:45+00:00

Reset bufpos to 0 immediately after refilling the buffer. Otherwise, we

2015-12-16T09:17:07+00:00

risk leaving the connection in an indeterminate state if the server fails
to send a chunk delimiter.  Depending on the application and on the sizes
of the preceding chunks, the result can be anything from missing data to a
segfault.  With this patch, it will be reported as a protocol error.

PR:		204771
MFC after:	1 week

Fix buildworld after r291453, similar to r284346: url->user and url->pwd

2015-11-29T22:37:48+00:00

are arrays, so they can never be NULL.

Reported by:	many
Pointy hat to:	des

Use .netrc for HTTP sites and proxies, not just FTP.

2015-11-29T14:26:59+00:00

PR:		193740
Submitted by:	TEUBEL György 
MFC after:	1 week

Fix two bugs in HTTPS tunnelling:

2015-10-16T12:21:44+00:00

 - If the proxy returns a non-200 result, set the error code accordingly
   so the caller / user gets a somewhat meaningful error message.
 - Consume and discard any HTTP response header following the result line.

PR:		194483
Tested by:	Fabian Keil 
MFC after:	1 week