src/lib/libfetch, branch mainFreeBSD source treehttp://cgit.freebsd.org/src/atom?h=main2026-07-30T16:36:27Zlibfetch: Further improve connection polling2026-07-30T16:36:27ZDag-Erling Smørgravdes@FreeBSD.org2026-07-30T16:36:27Zurn:sha1:351ed134887fe5b8da39d22fcb267c96ab009ca2
* Reorganize the connection loop to make it a little more readable
* Start the timeout clock earlier
* Correctly calculate the poll timeout before calling poll()
* Don't leak the socket on failure
Fixes: 848f360c8f9a ("libfetch: Apply timeout to connection attempts")
Fixes: b02e02958dad ("libfetch: Fix handling of connection failures")
MFC after: 3 days
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D58512
libfetch: Fix handling of connection failures2026-07-27T23:03:16ZMark Johnstonmarkj@FreeBSD.org2026-07-27T18:58:34Zurn:sha1:b02e02958dad2d5ce3675cbc18b9a94635d09e66
After commit 848f360c8f9a, if one tries to connect to a closed port,
fetch reports "Operation now in progress", which is rather confusing.
Return a more useful error message, restoring the old behaviour.
Fixes: 848f360c8f9a ("libfetch: Apply timeout to connection attempts")
Reviewed by: des
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D58481
libfetch: Reduce copying2026-07-13T06:43:56ZDag-Erling Smørgravdes@FreeBSD.org2026-07-13T06:43:56Zurn:sha1:60382b4a04fa39e9bf65b964b1b7b4bed6eaa56a
Reduce the amount of copying we do when performing buffered reads.
MFC after: 1 week
Reviewed by: op
Differential Revision: https://reviews.freebsd.org/D58113
libfetch: Make fetch_ref an inline2026-07-13T06:43:51ZDag-Erling Smørgravdes@FreeBSD.org2026-07-13T06:43:51Zurn:sha1:d4e0e1fbc237f0765b9f32b291c087348031c921
Make fetch_ref() an inline and provide a fetch_deref().
MFC after: 1 week
Reviewed by: op
Differential Revision: https://reviews.freebsd.org/D57944
libfetch: Document fetchTimeout2026-07-13T06:43:42ZDag-Erling Smørgravdes@FreeBSD.org2026-07-13T06:43:42Zurn:sha1:27b411734c75a7a5abe641d7fbb99dfc622e9aba
Document the global fetchTimeout variable, now that it works reliably.
MFC after: 1 week
Reviewed by: op
Differential Revision: https://reviews.freebsd.org/D57910
libfetch: Apply timeout to connection attempts2026-07-13T06:43:37ZDag-Erling Smørgravdes@FreeBSD.org2026-07-13T06:43:37Zurn:sha1:848f360c8f9ae8d1d97c61f5d63fc624926d5dcd
Mark the socket non-blocking before connecting and poll for completion,
applying fetchTimeout if set.
MFC after: 1 week
Reviewed by: op
Differential Revision: https://reviews.freebsd.org/D57909
libfetch: Add read buffering2026-07-13T06:43:33ZDag-Erling Smørgravdes@FreeBSD.org2026-07-13T06:43:33Zurn:sha1:a1978277379cf65f1339ab062f335c6f1fa6239f
Previously, we would read FTP control connection messages and HTTP
reponse headers one character at a time. Now, we read as much as will
fit in our buffer and look for a newline. If there is data left over,
it will be reused by the next fetch_getln() call. This also requires
the addition of a fetch_bufread() which takes the buffer into account,
otherwise the start of the HTTP response body will be stuck in the
buffer after we read the last line of the header.
This should noticeably improve HTTP performance, especially for small
transfers.
MFC after: 1 week
Reviewed by: op
Differential Revision: https://reviews.freebsd.org/D57907
libfetch: Overhaul socket read / write2026-07-13T06:43:28ZDag-Erling Smørgravdes@FreeBSD.org2026-07-13T06:43:28Zurn:sha1:32c341bd1c8b1154128f62fafa6988ed29db564a
* Make fetch_ssl_read() and fetch_ssl_write() behave more like read(2)
and write(2), and drop fetch_socket_read() in favor of read(2).
* Don't request POLLERR, it's implied.
* Don't needlessly set errno, it's relatively costly.
* Always check for EAGAIN from writev(2), otherwise we will abort on a
short write instead of proceeding to poll(2).
* Always check for EAGAIN from poll(2) even though it can't happen on
FreeBSD; POSIX says it can, and it might in the future.
* Rewrite fetch_read() and fetch_writev() to be more similar to each
other. The main difference is that a partial read is treated as
success while a partial write is treated as failure.
PR: 296316
MFC after: 1 week
Reviewed by: op
Differential Revision: https://reviews.freebsd.org/D57906
Revert "libfetch: Overhaul socket read / write"2026-06-29T15:53:56ZDag-Erling Smørgravdes@FreeBSD.org2026-06-29T15:53:56Zurn:sha1:da4d1ced75f3be17f8b089a364f642a04eb0d466
This reverts commit 298f37a71ae6d9f2cb0c2abd4ff2887e81e0942c.
Revert "libfetch: Add read buffering"2026-06-29T15:53:55ZDag-Erling Smørgravdes@FreeBSD.org2026-06-29T15:53:55Zurn:sha1:fde60e3a4e922e7931c39f10105e3fbe33f54534
This reverts commit afb60498e0c9836a6e3a7efda8a51710e208a608.