Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
Similar commit in main:
(cherry picked from commit 1d386b48a555)
The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix (cherry picked from commit 4d846d260e2b9a3d4d0a701462568268cbfe7a5b)
- s/sesion/session/ (cherry picked from commit 29b36af9981e7f194abe68b0359448846c021cd6)
Text requests and responses can span multiple PDUs. In that case, the sender sets the Continue bit in non-final PDUs and the Final bit in the last PDU. The receiver responds to non-final PDUs with an empty text PDU. To support this, add a more abstract API in libiscsi which accepts and receives key sets rather than PDUs. These routines internally send or receive one or more PDUs. Use these new functions to replace the handling of TextRequest and TextResponse PDUs in discovery sessions in both ctld and iscsid. Note that there is not currently a use case for large Text requests and those are still always sent as a single PDU. However, discovery sessions can return a text response listing targets that spans multiple PDUs, so the new API supports sending and receiving multi-PDU responses. Reported by: Jithesh Arakkan @ Chelsio Reviewed by: mav Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D33548 (cherry picked from commit b406897911ea6c18c401907a076c4642dac46127)
This will be used in future changes to support large text requests spanning multiple PDUs. Provide wrapper functions keys_load/save_pdu that operate use a PDU's data buffer. Reviewed by: mav Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D33547 (cherry picked from commit 25700db36640b1538ac91f893955a4f1a4167f63)
When keys are loaded from a received PDU, a copy of the received keys block is saved in the keys struct and the name and value pointers point into that saved block. Freeing the keys frees this block. However, when keys are added to a keys struct to build a set of keys later sent in a PDU, the keys data block pointer is not used and individual key names and values hold allocated strings. When the keys structure was freed, all of these individual key name and value strings were leaked. Instead, allocate copies of strings for names and values when parsing a set of keys from a received PDU and free all of the individual key name and value strings when deleting a set of keys. Reviewed by: mav Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D33545 (cherry picked from commit fd99905b4591a5e4df3dda32e4c67258aaf44517)
Reviewed by: mav Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D33546 (cherry picked from commit 2ccb8fde5eec8a0a25449374fd5a71654460947f)
Move some of the code duplicated between ctld(8) and iscsid(8) into a libiscsiutil library. Sharing the low-level PDU code did require having a 'struct connection' base class with a method table to permit separate initiator vs target behavior (e.g. in handling proxy PDUs). Reviewed by: mav, emaste Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D33544 (cherry picked from commit 6378393308bc6bd81fb871dacf6b03cf1a390d8b)