src/libexec/getty/chat.c, branch releng/12.2 FreeBSD source tree MFC r343479: Fix potential buffer overflow and undefined behavior. 2019-02-09T14:21:29+00:00 Stefan Eßer se@FreeBSD.org 2019-02-09T14:21:29+00:00 4af3ade922874be16a68ffddd7c5413d544a2040 The buffer allocated in read_chat() could be 1 element too short, if the chatstr parameter passed in is 1 or 3 charachters long (e.g. "a" or "a b"). The allocation of the pointer array does not account for the terminating NULL pointer in that case. Overlapping source and destination strings are undefined in strcpy(). Instead of moving a string to the left by one character just increment the char pointer before it is assigned to the results array. 
The buffer allocated in read_chat() could be 1 element too short, if the
chatstr parameter passed in is 1 or 3 charachters long (e.g. "a" or "a b").
The allocation of the pointer array does not account for the terminating
NULL pointer in that case.

Overlapping source and destination strings are undefined in strcpy().
Instead of moving a string to the left by one character just increment the
char pointer before it is assigned to the results array.
Build getty(8) with WARNS=6. 2018-02-21T15:57:24+00:00 Edward Tomasz Napierala trasz@FreeBSD.org 2018-02-21T15:57:24+00:00 18587b84c53f716a8e7220d2ecadafdad5eefd30 Reviewed by: imp@ MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D14197 
Reviewed by:	imp@
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D14197
In libexec/getty/chat.c, replace && with & in chat_send(). The intent 2011-12-16T15:44:12+00:00 Dimitry Andric dim@FreeBSD.org 2011-12-16T15:44:12+00:00 50541c922e709424cff5d18ccb445d3b6bb3009e is to test if the CHATDEBUG_SEND bit is set in the chat_debug global. MFC after: 1 week 
is to test if the CHATDEBUG_SEND bit is set in the chat_debug global.

MFC after:	1 week
Add __unused. Ansi prototypes. 2010-12-20T08:29:54+00:00 Philippe Charnier charnier@FreeBSD.org 2010-12-20T08:29:54+00:00 9f8c312911fa39e2ceeeafc41aa2838b5391ade3 






Include gettytab.h before extern.h so that the declarations of struct
2005-04-06T17:42:24+00:00

Stefan Farfeleder
stefanf@FreeBSD.org

2005-04-06T17:42:24+00:00

410f13a58d44e0f19306df28a99227015a2a688a

gettyflags, gettynums and gettystrs are available.





gettyflags, gettynums and gettystrs are available.







Fixed a misspelling of 0 as NULL.
2004-03-14T05:27:26+00:00

Bruce Evans
bde@FreeBSD.org

2004-03-14T05:27:26+00:00

2dc8d58f59cea2ddb81d33315d788053cc29dcdf












Fix typos, mostly s/ an / a / where appropriate and a few s/an/and/
2002-12-30T21:18:15+00:00

Jens Schweikhardt
schweikh@FreeBSD.org

2002-12-30T21:18:15+00:00

d64ada501ae33c02e7c4e3ce21962907df814a5a

Add FreeBSD Id tag where missing.





Add FreeBSD Id tag where missing.







Removed unused include of <sys/resource.h> instead of depending on
2002-02-25T02:18:36+00:00

Bruce Evans
bde@FreeBSD.org

2002-02-25T02:18:36+00:00

391a2becf119235471047fabab35d36523784b0c

namespace pollution only 1 layer deep in <sys/stat.h> for its
prerequisite <sys/time.h>

Removed other unused includes.





namespace pollution only 1 layer deep in <sys/stat.h> for its
prerequisite <sys/time.h>

Removed other unused includes.







o __P removal
2002-02-06T16:38:40+00:00

Warner Losh
imp@FreeBSD.org

2002-02-06T16:38:40+00:00

95289b278a615ee45551c70f0ac343c7a8243f33

o remove register
o use strict prototypes





o remove register
o use strict prototypes







$Id$ -> $FreeBSD$
1999-08-28T00:22:10+00:00

Peter Wemm
peter@FreeBSD.org

1999-08-28T00:22:10+00:00

7f3dea244c40159a41ab22da77a434d7c5b5e85a