src/sys/ddb/db_expr.c, branch releng/15.0

sys: Automated cleanup of cdefs and other formatting

2023-11-27T05:24:00+00:00

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+.*\n/
Remove /\n+#include\s+.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+\n#include\s+/
Remove /\n+#include\s+\n#include\s+/
Remove /\n+#include\s+\n#include\s+/

Sponsored by:		Netflix

sys: Remove $FreeBSD$: one-line .c pattern

2023-08-16T17:54:36+00:00

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

fix style nit: space after if

2021-05-05T21:26:09+00:00

kernel: provide panicky version of __unreachable

2020-05-13T18:07:37+00:00

__builtin_unreachable doesn't raise any compile-time warnings/errors on its
own, so problems with its usage can't be easily detected. While it would be
nice for this situation to change and compilers to at least add a warning
for trivial cases where local state means the instruction can't be reached,
this isn't the case at the moment and likely will not happen.

This commit adds an __assert_unreachable, whose intent is incredibly clear:
it asserts that this instruction is unreachable. On INVARIANTS builds, it's
a panic(), and on non-INVARIANTS it expands to  __unreachable().

Existing users of __unreachable() are converted to __assert_unreachable,
to improve debuggability if this assumption is violated.

Reviewed by:	mjg
Differential Revision:	https://reviews.freebsd.org/D23793

SPDX: Consider code from Carnegie-Mellon University.

2017-11-30T15:48:35+00:00

Interesting cases, most likely from CMU Mach sources.

Fix right shifts on arches with db_expr_t larger than u_int (LP64 arches

2017-03-18T07:01:18+00:00

in practice).

db_expr_t is a signed type, but right shifts are fudged to evaluate
them in an unsigned type, and the unsigned type was broken by hard-
coding it as 'unsigned', so casting to it lost the top bits on arches
with db_expr_t larger than u_int.

The unsigned type with the same size as db_expr_t is not declared;
assume that db_addr_t gives it.  Fixing this properly is less important
than using the correct type for db_expr_t (originally always long for
C90, but always intmax_t since C99).

Expand error messages: print symbol names, parentheses and shift tokens,

2016-08-28T19:33:09+00:00

and negative shift counts.

Fix error messages: print "Division" instead of "Divide"; print
multiplier-like, addition-like and logical operator tokens instead of
garbage (usually the command name).

ddb has a primitive lexer with excessive information hiding that makes
it hard to find even the point in the line where a syntax error is
detected.  Old ddb just printed "Syntax error" and this was unimproved
in most places by printing a garbage token.

Add a small set of logical operators to DDB command language.

2016-05-16T19:42:38+00:00

This are based on Mach3.
Documentation is pending but has been promised.

Submitted by:	Dan Partelly
Reviewed by:	adrian, jhb (older version)

Differential Revision:	https://reviews.freebsd.org/D4230
RelNotes:	yes

ddb: Make use of our roundup() macro when available.

2016-04-26T01:52:35+00:00

ddb: finish converting boolean values.

2015-05-21T15:16:18+00:00

The replacement started at r283088 was necessarily incomplete without
replacing boolean_t with bool.  This also involved cleaning some type
mismatches and ansifying old C function declarations.

Pointed out by:	bde
Discussed with:	bde, ian, jhb