src/sys/dev/aac/aac.c, branch stable/10

MFC r330949:

2018-03-27T17:52:52+00:00

Fix FSACTL_GET_NEXT_ADAPTER_FIB under 32-bit compat.

This includes FSACTL_LNX_GET_NEXT_ADAPTER_FIB.

Reviewed by:	cem
Obtained from:	CheriBSD
Sponsored by:	DARPA, AFRL
Differential Revision:	https://reviews.freebsd.org/D14672

MFC r298280

2016-05-06T19:18:44+00:00

aacraid(4): Sanely copyin userland pointers and ensure that we don't get
anything janky from a user. (cturt)

aac(4) landergriffith+freebsdbugzilla@gmail.com pointed out that aac(4)
had the same issue and handling of pointers, so let's change that too.

PR:		206573
Submitted by:	cturt@hardenedbsd.org

MFC r280347: Remove MAXBSIZE use from drivers where it has nothing to do.

2015-04-21T11:27:50+00:00

In some cases limits are just not needed, in others -- DFLTPHYS is the
right constant to use instead.

MFC 266281:

2014-06-04T18:21:33+00:00

Clear the data buffer length field when freeing a command structure so that
it doesn't leak through when the command structure is reused for a user
command without a data buffer.

PR:		189668

MFC: r260044

2014-04-25T21:24:33+00:00

Free the MSI again on detach if allocated. Arguably, this code would be
better off living in aac_pci.c, but it doesn't seem worth creating a
aac_pci_detach() and it's also not the first PCI-specific bit in aac.c

Allow unmapped I/O via aacd(4). It shouldn't be too hard to add the

2013-05-30T00:22:07+00:00

same support for aacp(4), I'm lacking the necessary hardware for
testing, though.

- Remove pointless returns.

2013-05-30T00:11:22+00:00

- Make cm_data a void pointer and cm_flags unsigned as appropriate.

MFC after:	3 days

- Make tables, device ID strings etc const. This includes #ifdef'ing 0

2013-03-01T19:55:10+00:00

  aac_command_status_table, which is actually unused since r111532.
  While at it, make aac_if a pointer to the now const interface tables
  instead of copying them over to the softc (this alone already reduces the
  size of aac.ko on amd64 by ~1 KiB).
- Remove redundant softc members.
- Use DEVMETHOD_END.
- Use NULL instead of 0 for pointers.
- Remove redundant bzero(9)'ing of the softc.
- Use pci_enable_busmaster(9) instead of duplicating it.
- Remove redundant checking for PCIM_CMD_MEMEN (resource allocation will
  just fail).
- Canonicalize the error messages in case of resource allocation failures.
- Add support for using MSI instead of INTx, controllable via the tunable
  hw.aac.enable_msi (defaulting to on).

MFC after:	1 month

Add a sysctl to report the firmware build number.

2012-02-13T16:48:49+00:00

Some older firmware versions have issues that can be worked around by
avoiding certain operations.  Add a sysctl dev.aac.#.firmware_build to
make it easy for scripts or userland tools to detect the firmware
version.

Mark all SYSCTL_NODEs static that have no corresponding SYSCTL_DECLs.

2011-11-07T15:43:11+00:00

The SYSCTL_NODE macro defines a list that stores all child-elements of
that node. If there's no SYSCTL_DECL macro anywhere else, there's no
reason why it shouldn't be static.