<feed xmlns='http://www.w3.org/2005/Atom'>
<title>src/sys/dev/arcmsr, branch upstream/11.1.0</title>
<subtitle>FreeBSD source tree</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/'/>
<entry>
<title>MFC r311305 (by asomers):</title>
<updated>2017-03-23T06:40:20+00:00</updated>
<author>
<name>Alexander Motin</name>
<email>mav@FreeBSD.org</email>
</author>
<published>2017-03-23T06:40:20+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=6352900b3df2d8e5409dbf52d6b3d6c494817605'/>
<id>6352900b3df2d8e5409dbf52d6b3d6c494817605</id>
<content type='text'>
Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
fixed-length strings. AFAICT the only place they're read is in
sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
uses strncpy to write them, and doesn't guarantee null-termination. For at
least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
overflows. You can see the result by doing "camcontrol negotiate da0 -v".

This change null-terminates those fields everywhere they're set in the
kernel. It also shortens a few strings to ensure they'll fit within the
16-character field.

PR:		215474
Reported by:    Coverity
CID:            1009997 1010000 1010001 1010002 1010003 1010004 1010005
CID:            1331519 1010006 1215097 1010007 1288967 1010008 1306000
CID:            1211924 1010009 1010010 1010011 1010012 1010013 1010014
CID:            1147190 1010017 1010016 1010018 1216435 1010020 1010021
CID:            1010022 1009666 1018185 1010023 1010025 1010026 1010027
CID:            1010028 1010029 1010030 1010031 1010033 1018186 1018187
CID:            1010035 1010036 1010042 1010041 1010040 1010039
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
fixed-length strings. AFAICT the only place they're read is in
sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
uses strncpy to write them, and doesn't guarantee null-termination. For at
least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
overflows. You can see the result by doing "camcontrol negotiate da0 -v".

This change null-terminates those fields everywhere they're set in the
kernel. It also shortens a few strings to ensure they'll fit within the
16-character field.

PR:		215474
Reported by:    Coverity
CID:            1009997 1010000 1010001 1010002 1010003 1010004 1010005
CID:            1331519 1010006 1215097 1010007 1288967 1010008 1306000
CID:            1211924 1010009 1010010 1010011 1010012 1010013 1010014
CID:            1147190 1010017 1010016 1010018 1216435 1010020 1010021
CID:            1010022 1009666 1018185 1010023 1010025 1010026 1010027
CID:            1010028 1010029 1010030 1010031 1010033 1018186 1018187
CID:            1010035 1010036 1010042 1010041 1010040 1010039
</pre>
</div>
</content>
</entry>
<entry>
<title>MFC r313982, r314068:</title>
<updated>2017-03-14T02:06:03+00:00</updated>
<author>
<name>Pedro F. Giffuni</name>
<email>pfg@FreeBSD.org</email>
</author>
<published>2017-03-14T02:06:03+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=bd0faecc931277934a72772a410ede5663969cdb'/>
<id>bd0faecc931277934a72772a410ede5663969cdb</id>
<content type='text'>
sys: Replace zero with NULL for pointers.

Found with:	devel/coccinelle
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
sys: Replace zero with NULL for pointers.

Found with:	devel/coccinelle
</pre>
</div>
</content>
</entry>
<entry>
<title>MFC r313949: Remove dead mentions of CAM target mode APIs from drivers.</title>
<updated>2017-02-28T06:46:41+00:00</updated>
<author>
<name>Alexander Motin</name>
<email>mav@FreeBSD.org</email>
</author>
<published>2017-02-28T06:46:41+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=f7378b0367fdc1a615fc5d04dddc1adb86b94874'/>
<id>f7378b0367fdc1a615fc5d04dddc1adb86b94874</id>
<content type='text'>
This makes grepping kernel for target mode implementation much easier.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes grepping kernel for target mode implementation much easier.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make sure we check for CAM_CDB_POINTER for all drivers. Also, for the</title>
<updated>2016-03-15T05:17:29+00:00</updated>
<author>
<name>Warner Losh</name>
<email>imp@FreeBSD.org</email>
</author>
<published>2016-03-15T05:17:29+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=4aa947cb707c705ba772b06628d5ad6f4b0575b7'/>
<id>4aa947cb707c705ba772b06628d5ad6f4b0575b7</id>
<content type='text'>
drivers I've touched, filter out CAM_CDB_PHYS.

Differential Revision: https://reviews.freebsd.org/D5585
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
drivers I've touched, filter out CAM_CDB_PHYS.

Differential Revision: https://reviews.freebsd.org/D5585
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace several bus_alloc_resource() calls with bus_alloc_resource_any()</title>
<updated>2016-02-27T03:34:01+00:00</updated>
<author>
<name>Justin Hibbits</name>
<email>jhibbits@FreeBSD.org</email>
</author>
<published>2016-02-27T03:34:01+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=eff83876b694c469eb9385a3bc106c8f66c72e75'/>
<id>eff83876b694c469eb9385a3bc106c8f66c72e75</id>
<content type='text'>
Most of these are BARs, and we allocate them in their entirety.  The one outlier
in this is amdsbwd, which calls bus_set_resource() prior.

Reviewed by:	jhb
Differential Revision:	https://reviews.freebsd.org/D5370 (partial)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Most of these are BARs, and we allocate them in their entirety.  The one outlier
in this is amdsbwd, which calls bus_set_resource() prior.

Reviewed by:	jhb
Differential Revision:	https://reviews.freebsd.org/D5370 (partial)
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace several bus_alloc_resource() calls using default arguments with bus_alloc_resource_any()</title>
<updated>2016-02-19T03:37:56+00:00</updated>
<author>
<name>Justin Hibbits</name>
<email>jhibbits@FreeBSD.org</email>
</author>
<published>2016-02-19T03:37:56+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=43cd61606b6bfae52bb09856277751103bfa28fd'/>
<id>43cd61606b6bfae52bb09856277751103bfa28fd</id>
<content type='text'>
Since these calls only use default arguments, bus_alloc_resource_any() is the
right call.

Differential Revision: https://reviews.freebsd.org/D5306
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since these calls only use default arguments, bus_alloc_resource_any() is the
right call.

Differential Revision: https://reviews.freebsd.org/D5306
</pre>
</div>
</content>
</entry>
<entry>
<title>Update arcmsr(4) to 1.30.00.00 in order to add support of</title>
<updated>2015-12-02T05:35:04+00:00</updated>
<author>
<name>Xin LI</name>
<email>delphij@FreeBSD.org</email>
</author>
<published>2015-12-02T05:35:04+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=b23a1998d83c5545dc0d0e03c5bc19cfa86983c9'/>
<id>b23a1998d83c5545dc0d0e03c5bc19cfa86983c9</id>
<content type='text'>
ARC-1203 SATA RAID controllers.

Many thanks to Areca for continuing to support FreeBSD.

Submitted by:	黃清隆 &lt;ching2048 areca com tw&gt;
MFC after:	2 weeks
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ARC-1203 SATA RAID controllers.

Many thanks to Areca for continuing to support FreeBSD.

Submitted by:	黃清隆 &lt;ching2048 areca com tw&gt;
MFC after:	2 weeks
</pre>
</div>
</content>
</entry>
<entry>
<title>Prevent overflow issues in timeout processing</title>
<updated>2014-11-21T21:01:24+00:00</updated>
<author>
<name>Steven Hartland</name>
<email>smh@FreeBSD.org</email>
</author>
<published>2014-11-21T21:01:24+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=85c9dd9d895261632d58cf98da6608b93dd5d7f8'/>
<id>85c9dd9d895261632d58cf98da6608b93dd5d7f8</id>
<content type='text'>
Previously, any timeout value for which (timeout * hz) will overflow the
signed integer, will give weird results, since callout(9) routines will
convert negative values of ticks to '1'. For unsigned integer overflow we
will get sufficiently smaller timeout values than expected.

Switch from callout_reset, which requires conversion to int based ticks
to callout_reset_sbt to avoid this.

Also correct isci to correctly resolve ccb timeout.

This was based on the original work done by Eygene Ryabinkin
&lt;rea@freebsd.org&gt; back in 5 Aug 2011 which used a macro to help avoid
the overlow.

Differential Revision:	https://reviews.freebsd.org/D1157
Reviewed by:	mav, davide
MFC after:	1 month
Sponsored by:	Multiplay
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, any timeout value for which (timeout * hz) will overflow the
signed integer, will give weird results, since callout(9) routines will
convert negative values of ticks to '1'. For unsigned integer overflow we
will get sufficiently smaller timeout values than expected.

Switch from callout_reset, which requires conversion to int based ticks
to callout_reset_sbt to avoid this.

Also correct isci to correctly resolve ccb timeout.

This was based on the original work done by Eygene Ryabinkin
&lt;rea@freebsd.org&gt; back in 5 Aug 2011 which used a macro to help avoid
the overlow.

Differential Revision:	https://reviews.freebsd.org/D1157
Reviewed by:	mav, davide
MFC after:	1 month
Sponsored by:	Multiplay
</pre>
</div>
</content>
</entry>
<entry>
<title>Commit 2/2: vendor whitespace changes to the driver.</title>
<updated>2013-12-18T19:25:40+00:00</updated>
<author>
<name>Xin LI</name>
<email>delphij@FreeBSD.org</email>
</author>
<published>2013-12-18T19:25:40+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=47e52731cc0d32f1fe78bdb140c67b352a765dba'/>
<id>47e52731cc0d32f1fe78bdb140c67b352a765dba</id>
<content type='text'>
Many thanks to Areca for continuing to support FreeBSD.

Submitted by:	黃清隆 &lt;ching2048 areca com tw&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Many thanks to Areca for continuing to support FreeBSD.

Submitted by:	黃清隆 &lt;ching2048 areca com tw&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Commit 1/2: update arcmsr(4) to 1.20.00.29 in order to add</title>
<updated>2013-12-18T19:23:05+00:00</updated>
<author>
<name>Xin LI</name>
<email>delphij@FreeBSD.org</email>
</author>
<published>2013-12-18T19:23:05+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=224a78aeed00a7ab617e3cbce92f030044a8b7cb'/>
<id>224a78aeed00a7ab617e3cbce92f030044a8b7cb</id>
<content type='text'>
support of ARC-1883 SAS 12Gb/s RAID controllers.

Many thanks to Areca for continuing to support FreeBSD.

Submitted by:	黃清隆 &lt;ching2048 areca com tw&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
support of ARC-1883 SAS 12Gb/s RAID controllers.

Many thanks to Areca for continuing to support FreeBSD.

Submitted by:	黃清隆 &lt;ching2048 areca com tw&gt;
</pre>
</div>
</content>
</entry>
</feed>
