<feed xmlns='http://www.w3.org/2005/Atom'>
<title>src/sys/dev/asmc, branch stable/14</title>
<subtitle>FreeBSD source tree</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/'/>
<entry>
<title>asmc: unbreak build: add missing curly brace</title>
<updated>2026-02-22T18:51:17+00:00</updated>
<author>
<name>Enji Cooper</name>
<email>ngie@FreeBSD.org</email>
</author>
<published>2026-02-08T23:51:51+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=b49d30adb87ba1442812e80efae1f9ab297f204b'/>
<id>b49d30adb87ba1442812e80efae1f9ab297f204b</id>
<content type='text'>
Fixes:	d76bb14e022 ("chore: asmc: additional style(9) cleanup")
(cherry picked from commit 9ccdf3f36e014f0060ea192ffed91a7679003355)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes:	d76bb14e022 ("chore: asmc: additional style(9) cleanup")
(cherry picked from commit 9ccdf3f36e014f0060ea192ffed91a7679003355)
</pre>
</div>
</content>
</entry>
<entry>
<title>chore: asmc: minor code cleanup</title>
<updated>2026-02-22T04:32:07+00:00</updated>
<author>
<name>Enji Cooper</name>
<email>ngie@FreeBSD.org</email>
</author>
<published>2026-01-01T06:43:05+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=38917c4f5eabda8f20391b3d84e1cd12f0e5734d'/>
<id>38917c4f5eabda8f20391b3d84e1cd12f0e5734d</id>
<content type='text'>
- Use symbolic names in Mac definitions in lieu of the unrolled values
  they represent.
- Delete trailing whitespace.
- Fix indentation.

No functional change intended.

MFC after:	1 week

(cherry picked from commit a8f3c3b5d4d9dac1dafe4094fe35b30ffdf26178)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Use symbolic names in Mac definitions in lieu of the unrolled values
  they represent.
- Delete trailing whitespace.
- Fix indentation.

No functional change intended.

MFC after:	1 week

(cherry picked from commit a8f3c3b5d4d9dac1dafe4094fe35b30ffdf26178)
</pre>
</div>
</content>
</entry>
<entry>
<title>asmc: Add support for macmini 6,1 and 6,2 (late 2012) models</title>
<updated>2026-02-22T04:31:33+00:00</updated>
<author>
<name>Hrant Dadivanyan</name>
<email>hrant@dadivanyan.net</email>
</author>
<published>2025-04-20T15:07:34+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=dbeb51347afaf910d1962d263da7a0e54d6343f3'/>
<id>dbeb51347afaf910d1962d263da7a0e54d6343f3</id>
<content type='text'>
This adds the ASMC support for the macmini 6,1 and 6,2.

PR:		kern/268141
Differential Revision:	https://reviews.freebsd.org/D49929

(cherry picked from commit 93ca9e44b752e6a9aeb0f761a022d14281d1a4e3)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds the ASMC support for the macmini 6,1 and 6,2.

PR:		kern/268141
Differential Revision:	https://reviews.freebsd.org/D49929

(cherry picked from commit 93ca9e44b752e6a9aeb0f761a022d14281d1a4e3)
</pre>
</div>
</content>
</entry>
<entry>
<title>chore: asmc: additional style(9) cleanup</title>
<updated>2026-02-22T04:30:04+00:00</updated>
<author>
<name>Enji Cooper</name>
<email>ngie@FreeBSD.org</email>
</author>
<published>2026-02-08T20:04:32+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=c20013933af90ed377497769bf66eaf276b5c6c2'/>
<id>c20013933af90ed377497769bf66eaf276b5c6c2</id>
<content type='text'>
Pick out non-gratuitous style(9) changes suggested by `clang-format` on
the driver. This helps eliminate minor stylistic issues with spaces,
braces, line lengths, etc, so future functional changes in the driver
will be easier to pick out.

Many of the other `clang-format` suggested changes were not taken because
they were considerably more gratuitous.

No functional change intended.

MFC after:	1 week

(cherry picked from commit d76bb14e0224e235209d8c07ec132d602b18648b)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Pick out non-gratuitous style(9) changes suggested by `clang-format` on
the driver. This helps eliminate minor stylistic issues with spaces,
braces, line lengths, etc, so future functional changes in the driver
will be easier to pick out.

Many of the other `clang-format` suggested changes were not taken because
they were considerably more gratuitous.

No functional change intended.

MFC after:	1 week

(cherry picked from commit d76bb14e0224e235209d8c07ec132d602b18648b)
</pre>
</div>
</content>
</entry>
<entry>
<title>Add ASMC_DEBUG make option</title>
<updated>2026-02-22T04:29:53+00:00</updated>
<author>
<name>Enji Cooper</name>
<email>ngie@FreeBSD.org</email>
</author>
<published>2026-01-04T08:27:57+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=ab3eaa6ea29d846d3beb7dd90dbe0c7e0cea26c4'/>
<id>ab3eaa6ea29d846d3beb7dd90dbe0c7e0cea26c4</id>
<content type='text'>
This allows folks to enable debug statements in asmc(4) using kernel
configs via the `options ASMC_DEBUG` directive.

While here, remove a duplicate `device vt_efifb` directive in `NOTES`
as it's already handled in the `GENERIC` config

MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D54511

(cherry picked from commit f224591746bdaf14ad5f63de4738a3146cc2f55f)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows folks to enable debug statements in asmc(4) using kernel
configs via the `options ASMC_DEBUG` directive.

While here, remove a duplicate `device vt_efifb` directive in `NOTES`
as it's already handled in the `GENERIC` config

MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D54511

(cherry picked from commit f224591746bdaf14ad5f63de4738a3146cc2f55f)
</pre>
</div>
</content>
</entry>
<entry>
<title>asmc: Add support for MacBookPro11,5</title>
<updated>2026-02-22T04:04:50+00:00</updated>
<author>
<name>Abdelkader Boudih</name>
<email>oss@seuros.com</email>
</author>
<published>2026-01-14T03:13:46+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=75045de2ba9ceb5a0aac534f477e5e9fc49d3e2b'/>
<id>75045de2ba9ceb5a0aac534f477e5e9fc49d3e2b</id>
<content type='text'>
  Add support for the MacBookPro11,5 (Mid 2015, 15-inch with AMD Radeon R9 M370X GPU)
  to the Apple SMC driver.

  Debug testing revealed this model lacks several SMC keys present on MacBookPro11,4
  (IBLC, ICMC, IC2C), that model-specific sensor definitions.

Differential Revision:	https://reviews.freebsd.org/D54665
Reviewed by:	adrian

(cherry picked from commit c498eaa2f9090d7bdc6456181d8bf74869288bbb)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  Add support for the MacBookPro11,5 (Mid 2015, 15-inch with AMD Radeon R9 M370X GPU)
  to the Apple SMC driver.

  Debug testing revealed this model lacks several SMC keys present on MacBookPro11,4
  (IBLC, ICMC, IC2C), that model-specific sensor definitions.

Differential Revision:	https://reviews.freebsd.org/D54665
Reviewed by:	adrian

(cherry picked from commit c498eaa2f9090d7bdc6456181d8bf74869288bbb)
</pre>
</div>
</content>
</entry>
<entry>
<title>asmc: add per-fan manual mode control via sysctl</title>
<updated>2026-02-22T04:04:06+00:00</updated>
<author>
<name>Abdelkader Boudih</name>
<email>oss@seuros.com</email>
</author>
<published>2026-01-05T18:03:23+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=f0d2b37997227cd580abadefbb1cd71fcaef9c6e'/>
<id>f0d2b37997227cd580abadefbb1cd71fcaef9c6e</id>
<content type='text'>
Add per-fan manual mode control via dev.asmc.0.fan.N.manual sysctl.

Apple SMCs support manual fan control via the FS! SMC key,
a 16-bit bitmask where each bit controls one fan (0=auto, 1=manual).

This change adds a new sysctl per fan:
    dev.asmc.0.fan.N.manual (0=auto, 1=manual)

When set to manual mode (1), the fan runs at the speed set via
dev.asmc.0.fan.N.targetspeed instead of automatic thermal control.  When
set to auto mode (0), the SMC controls fan speed automatically.

The FS! key was already defined in asmcvar.h but not accessible.
This exposes it for debugging, testing, and advanced fan control.

Implementation uses read-modify-write to allow independent control of
each fan without affecting others.

Reviewed by:	adrian, markj
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D54437

(cherry picked from commit 1ecac45cfc5f0886907c34ec0da2c1b32618665d)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add per-fan manual mode control via dev.asmc.0.fan.N.manual sysctl.

Apple SMCs support manual fan control via the FS! SMC key,
a 16-bit bitmask where each bit controls one fan (0=auto, 1=manual).

This change adds a new sysctl per fan:
    dev.asmc.0.fan.N.manual (0=auto, 1=manual)

When set to manual mode (1), the fan runs at the speed set via
dev.asmc.0.fan.N.targetspeed instead of automatic thermal control.  When
set to auto mode (0), the SMC controls fan speed automatically.

The FS! key was already defined in asmcvar.h but not accessible.
This exposes it for debugging, testing, and advanced fan control.

Implementation uses read-modify-write to allow independent control of
each fan without affecting others.

Reviewed by:	adrian, markj
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D54437

(cherry picked from commit 1ecac45cfc5f0886907c34ec0da2c1b32618665d)
</pre>
</div>
</content>
</entry>
<entry>
<title>asmc: improve asmc_dumpall to read actual SMC key count</title>
<updated>2026-02-22T04:04:06+00:00</updated>
<author>
<name>Abdelkader Boudih</name>
<email>oss@seuros.com</email>
</author>
<published>2026-01-03T18:33:11+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=26f41f8e5ebee7faf2fb9a65baa18bb41ad63564'/>
<id>26f41f8e5ebee7faf2fb9a65baa18bb41ad63564</id>
<content type='text'>
The asmc_dumpall debug function previously used a hardcoded loop limit
of 0x100 (256) keys with a "XXX magic number" comment.

This change improves asmc_dumpall to:

* Read the actual number of keys from the ASMC_NKEYS SMC key
* Print the key count being dumped for better debugging output
* Loop only up to the actual key count (e.g., 297 on Mac Mini 5,1)

This provides more accurate debug output and removes the magic number.

Tested on Mac Mini 5,1 (FreeBSD 16.0-CURRENT):

* Rebuild kernel with DEBUG enabled in asmc driver
* Boot with new kernel
* Verify dmesg shows "asmc_dumpall: dumping 297 keys" (or actual count)
* Verify all 297 keys are dumped

Differential Revision:	https://reviews.freebsd.org/D54436
Reviewed by:	markj, adrian

(cherry picked from commit 2a7c4685b7693bfa15e2bd4d5e82905a368b0030)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The asmc_dumpall debug function previously used a hardcoded loop limit
of 0x100 (256) keys with a "XXX magic number" comment.

This change improves asmc_dumpall to:

* Read the actual number of keys from the ASMC_NKEYS SMC key
* Print the key count being dumped for better debugging output
* Loop only up to the actual key count (e.g., 297 on Mac Mini 5,1)

This provides more accurate debug output and removes the magic number.

Tested on Mac Mini 5,1 (FreeBSD 16.0-CURRENT):

* Rebuild kernel with DEBUG enabled in asmc driver
* Boot with new kernel
* Verify dmesg shows "asmc_dumpall: dumping 297 keys" (or actual count)
* Verify all 297 keys are dumped

Differential Revision:	https://reviews.freebsd.org/D54436
Reviewed by:	markj, adrian

(cherry picked from commit 2a7c4685b7693bfa15e2bd4d5e82905a368b0030)
</pre>
</div>
</content>
</entry>
<entry>
<title>asmc: Add support for MacbookPro11,4</title>
<updated>2024-09-20T11:39:16+00:00</updated>
<author>
<name>Joshua Rogers</name>
<email>Joshua@Joshua.Hu</email>
</author>
<published>2024-06-11T19:51:51+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=9512710ddf33c49dd0f9c387393866306225efc3'/>
<id>9512710ddf33c49dd0f9c387393866306225efc3</id>
<content type='text'>
Signed-off-by: Joshua Rogers &lt;Joshua@Joshua.Hu&gt;

MFC after:	2 weeks
Pull Request:	https://github.com/freebsd/freebsd-src/pull/1366

(cherry picked from commit 49a5fe1a017fc179c79b74f409440e070511a0ab)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Joshua Rogers &lt;Joshua@Joshua.Hu&gt;

MFC after:	2 weeks
Pull Request:	https://github.com/freebsd/freebsd-src/pull/1366

(cherry picked from commit 49a5fe1a017fc179c79b74f409440e070511a0ab)
</pre>
</div>
</content>
</entry>
<entry>
<title>sys: Remove $FreeBSD$: one-line .c pattern</title>
<updated>2023-08-16T17:54:36+00:00</updated>
<author>
<name>Warner Losh</name>
<email>imp@FreeBSD.org</email>
</author>
<published>2023-08-16T17:54:36+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=685dc743dc3b5645e34836464128e1c0558b404b'/>
<id>685dc743dc3b5645e34836464128e1c0558b404b</id>
<content type='text'>
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
</pre>
</div>
</content>
</entry>
</feed>
