src/sys/dev/ata, branch upstream/11.1.0FreeBSD source treehttp://cgit.freebsd.org/src/atom?h=upstream%2F11.1.02017-03-23T06:40:20ZMFC r311305 (by asomers):2017-03-23T06:40:20ZAlexander Motinmav@FreeBSD.org2017-03-23T06:40:20Zurn:sha1:6352900b3df2d8e5409dbf52d6b3d6c494817605
Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)
The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
fixed-length strings. AFAICT the only place they're read is in
sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
uses strncpy to write them, and doesn't guarantee null-termination. For at
least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
overflows. You can see the result by doing "camcontrol negotiate da0 -v".
This change null-terminates those fields everywhere they're set in the
kernel. It also shortens a few strings to ensure they'll fit within the
16-character field.
PR: 215474
Reported by: Coverity
CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005
CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000
CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014
CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021
CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027
CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187
CID: 1010035 1010036 1010042 1010041 1010040 1010039
MFC r313949: Remove dead mentions of CAM target mode APIs from drivers.2017-02-28T06:46:41ZAlexander Motinmav@FreeBSD.org2017-02-28T06:46:41Zurn:sha1:f7378b0367fdc1a615fc5d04dddc1adb86b94874
This makes grepping kernel for target mode implementation much easier.
sys/dev: minor spelling fixes.2016-05-03T03:41:25ZPedro F. Giffunipfg@FreeBSD.org2016-05-03T03:41:25Zurn:sha1:453130d9bfc1c6d68b366dfcb041689d69f81295
Most affect comments, very few have user-visible effects.
Implement Auxiliary register. Add PIM_ATA_EXT flag to flag that a SIM2016-04-17T05:24:36ZWarner Loshimp@FreeBSD.org2016-04-17T05:24:36Zurn:sha1:916d57dfc540681468c6093f2cb027c46be9444e
can handle it, and add the code to add it to the FIS that's sent to
the drive. The mvs driver is the only other ATA driver in the system,
and its hardware doesn't appear to support setting the Auxiliary
register.
Differential Revision: https://reviews.freebsd.org/D5598
Cleanup unnecessary semicolons from the kernel.2016-04-10T23:07:00ZPedro F. Giffunipfg@FreeBSD.org2016-04-10T23:07:00Zurn:sha1:74b8d63dcc17c07d8cb21e13f6db517698efd49f
Found with devel/coccinelle.
Small typo.2016-03-29T23:33:44ZPedro F. Giffunipfg@FreeBSD.org2016-03-29T23:33:44Zurn:sha1:9c2ceeafd57795caa65ea478ceb326a09212fd6fMigrate many bus_alloc_resource() calls to bus_alloc_resource_anywhere().2016-02-27T03:38:01ZJustin Hibbitsjhibbits@FreeBSD.org2016-02-27T03:38:01Zurn:sha1:c47476d7e6801deffc8b3c057d0fbf7d2335a0c2
Most calls to bus_alloc_resource() use "anywhere" as the range, with a given
count. Migrate these to use the new bus_alloc_resource_anywhere() API.
Reviewed by: jhb
Differential Revision: https://reviews.freebsd.org/D5370
Ternary operator has lower priority than OR.2016-02-17T21:13:33ZGleb Smirnoffglebius@FreeBSD.org2016-02-17T21:13:33Zurn:sha1:ec911df8daeeae602bacee6fed63661b0ef4ba53
Found by: PVS-Studio
Convert a few more long -> rman_res_t.2016-02-16T17:55:10ZJustin Hibbitsjhibbits@FreeBSD.org2016-02-16T17:55:10Zurn:sha1:89977ce22708ac21636928e367f4ee6bdabcfda7Add defines for WRITE_UNCORRECTABLE ATA command, and improve command logging2016-02-04T19:53:54ZRavi Pokalarpokala@FreeBSD.org2016-02-04T19:53:54Zurn:sha1:dd4637c0787b724df2dddc6509383fb1ab0ebb9d
Add #defines for ATA_WRITE_UNCORRECTABLE48 and its features. Update the
decoding in ATACAM to recognize the new values. Also improve command
decoding for a few other commands (SMART, NOP, SET_FEATURES). Bring the
decoding in ata(4) up to parity with ATACAM.
Reviewed by: mav, imp
MFC after: 1 month
Sponsored by: Panasas, Inc.
Differential Revision: https://reviews.freebsd.org/D5181