src/sys/dev/ath/ath_hal, branch main FreeBSD source tree ath_hal(4): Fix a typo in a source code comment 2026-01-31T15:20:32+00:00 Gordon Bergling gbe@FreeBSD.org 2026-01-31T15:20:32+00:00 a17659fe260ce16c1e373b543ca9f13cc14340ea - s/arithmatic/arithmetic/ MFC after: 5 days 
- s/arithmatic/arithmetic/

MFC after:	5 days
ath(4): Fix a typo in a device messsage 2025-10-31T18:50:40+00:00 Gordon Bergling gbe@FreeBSD.org 2025-10-29T15:26:59+00:00 3eaa2a852b475c7f063bbf677fa536e76514d309 - s/Orignal/Original/ MFC after: 5 days 
- s/Orignal/Original/

MFC after:	5 days
ath(4): Fix a typo in a source code comment 2025-04-28T09:22:10+00:00 Gordon Bergling gbe@FreeBSD.org 2025-04-28T09:22:10+00:00 3ad86f460fa81ecc036fb5af25848f10b68b4019 - s/chang/change/ MFC after: 3 days 
- s/chang/change/

MFC after:	3 days
Fix enum warning in ath_hal's ar9002 2024-10-23T18:26:35+00:00 Dimitry Andric dim@FreeBSD.org 2024-07-31T09:43:50+00:00 36d486cc2ecdb9c290dba65bd5668b7e50d0d822 This fixes a clang 19 warning: sys/dev/ath/ath_hal/ar9002/ar9285_btcoex.c:57:32: error: comparison of different enumeration types ('HAL_BOOL' and 'HAL_ANT_SETTING') [-Werror,-Wenum-compare] 57 | (AH5212(ah)->ah_diversity != HAL_ANT_VARIABLE)) { | ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~ The `ah_diversity` field of `struct ath_hal_5212` is of type `HAL_BOOL`, not the enum type `HAL_ANT_SETTING`. In other code, `ah_diversity` is set to `AH_TRUE` whenever the related field `ah_antControl` is set to `HAL_ANT_VARIABLE`. It is not entirely clear to me what the intended statement is here: the test as it is written now compares the enum value 0 to `ah_diversity`, so in effect it enables the following block whenever `ah_diversity` is `AH_TRUE`. Write it like that, to avoid the compiler warning. MFC after: 3 days 
This fixes a clang 19 warning:

    sys/dev/ath/ath_hal/ar9002/ar9285_btcoex.c:57:32: error: comparison of different enumeration types ('HAL_BOOL' and 'HAL_ANT_SETTING') [-Werror,-Wenum-compare]
       57 |             (AH5212(ah)->ah_diversity != HAL_ANT_VARIABLE)) {
          |              ~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~

The `ah_diversity` field of `struct ath_hal_5212` is of type `HAL_BOOL`,
not the enum type `HAL_ANT_SETTING`. In other code, `ah_diversity` is
set to `AH_TRUE` whenever the related field `ah_antControl` is set to
`HAL_ANT_VARIABLE`.

It is not entirely clear to me what the intended statement is here: the
test as it is written now compares the enum value 0 to `ah_diversity`,
so in effect it enables the following block whenever `ah_diversity` is
`AH_TRUE`. Write it like that, to avoid the compiler warning.

MFC after:	3 days
ath: Fix typo (triple M) 2024-02-03T01:35:00+00:00 Jose Luis Duran jlduran@gmail.com 2024-02-03T00:35:54+00:00 328df6da9ef20fefed1749c05d4f19d47dfb7803 Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/963 
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/963
ath_hal: Fix a couple of type mismatches in function prototypes 2023-11-15T02:36:32+00:00 John Baldwin jhb@FreeBSD.org 2023-11-15T02:36:32+00:00 1e65df68403acac2231dda161fd12e62f888a031 Reported by: GCC 13 via -Wenum-int-mismatch Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D42584 
Reported by:	GCC 13 via -Wenum-int-mismatch
Reviewed by:	imp, emaste
Differential Revision:	https://reviews.freebsd.org/D42584
sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16T17:54:11+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:11+00:00 95ee2897e98f5d444f26ed2334cc7c439f9c16c6 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ 
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
ath(4): Remove MIPS SoC build glue and AR9130 from FreeBSD HAL 2023-08-09T15:44:46+00:00 Marius Strobl marius@FreeBSD.org 2023-08-07T19:16:11+00:00 077ef5b445f10f41723b63ab9c24a9809c61afb8 All of these are obsoleted by the general removal of MIPS support. Actually, corresponding to the removed AH_SUPPORT_x, there is more superfluous support sprinkled across the HAL source. However, that code is left in place for now in order to ease a sync to NetBSD. Reviewed by: emaste (w/ man page fix) Approved by: adrian Differential Revision: https://reviews.freebsd.org/D41355 
All of these are obsoleted by the general removal of MIPS support.

Actually, corresponding to the removed AH_SUPPORT_x, there is more
superfluous support sprinkled across the HAL source. However, that
code is left in place for now in order to ease a sync to NetBSD.

Reviewed by:	emaste (w/ man page fix)
Approved by:	adrian
Differential Revision:	https://reviews.freebsd.org/D41355
spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD 2023-05-12T16:44:03+00:00 Warner Losh imp@FreeBSD.org 2023-05-10T15:40:58+00:00 4d846d260e2b9a3d4d0a701462568268cbfe7a5b The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix 
The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of BSD-2-Clause.

Discussed with:		pfg
MFC After:		3 days
Sponsored by:		Netflix
ath: Fix mismatches in array bounds. 2022-12-07T20:30:42+00:00 John Baldwin jhb@FreeBSD.org 2022-12-07T20:30:42+00:00 c1ebd4c98fb8feab6931a536390739fc115e1805 Reported by: GCC -Warray-parameter Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D37542 
Reported by:	GCC -Warray-parameter
Reviewed by:	imp, emaste
Differential Revision:	https://reviews.freebsd.org/D37542