src/sys/dev/ath/ath_hal, branch releng/14.2

Fix enum warning in ath_hal's ar9002

2024-10-27T10:53:01+00:00

This fixes a clang 19 warning:

    sys/dev/ath/ath_hal/ar9002/ar9285_btcoex.c:57:32: error: comparison of different enumeration types ('HAL_BOOL' and 'HAL_ANT_SETTING') [-Werror,-Wenum-compare]
       57 |             (AH5212(ah)->ah_diversity != HAL_ANT_VARIABLE)) {
          |              ~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~

The `ah_diversity` field of `struct ath_hal_5212` is of type `HAL_BOOL`,
not the enum type `HAL_ANT_SETTING`. In other code, `ah_diversity` is
set to `AH_TRUE` whenever the related field `ah_antControl` is set to
`HAL_ANT_VARIABLE`.

It is not entirely clear to me what the intended statement is here: the
test as it is written now compares the enum value 0 to `ah_diversity`,
so in effect it enables the following block whenever `ah_diversity` is
`AH_TRUE`. Write it like that, to avoid the compiler warning.

MFC after:	3 days

(cherry picked from commit 36d486cc2ecdb9c290dba65bd5668b7e50d0d822)

ath_hal: Fix a couple of type mismatches in function prototypes

2024-01-03T17:43:48+00:00

Reported by:	GCC 13 via -Wenum-int-mismatch
Reviewed by:	imp, emaste
Differential Revision:	https://reviews.freebsd.org/D42584

(cherry picked from commit 1e65df68403acac2231dda161fd12e62f888a031)

sys: Remove $FreeBSD$: two-line .h pattern

2023-08-16T17:54:11+00:00

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

ath(4): Remove MIPS SoC build glue and AR9130 from FreeBSD HAL

2023-08-09T15:44:46+00:00

All of these are obsoleted by the general removal of MIPS support.

Actually, corresponding to the removed AH_SUPPORT_x, there is more
superfluous support sprinkled across the HAL source. However, that
code is left in place for now in order to ease a sync to NetBSD.

Reviewed by:	emaste (w/ man page fix)
Approved by:	adrian
Differential Revision:	https://reviews.freebsd.org/D41355

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

2023-05-12T16:44:03+00:00

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of BSD-2-Clause.

Discussed with:		pfg
MFC After:		3 days
Sponsored by:		Netflix

ath: Fix mismatches in array bounds.

2022-12-07T20:30:42+00:00

Reported by:	GCC -Warray-parameter
Reviewed by:	imp, emaste
Differential Revision:	https://reviews.freebsd.org/D37542

ath(4): Fix two typos in source code comments

2022-09-03T13:24:48+00:00

- s/overriden/overridden/

MFC after:	3 days

ath(4): Remove a double word in a few source code comments

2022-04-09T08:55:00+00:00

- s/for for/for/

MFC after:	3 days

ath: Fix a typo in a source code comment

2022-03-27T17:28:49+00:00

- s/ony/only/

MFC after:	3 days

[ath_hal] Add get/set NAV functions

2021-04-19T05:52:31+00:00

The NAV (network allocation vector) register reflects the current MAC
tracking of NAV - when it will stay quiet before transmitting.

Other devices transmit their frame durations in their 802.11 PHY headers
and all devices that hear a frame - even if it's one in an encoding
they don't understand - will understand the low bitrate PHY header that
includes the frame duration.  So, they'll set NAV to this value so
they'll stay quiet until the transmit completes.

Anyway, sometimes the PHY NAV header is garbled and sometimes, notably
older broadcom devices, will fake a long NAV so they can get "cleaner" air
for local calibration.  When this happens, the hardware will stay quiet
for quite some time and this can lead to missed/stuck beacons, or
(for Very Large Values) a MAC hang.

This code just adds the ability to get/set the NAV; the driver will
need to take care of using it during transmit hangs and beacon misses
to see if it's due to a trash looking NAV.