src/sys/dev/firewire, branch main FreeBSD source tree chore: replace {0, 0} with {DEV,KOBJ}METHOD_END 2026-02-25T05:59:34+00:00 Enji Cooper ngie@FreeBSD.org 2026-02-21T06:14:46+00:00 0fc6c3f731a2cca3120798806c330a3081c9424b Both of the aforementioned macros have been present in FreeBSD for well over a decade: 2009 for `KOBJMETHOD_END`; 2011 for `DEVMETHOD_END`. Adapt all hardcoded references of `{0, 0}` with `DEVMETHOD_END` and `KOBJMETHOD_END` as appropriate. This helps ensure that future adaptations to drivers following patterns documented in driver(9) can be made more easily/without issue. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D55414 
Both of the aforementioned macros have been present in FreeBSD
for well over a decade: 2009 for `KOBJMETHOD_END`; 2011 for
`DEVMETHOD_END`.

Adapt all hardcoded references of `{0, 0}` with `DEVMETHOD_END`
and `KOBJMETHOD_END` as appropriate. This helps ensure that
future adaptations to drivers following patterns documented
in driver(9) can be made more easily/without issue.

MFC after:	1 week
Differential Revision:	 https://reviews.freebsd.org/D55414
newbus: replace leftover device unit wildcards 2025-06-21T02:57:45+00:00 Ahmad Khalifa vexeduxr@FreeBSD.org 2025-06-11T00:25:08+00:00 b670c9bafc0e31c7609969bf374b2e80bdc00211 Reviewed by: imp, jhb Approved by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D50913 
Reviewed by:	imp, jhb
Approved by:	imp (mentor)
Differential Revision:	https://reviews.freebsd.org/D50913
Internal scheduling priorities: Always use symbolic ones 2025-06-18T02:08:02+00:00 Olivier Certner olce@FreeBSD.org 2024-05-22T15:29:22+00:00 8ecc41918066422d6788a67251b22d11a6efeddf Replace priorities specified by a base priority and some hardcoded offset value by symbolic constants. Hardcoded offsets prevent changing the difference between priorities without changing their relative ordering, and is generally a dangerous practice since the resulting priority may inadvertently belong to a different selection policy's range. Since RQ_PPQ is 4, differences of less than 4 are insignificant, so just remove them. These small differences have not been changed for years, so it is likely they have no real meaning (besides having no practical effect). One can still consult the changes history to recover them if ever needed. No functional change (intended). MFC after: 1 month Event: Kitchener-Waterloo Hackathon 202506 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45390 
Replace priorities specified by a base priority and some hardcoded
offset value by symbolic constants.  Hardcoded offsets prevent changing
the difference between priorities without changing their relative
ordering, and is generally a dangerous practice since the resulting
priority may inadvertently belong to a different selection policy's
range.

Since RQ_PPQ is 4, differences of less than 4 are insignificant, so just
remove them.  These small differences have not been changed for years,
so it is likely they have no real meaning (besides having no practical
effect).  One can still consult the changes history to recover them if
ever needed.

No functional change (intended).

MFC after:      1 month
Event:          Kitchener-Waterloo Hackathon 202506
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D45390
bus_generic_detach: Delete children after detaching them 2025-01-02T18:21:30+00:00 John Baldwin jhb@FreeBSD.org 2025-01-02T18:21:02+00:00 b196276c20b577b364372f1aa1a646b9ce34bf5c This provides better semantics as a standalone DEVMETHOD for device_attach as bus drivers should remove child devices they created as part of detach cleanup. The implementation calls bus_detach_children() first to permit child devices an opportunity to veto the detach operation. If that succeeds, device_delete_children() is used to delete the child devices. This requires fixing various drivers that were deleting devices explicitly (via a device_t pointer cached in the softc) after calling bus_generic_detach to stop doing that and just rely on bus_generic_detach to remove child devices. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47959 
This provides better semantics as a standalone DEVMETHOD for
device_attach as bus drivers should remove child devices they created
as part of detach cleanup.  The implementation calls
bus_detach_children() first to permit child devices an opportunity to
veto the detach operation.  If that succeeds, device_delete_children()
is used to delete the child devices.

This requires fixing various drivers that were deleting devices
explicitly (via a device_t pointer cached in the softc) after calling
bus_generic_detach to stop doing that and just rely on
bus_generic_detach to remove child devices.

Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D47959
Replace calls to bus_generic_attach with bus_attach_children 2024-12-06T22:26:16+00:00 John Baldwin jhb@FreeBSD.org 2024-12-06T22:26:16+00:00 18250ec6c089c0c50cbd9fd87d78e03ff89916df Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47675 
Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D47675
Replace calls to bus_generic_probe with bus_identify_children 2024-12-06T22:26:05+00:00 John Baldwin jhb@FreeBSD.org 2024-12-06T22:26:05+00:00 723da5d92f40a413585107f8455280ea575fe410 Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47674 
Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D47674
fwip(4): Stop checking for failures from malloc(M_WAITOK) 2024-09-03T10:25:28+00:00 Zhenlei Huang zlei@FreeBSD.org 2024-09-03T10:25:28+00:00 4d47c7ca7baa1ae76cc1fc72ec85b475f1efd41d MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D45852 
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D45852
newbus: replace -1 in BUS_ADD_CHILD(...-1) with DEVICE_UNIT_ANY 2024-07-25T04:23:02+00:00 Warner Losh imp@FreeBSD.org 2024-07-25T04:23:02+00:00 a05a680469a7ac77b195021fed74e3aa58152dd7 Sponsored by: Netflix 
Sponsored by:		Netflix
net: Remove unneeded NULL check for the allocated ifnet 2024-06-28T10:16:29+00:00 Zhenlei Huang zlei@FreeBSD.org 2024-06-28T10:16:29+00:00 aa3860851b9f6a6002d135b1cac7736e0995eedc Change 4787572d0580 made if_alloc_domain() never fail, then also do the wrappers if_alloc(), if_alloc_dev(), and if_gethandle(). No functional change intended. Reviewed by: kp, imp, glebius, stevek MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D45740 
Change 4787572d0580 made if_alloc_domain() never fail, then also do the
wrappers if_alloc(), if_alloc_dev(), and if_gethandle().

No functional change intended.

Reviewed by:	kp, imp, glebius, stevek
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D45740
sys: Automated cleanup of cdefs and other formatting 2023-11-27T05:24:00+00:00 Warner Losh imp@FreeBSD.org 2023-11-24T20:12:57+00:00 fdafd315ad0d0f28a11b9fb4476a9ab059c62b92 Apply the following automated changes to try to eliminate no-longer-needed sys/cdefs.h includes as well as now-empty blank lines in a row. Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/ Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/ Remove /\n+#if.*\n#endif.*\n+/ Remove /^#if.*\n#endif.*\n/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/ Sponsored by: Netflix 
Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/

Sponsored by:		Netflix