src/sys/dev/firewire, branch upstream/11.1.0

MFC r314864: firewire/sbp: try to improve locking, plus a few style nits

2017-03-23T07:56:07+00:00

MFC r311305 (by asomers):

2017-03-23T06:40:20+00:00

Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
fixed-length strings. AFAICT the only place they're read is in
sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
uses strncpy to write them, and doesn't guarantee null-termination. For at
least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
overflows. You can see the result by doing "camcontrol negotiate da0 -v".

This change null-terminates those fields everywhere they're set in the
kernel. It also shortens a few strings to ensure they'll fit within the
16-character field.

PR:		215474
Reported by:    Coverity
CID:            1009997 1010000 1010001 1010002 1010003 1010004 1010005
CID:            1331519 1010006 1215097 1010007 1288967 1010008 1306000
CID:            1211924 1010009 1010010 1010011 1010012 1010013 1010014
CID:            1147190 1010017 1010016 1010018 1216435 1010020 1010021
CID:            1010022 1009666 1018185 1010023 1010025 1010026 1010027
CID:            1010028 1010029 1010030 1010031 1010033 1018186 1018187
CID:            1010035 1010036 1010042 1010041 1010040 1010039

MFC r314375: Remove some locking not needed for modern CAM.

2017-03-14T07:06:05+00:00

This driver is full of LORs.  This change allows to reduce deadlock chance
from 100% to level that allows some tests to be done.

MFC r313982, r314068:

2017-03-14T02:06:03+00:00

sys: Replace zero with NULL for pointers.

Found with:	devel/coccinelle

MFC r314374: Add safety check against too long CDB.

2017-03-07T05:56:48+00:00

SBP-2 specification defined maximum CDB length as 12 bytes.  Newer SBP-3
specification allows CDB of any size, but this driver is too old.  Proper
solution would be to look on maximal ORB size supported by the target.

MFC r314358: Announce that sbp_targ(4) does not support initiator mode.

2017-03-06T06:08:17+00:00

MFC r309093: firewire: initialize tag label to -1 in fw_xfer_alloc()

2016-12-14T16:43:04+00:00

MFC r309092: fwohci: report whether PhysicalUpperBound register is implemented

2016-12-14T16:30:47+00:00

Remove NULL checks after M_WAITOK allocations from firewire.

2016-05-10T10:21:03+00:00

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation

sys/dev: minor spelling fixes.

2016-05-03T03:41:25+00:00

Most affect comments, very few have user-visible effects.