src/sys/dev/iavf, branch stable/13 FreeBSD source tree Fix enum warning in iavf 2024-08-04T10:23:02+00:00 Dimitry Andric dim@FreeBSD.org 2024-07-31T11:01:20+00:00 8356d8ff63a3ffab8b1ff91c922ca7865de9dfc3 This fixes a clang 19 warning: sys/dev/iavf/iavf_lib.c:514:39: error: comparison of different enumeration types ('enum virtchnl_vsi_type' and 'enum iavf_vsi_type') [-Werror,-Wenum-compare] 514 | if (sc->vf_res->vsi_res[i].vsi_type == IAVF_VSI_SRIOV) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ The `vsi_type` field of `struct virtchnl_vsi_resource` is of type `enum virtchnl_vsi_type`, not `enum iavf_vsi_type`. In this case, we can seamlessly replace the value with `VIRTCHNL_VSI_SRIOV`, which is numerically equal to `IAVF_VSI_SRIOV`. MFC after: 3 days (cherry picked from commit 67be1e195acfaec99ce4fffeb17111ce085755f7) 
This fixes a clang 19 warning:

    sys/dev/iavf/iavf_lib.c:514:39: error: comparison of different enumeration types ('enum virtchnl_vsi_type' and 'enum iavf_vsi_type') [-Werror,-Wenum-compare]
      514 |                 if (sc->vf_res->vsi_res[i].vsi_type == IAVF_VSI_SRIOV)
          |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~

The `vsi_type` field of `struct virtchnl_vsi_resource` is of type `enum
virtchnl_vsi_type`, not `enum iavf_vsi_type`. In this case, we can
seamlessly replace the value with `VIRTCHNL_VSI_SRIOV`, which is
numerically equal to `IAVF_VSI_SRIOV`.

MFC after:	3 days

(cherry picked from commit 67be1e195acfaec99ce4fffeb17111ce085755f7)
iflib drivers: Constify PCI ID LUTs 2024-01-05T22:48:03+00:00 Marius Strobl marius@FreeBSD.org 2023-08-16T16:49:34+00:00 5153206df0f29d682cdcad97b67d182b00204ccd Since d49e83eac3baf16a22b1c5d42e8438b68b17e6f9, iflib(9) is ready for this change. While at it, make isc_driver_version strings (static) const where not apparently un-const on purpose, too. This reduces the size of the amd64 GENERIC by about 10 KiB. (cherry picked from commit 51e235148a4becba94e824a44bd69687644a7f56) Conflicts (drivers missing in stable/13): sys/dev/enetc/if_enetc.c sys/dev/enic/if_enic.c 
Since d49e83eac3baf16a22b1c5d42e8438b68b17e6f9, iflib(9) is ready
for this change.
While at it, make isc_driver_version strings (static) const where
not apparently un-const on purpose, too.
This reduces the size of the amd64 GENERIC by about 10 KiB.

(cherry picked from commit 51e235148a4becba94e824a44bd69687644a7f56)

Conflicts (drivers missing in stable/13):
	sys/dev/enetc/if_enetc.c
	sys/dev/enic/if_enic.c
iavf: Add explicit ifdi_needs_reset for VLAN changes 2023-09-11T22:34:20+00:00 Kevin Bowling kbowling@FreeBSD.org 2023-08-24T20:36:00+00:00 08647a110843ab7f4b09917413ed9cb1c3d4a7ca In rS360398, a new iflib device method was added with default of opt out for VLAN events needing an interface reset. iavf(4) was the original need for this, because VLAN filter changes currently have negative interactions with Malicious Driver Detection. Add iavf_if_needs_restart and explicitly enable VLAN re-init. Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558 (cherry picked from commit 1d6c12c511ae2a394d3ca1998a10f3d3bd25d313) 
In rS360398, a new iflib device method was added with default of opt out
for VLAN events needing an interface reset.

iavf(4) was the original need for this, because VLAN filter changes
currently have negative interactions with Malicious Driver Detection.

Add iavf_if_needs_restart and explicitly enable VLAN re-init.

Sponsored by:	BBOX.io
Differential Revision:	https://reviews.freebsd.org/D41558

(cherry picked from commit 1d6c12c511ae2a394d3ca1998a10f3d3bd25d313)
sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-23T17:43:22+00:00 Warner Losh imp@FreeBSD.org 2023-08-22T01:31:15+00:00 4fbf14e22d7b83de7080a8e491ba14a5785a0ff4 Remove /^/[*/]\s*\$FreeBSD\$.*\n/ Similar commit in current: (cherry picked from commit 71625ec9ad2a) 
Remove /^/[*/]\s*\$FreeBSD\$.*\n/

Similar commit in current:
(cherry picked from commit 71625ec9ad2a)
iavf(4): Include RSS header file when RSS is defined 2022-03-08T00:00:31+00:00 Eric Joyner erj@FreeBSD.org 2021-12-03T20:02:42+00:00 fe95a05a07aedf352b1877c9a562de23a2b81f8e This should unbreak the kernel build when "options RSS" is defined in the kernel configuration, and make the feature work. Signed-off-by: Eric Joyner <erj@FreeBSD.org> Reported by: adrian@ Sponsored by: Intel Corporation (cherry picked from commit 5577aa338a675f2a465a58356894fbe24ba20407) 
This should unbreak the kernel build when "options RSS" is
defined in the kernel configuration, and make the feature work.

Signed-off-by: Eric Joyner <erj@FreeBSD.org>

Reported by:	adrian@
Sponsored by:	Intel Corporation

(cherry picked from commit 5577aa338a675f2a465a58356894fbe24ba20407)
iavf(4): Split source and update to 3.0.26-k 2022-03-08T00:00:08+00:00 Eric Joyner erj@FreeBSD.org 2021-02-12T21:28:18+00:00 41423f3a62e3f21f15afec6a0046c95c91c45b60 The iavf(4) driver now uses a different source base from ixl(4), since it will be the standard VF driver for new Intel Ethernet products going forward, including ice(4). It continues to use the iflib framework for network drivers. Since it now uses a different source code base, this commit adds a new sys/dev/iavf entry, but it re-uses the existing module name so no configuration changes are necessary. Signed-off-by: Eric Joyner <erj@FreeBSD.org> Reviewed by: kbowling@ Tested by: lukasz.szczepaniak@intel.com Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D28636 (cherry picked from commit ca853dee3b8f26f53d48d685f32ec0b8396369e8) 
The iavf(4) driver now uses a different source base from ixl(4), since
it will be the standard VF driver for new Intel Ethernet products going
forward, including ice(4). It continues to use the iflib framework
for network drivers.

Since it now uses a different source code base, this commit adds a new
sys/dev/iavf entry, but it re-uses the existing module name so no
configuration changes are necessary.

Signed-off-by: Eric Joyner <erj@FreeBSD.org>

Reviewed by:		kbowling@
Tested by:		lukasz.szczepaniak@intel.com
Sponsored by:		Intel Corporation
Differential Revision:	https://reviews.freebsd.org/D28636

(cherry picked from commit ca853dee3b8f26f53d48d685f32ec0b8396369e8)