src/sys/dev/ichiic, branch stable/13 FreeBSD source tree ig4: Actively use FIFO thresholds 2024-01-19T17:04:38+00:00 Alexander Motin mav@FreeBSD.org 2023-12-24T23:18:11+00:00 8d8f348c8fe782c7de4b326e6bc80d36ba7bfba7 Before every wait for FIFO interrupt set how much data/space do we want to see there. Previous code was not using it for receive, as result aggregating interrupts only within processing latency. The new code needs only one interrupt per transfer per FIFO length. On my Dell XPS 13 9310 with iichid(4) touchscreen and touchpad this reduces the interrupt rate per device down to 2 per sample or 16-20 per second when idle and 120-160 per second when actively touched. MFC after: 1 month (cherry picked from commit 13037eaabede7fb7fbc25f4e84b549c73f9acb3c) 
Before every wait for FIFO interrupt set how much data/space do we
want to see there.  Previous code was not using it for receive, as
result aggregating interrupts only within processing latency.  The
new code needs only one interrupt per transfer per FIFO length.

On my Dell XPS 13 9310 with iichid(4) touchscreen and touchpad this
reduces the interrupt rate per device down to 2 per sample or 16-20
per second when idle and 120-160 per second when actively touched.

MFC after:	1 month

(cherry picked from commit 13037eaabede7fb7fbc25f4e84b549c73f9acb3c)
ig4: Fix FIFO depths detection 2024-01-19T17:04:38+00:00 Alexander Motin mav@FreeBSD.org 2023-12-24T00:02:49+00:00 396e8e987adfca485b8b16fd7eee4e368ec1a288 At least on my Tiger Lake-LP queue depth detection failed before the ig4iic_set_config() call, resulting in no FIFO use. Moving it after solves the problem, getting proper 64 bytes size. On my Dell XPS 13 9310 with iichid(4) touchscreen and touchpad this by few times reduces context switch rate in the driver, and probably also improves the I2C bus utilization. MFC after: 1 month (cherry picked from commit 9c9d7fdd9f0041783955c5f540ac55a900877c0c) 
At least on my Tiger Lake-LP queue depth detection failed before the
ig4iic_set_config() call, resulting in no FIFO use.  Moving it after
solves the problem, getting proper 64 bytes size.

On my Dell XPS 13 9310 with iichid(4) touchscreen and touchpad this
by few times reduces context switch rate in the driver, and probably
also improves the I2C bus utilization.

MFC after:	1 month

(cherry picked from commit 9c9d7fdd9f0041783955c5f540ac55a900877c0c)
ig4: Add PCI IDs for Intel Ice Lake I2C controller. 2023-12-19T20:53:48+00:00 Vladimir Kondratyev wulf@FreeBSD.org 2023-11-27T15:25:48+00:00 2cbd132986a782f689e169f4bf47793e1fc8a147 PR: 275115 Tested by: Sam <sam3423.yntmr_AT_slmail_DOT_me> (cherry picked from commit 789ffce392946d2f71a51bbac60db16dcdea2928) 
PR:		275115
Tested by:	Sam <sam3423.yntmr_AT_slmail_DOT_me>

(cherry picked from commit 789ffce392946d2f71a51bbac60db16dcdea2928)
sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23T17:43:25+00:00 Warner Losh imp@FreeBSD.org 2023-08-22T01:31:27+00:00 3bc80996974a61a4223eae4c1ccd47b6ee32a48a Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ Similar commit in current: (cherry picked from commit 685dc743dc3b) 
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

Similar commit in current:
(cherry picked from commit 685dc743dc3b)
sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23T17:43:20+00:00 Warner Losh imp@FreeBSD.org 2023-08-22T01:31:02+00:00 f8167e0404dab9ffeaca95853dd237ab7c587f82 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ Similar commit in current: (cherry picked from commit 95ee2897e98f) 
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

Similar commit in current:
(cherry picked from commit 95ee2897e98f)
ichiic: use bool for one-bit wide bit-fields 2023-04-22T08:59:44+00:00 Dimitry Andric dim@FreeBSD.org 2023-04-18T18:08:28+00:00 9f9b65a0933a9b6fdde611210b29bd670c932a44 A one-bit wide bit-field can take only the values 0 and -1. Clang 16 introduced a warning that "implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1". Fix by using c99 bool. Reported by: Clang Reviewed by: emaste, wulf MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D39665 (cherry picked from commit 87f55ab0b46ad72efee11d1b64ec8f839bb013da) 
A one-bit wide bit-field can take only the values 0 and -1. Clang 16
introduced a warning that "implicit truncation from 'int' to a one-bit
wide bit-field changes value from 1 to -1". Fix by using c99 bool.

Reported by:	Clang
Reviewed by:	emaste, wulf
MFC after:	3 days
Differential Revision: https://reviews.freebsd.org/D39665

(cherry picked from commit 87f55ab0b46ad72efee11d1b64ec8f839bb013da)
ig4(4): Add device HID to match I2C controller on ASUS X540 laptops 2022-12-24T08:33:27+00:00 Vladimir Kondratyev wulf@FreeBSD.org 2022-07-21T23:19:15+00:00 6badae01a1e8b1f6892ace999b64e86d6feb0b5c (cherry picked from commit 8f733dabcc359b04c32874a4cd4289dbc3f8c0f6) 
(cherry picked from commit 8f733dabcc359b04c32874a4cd4289dbc3f8c0f6)
ig4(4): Add PNP info for ACPI attachment 2022-12-24T08:33:20+00:00 Vladimir Kondratyev wulf@FreeBSD.org 2022-03-02T23:35:23+00:00 00c728ac9dcdeb585f21da81f244bc8f59442cf8 (cherry picked from commit 166f2cb40d55e0e0900170e7cac8a1603a18d34d) 
(cherry picked from commit 166f2cb40d55e0e0900170e7cac8a1603a18d34d)
ig4: Add PCI IDs for Intel Alder Lake I2C controller. 2021-12-09T01:37:28+00:00 Alexander Motin mav@FreeBSD.org 2021-11-25T01:13:38+00:00 f8aedfec5d5b59947ca427002c4ed8920dfbf32b Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com> MFC after: 2 weeks (cherry picked from commit e8e8d2290ee68ddf8753ea345d4424f959bdb69d) 
Submitted by:	Dmitry Luhtionov <dmitryluhtionov@gmail.com>
MFC after:	2 weeks

(cherry picked from commit e8e8d2290ee68ddf8753ea345d4424f959bdb69d)
ig4: Add PCI IDs for Intel Gemini Lake I2C controller. 2021-04-11T21:48:08+00:00 Vladimir Kondratyev wulf@FreeBSD.org 2021-02-23T22:20:36+00:00 09d2a7a67b54eccccdc9ec97bbb7c918f0166ab8 Submitted by: Dmitry Luhtionov MFC after: 2 weeks (cherry picked from commit bbacb7ce72956a41c0daeefe875e5209d87c11ba) 
Submitted by:	Dmitry Luhtionov
MFC after:	2 weeks

(cherry picked from commit bbacb7ce72956a41c0daeefe875e5209d87c11ba)