<feed xmlns='http://www.w3.org/2005/Atom'>
<title>src/sys/dev/ichsmb, branch releng/14.2</title>
<subtitle>FreeBSD source tree</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/'/>
<entry>
<title>Add smbus and i2c device IDs for Meteor Lake</title>
<updated>2024-10-17T16:32:38+00:00</updated>
<author>
<name>SHENG-YI HONG</name>
<email>aokblast@FreeBSD.org</email>
</author>
<published>2024-08-13T12:22:43+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=14c22e28e4ee62f4d3f2d6004881d874fafa7d11'/>
<id>14c22e28e4ee62f4d3f2d6004881d874fafa7d11</id>
<content type='text'>
Reviewed by:	emaste, Daniel Schaefer &lt;dhs@frame.work&gt;
MFC after:	3 days
Sponsored by:	Framework Computer Inc
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D46249

(cherry picked from commit d3b05d0ea10abe059dc63c6fb6ef3f061b758af2)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reviewed by:	emaste, Daniel Schaefer &lt;dhs@frame.work&gt;
MFC after:	3 days
Sponsored by:	Framework Computer Inc
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D46249

(cherry picked from commit d3b05d0ea10abe059dc63c6fb6ef3f061b758af2)
</pre>
</div>
</content>
</entry>
<entry>
<title>ichsmb: fix block read operation</title>
<updated>2024-02-17T14:15:11+00:00</updated>
<author>
<name>Andriy Gapon</name>
<email>avg@FreeBSD.org</email>
</author>
<published>2022-09-13T21:26:35+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=a9bab712eb10de15d28ada67e369e75dcbd09d9e'/>
<id>a9bab712eb10de15d28ada67e369e75dcbd09d9e</id>
<content type='text'>
First of all and unlike I2C, it's not the master that dictates how many
bytes to read in block read operation.  It's the device that informs the
master how many bytes it's sending back.

Thus, for ichsmb_bread() the count parameter is purely an output
parameter.  The code has been changed to reflect that.
The sanity checking of the response length is now done once it (the
first byte of the response) is received.

While here, handling of ICH_HST_STA_FAILED status bit has been added.
Plus some code style improvements and some new code comments in the
vicinity of the changed code.

(cherry picked from commit cbf7c81b608bb9311e50df9481447dc843083a0e)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
First of all and unlike I2C, it's not the master that dictates how many
bytes to read in block read operation.  It's the device that informs the
master how many bytes it's sending back.

Thus, for ichsmb_bread() the count parameter is purely an output
parameter.  The code has been changed to reflect that.
The sanity checking of the response length is now done once it (the
first byte of the response) is received.

While here, handling of ICH_HST_STA_FAILED status bit has been added.
Plus some code style improvements and some new code comments in the
vicinity of the changed code.

(cherry picked from commit cbf7c81b608bb9311e50df9481447dc843083a0e)
</pre>
</div>
</content>
</entry>
<entry>
<title>sys: Remove $FreeBSD$: one-line .c pattern</title>
<updated>2023-08-16T17:54:36+00:00</updated>
<author>
<name>Warner Losh</name>
<email>imp@FreeBSD.org</email>
</author>
<published>2023-08-16T17:54:36+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=685dc743dc3b5645e34836464128e1c0558b404b'/>
<id>685dc743dc3b5645e34836464128e1c0558b404b</id>
<content type='text'>
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
</pre>
</div>
</content>
</entry>
<entry>
<title>sys: Remove $FreeBSD$: two-line .h pattern</title>
<updated>2023-08-16T17:54:11+00:00</updated>
<author>
<name>Warner Losh</name>
<email>imp@FreeBSD.org</email>
</author>
<published>2023-08-16T17:54:11+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=95ee2897e98f5d444f26ed2334cc7c439f9c16c6'/>
<id>95ee2897e98f5d444f26ed2334cc7c439f9c16c6</id>
<content type='text'>
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
</pre>
</div>
</content>
</entry>
<entry>
<title>sys/dev/ichsmb: Silence unhandled SMBALERT device_printfs</title>
<updated>2023-06-26T08:29:34+00:00</updated>
<author>
<name>Reid Linnemann</name>
<email>rlinnemann@netgate.com</email>
</author>
<published>2023-06-26T08:25:26+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=f0c97033018b0741aa832bf1b79430ed73ceb0da'/>
<id>f0c97033018b0741aa832bf1b79430ed73ceb0da</id>
<content type='text'>
The ichsmb driver does not actually handle SMBALERT, other than by logging the
first 16 occurences of the ICH_HST_STA_SMBALERT_STS_SMBALERT status
flag. Because the SMBALERT is not acknowledged by the host, clearing it in the
host status register does not appear to work as long as some slave device is
pulling the SMBALERT line low, at least for C2000 chips. As a result, if a slave
device does pull SMBALERT low the interrupt handler will always loop its maximum
of 16 times attempting to clear all status register flags and device_printf the
status register. The result is the kernel message buffer is littered with these
device_printfs at every interrupt.

To remedy the problem, the ICH_HST_STA_SMBALERT_STS flag is zeroed in the read
host status register value, just as with ICH_HST_STA_INUSE_STS and
ICH_HST_STA_HOST_BUSY. This allows the loop to break when no other flags that
must be handled are set in the host status register. Additionally, because the
SMBALERT is not actually handled the SMBALERT logging is omitted as it has no
actual function at this time.

Reviewed by:	imp
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D39966
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The ichsmb driver does not actually handle SMBALERT, other than by logging the
first 16 occurences of the ICH_HST_STA_SMBALERT_STS_SMBALERT status
flag. Because the SMBALERT is not acknowledged by the host, clearing it in the
host status register does not appear to work as long as some slave device is
pulling the SMBALERT line low, at least for C2000 chips. As a result, if a slave
device does pull SMBALERT low the interrupt handler will always loop its maximum
of 16 times attempting to clear all status register flags and device_printf the
status register. The result is the kernel message buffer is littered with these
device_printfs at every interrupt.

To remedy the problem, the ICH_HST_STA_SMBALERT_STS flag is zeroed in the read
host status register value, just as with ICH_HST_STA_INUSE_STS and
ICH_HST_STA_HOST_BUSY. This allows the loop to break when no other flags that
must be handled are set in the host status register. Additionally, because the
SMBALERT is not actually handled the SMBALERT logging is omitted as it has no
actual function at this time.

Reviewed by:	imp
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D39966
</pre>
</div>
</content>
</entry>
<entry>
<title>ichsmb/imcsmb/intpm/ismt: Remove unused devclass arguments to DRIVER_MODULE.</title>
<updated>2022-05-09T19:22:02+00:00</updated>
<author>
<name>John Baldwin</name>
<email>jhb@FreeBSD.org</email>
</author>
<published>2022-05-09T19:22:02+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=dfee3204c98718efbdadb2439fd95ba312920ece'/>
<id>dfee3204c98718efbdadb2439fd95ba312920ece</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused smbus_devclass.</title>
<updated>2022-05-06T22:39:30+00:00</updated>
<author>
<name>John Baldwin</name>
<email>jhb@FreeBSD.org</email>
</author>
<published>2022-04-20T16:26:33+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=c6d3976514d1650c96d7468ad83eacbd756b1a98'/>
<id>c6d3976514d1650c96d7468ad83eacbd756b1a98</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove check for __CC_SUPPORTS___FUNC__.</title>
<updated>2022-04-12T17:06:04+00:00</updated>
<author>
<name>John Baldwin</name>
<email>jhb@FreeBSD.org</email>
</author>
<published>2022-04-12T17:06:04+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=87445068f96dffeb4e7f733eb155bb7caf47b5c2'/>
<id>87445068f96dffeb4e7f733eb155bb7caf47b5c2</id>
<content type='text'>
__func__ is part of C99.

PR:		263102 (exp-run)
Reviewed by:	brooks, imp, emaste
Differential Revision:	https://reviews.freebsd.org/D34801
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
__func__ is part of C99.

PR:		263102 (exp-run)
Reviewed by:	brooks, imp, emaste
Differential Revision:	https://reviews.freebsd.org/D34801
</pre>
</div>
</content>
</entry>
<entry>
<title>ichsmb: Add PCI IDs for Intel Alder Lake SMBus controller</title>
<updated>2021-11-24T18:07:58+00:00</updated>
<author>
<name>Alexander Motin</name>
<email>mav@FreeBSD.org</email>
</author>
<published>2021-11-24T18:06:52+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=f29f6b2e1fc93ea68171f6c974ffe654232d09ca'/>
<id>f29f6b2e1fc93ea68171f6c974ffe654232d09ca</id>
<content type='text'>
Submitted by:	Dmitry Luhtionov &lt;dmitryluhtionov@gmail.com&gt;
MFC after:	2 weeks
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Submitted by:	Dmitry Luhtionov &lt;dmitryluhtionov@gmail.com&gt;
MFC after:	2 weeks
</pre>
</div>
</content>
</entry>
<entry>
<title>ichsmb: Add PCI ID for Intel Gemini Lake SMBus controller</title>
<updated>2021-04-14T00:58:07+00:00</updated>
<author>
<name>Vladimir Kondratyev</name>
<email>wulf@FreeBSD.org</email>
</author>
<published>2021-04-13T22:10:13+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=fb451895fba7dee139594c722adb5f79af154341'/>
<id>fb451895fba7dee139594c722adb5f79af154341</id>
<content type='text'>
Submitted by:	Dmitry Luhtionov &lt;dmitryluhtionov@gmail.com&gt;
MFC after:	2 weeks
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Submitted by:	Dmitry Luhtionov &lt;dmitryluhtionov@gmail.com&gt;
MFC after:	2 weeks
</pre>
</div>
</content>
</entry>
</feed>
