src/sys/dev/mps, branch main

cam/scsi: Restore scsi_start_stop() and add scsi_start_stop_pc()

2026-01-26T06:35:31+00:00

Revert the argument change that broke libcam in 8c35de49 and move
power_condition support to scsi_start_stop_pc().

Reported by:		imp
Reviewed By:		#cam, imp (mentor)
Sponsored by:           Samsung Electronics
Differential Revision:	https://reviews.freebsd.org/D54822

mps: Add a probe on completion

2026-01-09T05:55:32+00:00

cam::mps:complete(union ccb *, struct mps_command *, u_int, u32);
    Where u_int is scsas->flags u32 is the device_info.

This can't be done as an fbt because the data needed for it isn't
present out a function boundary.

Sponsored by:		Netflix

mps/mpr: Remove bogus sys/cdefs.h includes

2026-01-09T05:54:44+00:00

These are left over from the $FreeBSD$ stuff.

Sponsored by:		Netflix

mps(4): Fix a typo in a device message

2025-12-13T09:53:21+00:00

- s/reseting/resetting/

MFC after:	5 days

cam/scsi: Add power condition support to START STOP UNIT

2025-12-01T04:40:52+00:00

This patch adds a power_condition parameter to the
scsi_start_stop() function and sets the power condition via SSU.

Reviewed by:		imp (mentor)
Sponsored by:           Samsung Electronic
Differential Revision:	https://reviews.freebsd.org/D53922

style(9): white space after ; and around binary operators

2025-10-16T22:02:50+00:00

in for() loops.  Also, use 'while', where only the
conditional test of 'for' was used.

Reviewed by: sjg

machine/stdarg.h -> sys/stdarg.h

2025-06-11T16:39:02+00:00

Switch to using sys/stdarg.h for va_list type and va_* builtins.

Make an attempt to insert the include in a sensible place.  Where
style(9) was followed this is easy, where it was ignored, aim for the
first block of sys/*.h headers and don't get too fussy or try to fix
other style bugs.

Reviewed by:	imp
Exp-run by:	antoine (PR 286274)
Pull Request:	https://github.com/freebsd/freebsd-src/pull/1595

mps/mpr: Add workaround for firmware not responding to IOC_FACTS or IOC_INIT

2024-10-13T21:38:01+00:00

Sometimes, especially with older firmware, mps(4) would have trouble
initializing the card in one of these two steps. Add in a retry after a
short delay. Sean Bruno and Stephen McConnell thought this was OK in the
bug discussions, but never committed it.  Steve indicated the delay
might not be necessary, but the OP clearly needed to make it longer to
make things work. I've kept the delay, and added the suggested comment.

Ported the iocfacts part to mpr as well, since we see similar errors
about once every month or two over a few thousand controllers at
work. We've not seen it with IOC_INIT as far back as I can query the
error log database, so I didn't port that forward. We'll see if this
helps, but won't know for sure until next year (so I'm committing it now
since it won't hurt and might help). We usually see this failure in
connection with complicated recovery operations with a drive that's
failing, though, at least in the last year's worth of failures. It's
not clear this is the same as OP or not.

PR: 212841
Sponsored by: Netflix
Co-authored-by: imp

Revert "nvme: Separate total failures from I/O failures"

2024-08-16T03:29:53+00:00

All kinds of crazy stuff was mixed into this commit. Revert
it and do it again.

This reverts commit d5507f9e436698ac17dc5ace7ef58493988a9b04.

Sponsored by:		Netflix

nvme: Separate total failures from I/O failures

2024-08-16T02:22:18+00:00

When it's a I/O failure, we can still send admin commands. Separate out
the admin failures and flag them as such so that we can still send admin
commands on half-failed drives.

Fixes: 9229b3105d88 (nvme: Fail passthrough commands right away in failed state)
Sponsored by: Netflix