src/sys/dev/mrsas, branch releng/13.4 FreeBSD source tree mrsas: Fix callout locking in mrsas_complete_cmd() 2023-10-14T15:28:48+00:00 Mark Johnston markj@FreeBSD.org 2023-10-07T00:31:03+00:00 1b934004c04c64e96ed08b1a0c560225def21d94 callout_stop() requires the associated lock to be held. This is a bit hacky, but I believe it's safe since the subsequent mrsas_cmd_done() call will also acquire the SIM lock to stop a different callout. PR: 265484 Reviewed by: imp Tested by: Jérémie Jourdin <jeremie.jourdin@advens.fr> MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D39559 (cherry picked from commit 4640df1b0a49697840b81f6bcd269a483514c6aa) 
callout_stop() requires the associated lock to be held.

This is a bit hacky, but I believe it's safe since the subsequent
mrsas_cmd_done() call will also acquire the SIM lock to stop a different
callout.

PR:		265484
Reviewed by:	imp
Tested by:	Jérémie Jourdin <jeremie.jourdin@advens.fr>
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D39559

(cherry picked from commit 4640df1b0a49697840b81f6bcd269a483514c6aa)
sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23T17:43:25+00:00 Warner Losh imp@FreeBSD.org 2023-08-22T01:31:27+00:00 3bc80996974a61a4223eae4c1ccd47b6ee32a48a Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ Similar commit in current: (cherry picked from commit 685dc743dc3b) 
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

Similar commit in current:
(cherry picked from commit 685dc743dc3b)
mrsas: Fix a typo in a source code comment 2023-05-17T09:57:08+00:00 Zhenlei Huang zlei@FreeBSD.org 2023-04-28T10:01:58+00:00 62af5091a4f757b2c356a1dbf8edf40548b0a724 - s/feild/field/ MFC after: 3 days (cherry picked from commit bbfb244724e25933d7c7cf68b943e0c2a7d6e381) 
- s/feild/field/

MFC after:	3 days

(cherry picked from commit bbfb244724e25933d7c7cf68b943e0c2a7d6e381)
mrsas: Don't leak a stack pointer value in the softc. 2023-05-03T00:12:37+00:00 John Baldwin jhb@FreeBSD.org 2022-12-21T18:45:26+00:00 256b5d40e5502323dddffd5a8db2ab431e9eea61 mrsas_issue_blocked_cmd stores a pointer to an on-stack variable in its softc so that the driver can call wakeup() on the correct pointer. Once the loop around tsleep() has finished however, the pointer is no longer needed and any further use would be invalid. Clear sc->chan to NULL after the loop. Reported by: GCC -Wdangling-pointer Differential Revision: https://reviews.freebsd.org/D37628 (cherry picked from commit 9f0c0e6eede6aedb60e12888fc9751c40b364dc9) 
mrsas_issue_blocked_cmd stores a pointer to an on-stack variable
in its softc so that the driver can call wakeup() on the correct
pointer.  Once the loop around tsleep() has finished however, the
pointer is no longer needed and any further use would be invalid.
Clear sc->chan to NULL after the loop.

Reported by:	GCC -Wdangling-pointer
Differential Revision:	https://reviews.freebsd.org/D37628

(cherry picked from commit 9f0c0e6eede6aedb60e12888fc9751c40b364dc9)
mrsas(4): Fix a typo in a source code comment 2023-01-14T09:30:35+00:00 Gordon Bergling gbe@FreeBSD.org 2023-01-11T09:48:14+00:00 5c7e6e56d9cb4fa14a4cd350aeb1e085db92911b - s/reqest/request/ (cherry picked from commit e018483b10e7cf2cd852406648ccaf1f159ecb8d) 
- s/reqest/request/

(cherry picked from commit e018483b10e7cf2cd852406648ccaf1f159ecb8d)
mrsas(4): Fix a typo in a source code comment 2022-04-09T06:16:50+00:00 Gordon Bergling gbe@FreeBSD.org 2022-04-02T11:59:11+00:00 be03f2f9d94b16d625ad09a196bd049ff813f0f2 - s/alloction/allocation/ (cherry picked from commit 32c601b6cfbcd6d99722faaacb8d246cd27116bd) 
- s/alloction/allocation/

(cherry picked from commit 32c601b6cfbcd6d99722faaacb8d246cd27116bd)
mrsas: if controller reset is in progress, refrain from firing DCMDs to 2022-04-06T16:27:25+00:00 Chandrakanth Patil chandrakanth.patil@broadcom.com 2022-01-21T09:24:37+00:00 09e161a29ee5b0e52494c861f451de35b286e327 firmware in shutdown If controller reset is in progress, at same time if system shutdown is issued then corresponding shutdown function in driver will be invoked where driver is waiting 15 seconds to complete the controller reset. If the reset is not complteted within that time frame driver will go ahead and fire cache flush and shutdown DCMDs which will end up accessing the the queues which are not initialized due to undergoing reset leads to FMU error in firmware. Fix: In shutdown function, if controller reset is not finished within 15 seconds than driver will return to the OS without firing any DCMDs. Reviewed by: imp PR: 261375 (cherry picked from commit 79c4c4be9618470711480f46ef2cd3a15c00cdd2) 
firmware in shutdown

If controller reset is in progress, at same time if system shutdown is
issued then corresponding shutdown function in driver will be invoked
where driver is waiting 15 seconds to complete the controller reset.

If the reset is not complteted within that time frame driver will go
ahead and fire cache flush and shutdown DCMDs which will end up
accessing the the queues which are not initialized due to undergoing
reset leads to FMU error in firmware.

Fix:
In shutdown function, if controller reset is not finished within 15
seconds than driver will return to the OS without firing any DCMDs.

Reviewed by: imp
PR: 261375

(cherry picked from commit 79c4c4be9618470711480f46ef2cd3a15c00cdd2)
mrsas: remove additional MPT command allocation for R1 FP command 2022-04-06T16:27:25+00:00 Chandrakanth Patil chandrakanth.patil@broadcom.com 2022-01-21T12:11:49+00:00 2ebe51859723fd3cb4cf02dc560441fc0ec50dc1 There is an additional MPT command allocation for R1 fp command which will lead to MPT command unavailablity in case of rigorous R1 FP IOs. Remove additional MPT command allocation for R1 FP. Reviewed by: imp PR: 261377 (cherry picked from commit 241bb95552a39d440519162b544c776adcb7cf57) 
There is an additional MPT command allocation for R1 fp command which
will lead to MPT command unavailablity in case of rigorous R1 FP IOs.

Remove additional MPT command allocation for R1 FP.

Reviewed by: imp
PR: 261377

(cherry picked from commit 241bb95552a39d440519162b544c776adcb7cf57)
mrsas(4): Report more correct maximum I/O size. 2021-08-02T15:56:10+00:00 Alexander Motin mav@FreeBSD.org 2021-07-01T19:28:55+00:00 156b889469d2f59743f1811f731040dfdc3e5e14 Subtract one SGE for the case of misaligned address. Also take into account maximum number of sectors reported by firmware, that gives nicer 256KB limit instead of 276KB calculated from the SGE limit. While there, remove number of I/O size checks, duplicating what is already checked by CAM and busdma(9). MFC after: 1 month Sponsored by: iXsystems, Inc. (cherry picked from commit fa3d57c256104649217b5022947de9c1c59a326e) 
Subtract one SGE for the case of misaligned address.  Also take into
account maximum number of sectors reported by firmware, that gives
nicer 256KB limit instead of 276KB calculated from the SGE limit.

While there, remove number of I/O size checks, duplicating what is
already checked by CAM and busdma(9).

MFC after:	1 month
Sponsored by:	iXsystems, Inc.

(cherry picked from commit fa3d57c256104649217b5022947de9c1c59a326e)
mrsas: unbreak i386 build 2021-02-05T19:50:21+00:00 Alfredo Dal'Ava Junior alfredo@FreeBSD.org 2021-02-05T18:43:48+00:00 6bf9668d9d02bdf3e0dafc4ba1010ef6a9b12247 Fix build regression introduced by e34a057ca6ebdf8e30ec8b0dc21d18eb450bf36a Reviewed by: jhibbits Sponsored by: Eldorado Research Institute (eldorado.org.br) Differential Revision: https://reviews.freebsd.org/D28494 (cherry picked from commit 59fffbcf46ba6369420e655ff9173571410c643d) 
Fix build regression introduced by
e34a057ca6ebdf8e30ec8b0dc21d18eb450bf36a

Reviewed by:	jhibbits
Sponsored by:	Eldorado Research Institute (eldorado.org.br)
Differential Revision:	https://reviews.freebsd.org/D28494

(cherry picked from commit 59fffbcf46ba6369420e655ff9173571410c643d)