src/sys/dev/netmap, branch releng/14.3 FreeBSD source tree kern: Make fileops and filterops tables const where possible 2024-12-03T01:03:42+00:00 Mark Johnston markj@FreeBSD.org 2024-11-25T22:39:31+00:00 48155c983c4ba7158e738bd1d4b3144751bd1d86 No functional change intended. MFC after: 1 week (cherry picked from commit ef9ffb8594eee294334ced627755bf5b46b48f9f) 
No functional change intended.

MFC after:	1 week

(cherry picked from commit ef9ffb8594eee294334ced627755bf5b46b48f9f)
netmap: Make memory pools NUMA-aware 2024-10-28T16:39:50+00:00 Mark Johnston markj@FreeBSD.org 2024-10-14T13:30:09+00:00 9f984fc683d7a8df452411ba6f25b838d6a7ea81 Each netmap adapter associated with a physical adapter is attached to a netmap memory pool. contigmalloc() is used to allocate physically contiguous memory for the pool, but ideally we would ensure that all such memory is allocated from the NUMA domain local to the adapter. Augment netmap's memory pools with a NUMA domain ID, similar to how IOMMU groups are handled in the Linux port. That is, when attaching to a physical adapter, ensure that the associated memory pools are local to the adapter's associated memory domain, creating new pools as needed. Some types of ifnets do not have any defined NUMA affinity; in this case the domain ID in question is the sentinel value -1. Add a sysctl, dev.netmap.port_numa_affinity, which can be used to enable the new behaviour. Keep it disabled by now to avoid surprises in case netmap applications are relying on zero-copy optimizations to forward packets between ports belonging to different NUMA domains. Reviewed by: vmaffione MFC after: 2 weeks Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D46666 (cherry picked from commit 1bae9dc584272dd75dc4e04cb5d73be0e9fb562a) 
Each netmap adapter associated with a physical adapter is attached to a
netmap memory pool.  contigmalloc() is used to allocate physically
contiguous memory for the pool, but ideally we would ensure that all
such memory is allocated from the NUMA domain local to the adapter.

Augment netmap's memory pools with a NUMA domain ID, similar to how
IOMMU groups are handled in the Linux port.  That is, when attaching to
a physical adapter, ensure that the associated memory pools are local to
the adapter's associated memory domain, creating new pools as needed.

Some types of ifnets do not have any defined NUMA affinity; in this case
the domain ID in question is the sentinel value -1.

Add a sysctl, dev.netmap.port_numa_affinity, which can be used to enable
the new behaviour.  Keep it disabled by now to avoid surprises in case
netmap applications are relying on zero-copy optimizations to forward
packets between ports belonging to different NUMA domains.

Reviewed by:	vmaffione
MFC after:	2 weeks
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D46666

(cherry picked from commit 1bae9dc584272dd75dc4e04cb5d73be0e9fb562a)
netmap: Make the memory ops function pointer table const 2024-10-04T15:56:42+00:00 Mark Johnston markj@FreeBSD.org 2024-09-19T09:56:30+00:00 893caa2ab166b8d6428483172bcd61156407652f No functional change intended. Reviewed by: vmaffione MFC after: 2 weeks Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D46664 (cherry picked from commit 1ae4951ba7bb203d9a29892792960f0869759d35) 
No functional change intended.

Reviewed by:	vmaffione
MFC after:	2 weeks
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D46664

(cherry picked from commit 1ae4951ba7bb203d9a29892792960f0869759d35)
net: Remove unneeded NULL check for the allocated ifnet 2024-07-12T12:03:37+00:00 Zhenlei Huang zlei@FreeBSD.org 2024-06-28T10:16:29+00:00 6b1f530935c5f84ec65dad87b7c20c6b7a72a6d3 Change 4787572d0580 made if_alloc_domain() never fail, then also do the wrappers if_alloc(), if_alloc_dev(), and if_gethandle(). No functional change intended. Reviewed by: kp, imp, glebius, stevek MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D45740 (cherry picked from commit aa3860851b9f6a6002d135b1cac7736e0995eedc) 
Change 4787572d0580 made if_alloc_domain() never fail, then also do the
wrappers if_alloc(), if_alloc_dev(), and if_gethandle().

No functional change intended.

Reviewed by:	kp, imp, glebius, stevek
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D45740

(cherry picked from commit aa3860851b9f6a6002d135b1cac7736e0995eedc)
netmap: Use device_set_descf() 2024-06-27T15:27:41+00:00 Mark Johnston markj@FreeBSD.org 2024-06-05T14:17:14+00:00 e416932e18a0c4c8b485689a79224d2f0c98fbb2 No functional change intended. MFC after: 1 week (cherry picked from commit 44d36c9731c172977ad8a95a09c0d6fbddcc9b2f) 
No functional change intended.

MFC after:	1 week

(cherry picked from commit 44d36c9731c172977ad8a95a09c0d6fbddcc9b2f)
netmap: Ignore errors in CSB_WRITE() 2024-01-04T13:42:13+00:00 Mark Johnston markj@FreeBSD.org 2023-12-27T15:13:29+00:00 aa545f18d384d2e925dcc8de8f7ad7fb73e66dc1 The CSB_WRITE() and _READ() macros respectively write to and read from userspace memory and so can in principle fault. However, we do not check for errors and will proceed blindly if they fail. Add assertions to verify that they do not. This is in preparation for annotating copyin() and related functions with __result_use_check. Reviewed by: vmaffione MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D43200 (cherry picked from commit 99efa2c88d93c6272a8f54b18d18d0fd9d60f137) 
The CSB_WRITE() and _READ() macros respectively write to and read from
userspace memory and so can in principle fault.  However, we do not
check for errors and will proceed blindly if they fail.  Add assertions
to verify that they do not.

This is in preparation for annotating copyin() and related functions
with __result_use_check.

Reviewed by:	vmaffione
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D43200

(cherry picked from commit 99efa2c88d93c6272a8f54b18d18d0fd9d60f137)
sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16T17:54:36+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:36+00:00 685dc743dc3b5645e34836464128e1c0558b404b Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ 
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-16T17:54:24+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:24+00:00 71625ec9ad2a9bc8c09784fbd23b759830e0ee5f Remove /^/[*/]\s*\$FreeBSD\$.*\n/ 
Remove /^/[*/]\s*\$FreeBSD\$.*\n/
sys: Remove $FreeBSD$: one-line .h pattern 2023-08-16T17:54:18+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:18+00:00 2ff63af9b88c7413b7d71715b5532625752a248e Remove /^\s*\*+\s*\$FreeBSD\$.*$\n/ 
Remove /^\s*\*+\s*\$FreeBSD\$.*$\n/
sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16T17:54:11+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:11+00:00 95ee2897e98f5d444f26ed2334cc7c439f9c16c6 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ 
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/