src/sys/dev/nxge, branch main

nxge(4):

2018-05-08T21:14:29+00:00

Remove nxge(4) and associated man page and tools in FreeBSD 12.0.

Submitted by:	kbowling
Reviewed by:	brooks
Relnotes:	yes
Sponsored by:	Limelight Networks
Differential Revision:	https://reviews.freebsd.org/D1529

nxge(4) deprecation notice

2018-05-03T14:48:42+00:00

Submitted by:	kbowling
Reviewed by:	brooks
Sponsored by:	Limelight Networks
Differential Revision:	https://reviews.freebsd.org/D15277

Fix the build on arches with default unsigned char. Capture the fubyte()

2018-04-01T18:53:27+00:00

return value in an int as well as the char, and test the full int value
for fubyte() failure.

Fall back to ether_ioctl() by default.

2018-03-30T20:24:29+00:00

The common pratice in ethernet device drivers is to fall back to
ether_ioctl() to implement generic ioctls not implemented by the driver
and to fail if no handler exists.

Convert these drivers to follow that practice rather than calling
ether_ioctl() for specific cases.

vxge(4) aready had the default case, but it was only called on failure
to match.

Reviewed by:	imp
Obtained from:	CheriBSD
Sponsored by:	DARPA, AFRL
Differential Revision:	https://reviews.freebsd.org/D14895

Use an accessor function to access ifr_data.

2018-03-30T18:50:13+00:00

This fixes 32-bit compat (no ioctl command defintions are required
as struct ifreq is the same size).  This is believed to be sufficent to
fully support ifconfig on 32-bit systems.

Reviewed by:	kib
Obtained from:	CheriBSD
MFC after:	1 week
Relnotes:	yes
Sponsored by:	DARPA, AFRL
Differential Revision:	https://reviews.freebsd.org/D14900

Don't access userspace directly from the kernel in nxge(4).

2018-03-27T21:14:39+00:00

Update to what the previous code seemed to be doing via the correct
interfaces.  Further issues exist in xge_ioctl_registers(), but this is
debugging code in a driver that has few users and they don't appear to
be crashes or leaks.

Reviewed by:	jhb (prior version)
MFC after:	1 week
Sponsored by:	DARPA, AFRL
Differential Revision:	https://reviews.freebsd.org/D14848

sys/dev: further adoption of SPDX licensing ID tags.

2017-11-27T14:52:40+00:00

Mainly focus on files that use BSD 2-Clause license, however the tool I
was using misidentified many licenses so this was mostly a manual - error
prone - task.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

nxge(4): Remove useless self-assignment.

2016-06-03T15:33:21+00:00

Apparently the original implementation brought a self-assignment
to work around some bogus lint issue that is not relevant anymore.

CID:	1347070

Replace 0 with NULL for pointers in misc. device drivers.

2016-04-12T17:23:03+00:00

Found with devel/coccinelle.

Fix what looks like a consistent copy&paste error.

2015-09-27T12:19:36+00:00

Don't make an integer to a boolean and then compare to a value which
needs an integer comparison.

Spotted by:	reading kernel compile time log
MFC after:	2 weeks