src/sys/dev/pms, branch stable/13

pms(4): Stop checking for failures from malloc(M_WAITOK)

2024-09-30T05:05:38+00:00

MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D45852

(cherry picked from commit 4fb8a80a78aa65e0b30bd5a74373512c678841c9)
(cherry picked from commit 025c4754941956e24830a9c3c6f5e2466b19a9e1)

sys: Remove $FreeBSD$: one-line .c pattern

2023-08-23T17:43:25+00:00

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

Similar commit in current:
(cherry picked from commit 685dc743dc3b)

sys: Remove $FreeBSD$: one-line .c comment pattern

2023-08-23T17:43:22+00:00

Remove /^/[*/]\s*\$FreeBSD\$.*\n/

Similar commit in current:
(cherry picked from commit 71625ec9ad2a)

sys: Remove $FreeBSD$: one-line .h pattern

2023-08-23T17:43:22+00:00

Remove /^\s*\*+\s*\$FreeBSD\$.*$\n/

Similar commit in current:
(cherry picked from commit 2ff63af9b88c)

Adjust tdsaContext_t::NvmdResponseSet declaration to avoid clang 15 warning

2022-07-24T11:00:07+00:00

With clang 15, the following -Werror warnings are produced:

    In file included from sys/dev/pms/freebsd/driver/ini/src/agtiapi.c:70:
    sys/dev/pms/RefTisa/tisa/sassata/common/tdsatypes.h:346:13: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
      volatile  NvmdResponseSet;
      ~~~~~~~~  ^
      int

The NvmdResponseSet member is effectively only used as a boolean in the
pms(4) driver, so it could be a single bit. But to avoid changing the
semantics at all in this unmaintained driver, simply declare it as a
volatile int.

MFC after:	3 days

(cherry picked from commit 95204d7a6368990e216db0ad51ef3e6018aed27c)

Fix some common typos in source code comments

2021-08-19T07:28:06+00:00

- s/struture/structure/
- s/structre/structure/

(cherry picked from commit 17db4b52fb41aeabeb945c68c1b5edd4db4eac31)

LinuxKPI: remove < 5.0 version support

2021-07-18T00:34:58+00:00

We are not aware of any out-of-tree consumers anymore
which would need KPI support for before Linux version 5.
Update the two in-tree consumers to use the new KPI.
This allows us to remove the extra version check and
will also give access to {lower,upper}_32_bits() unconditionally.

Sponsored by:	The FreeBSD Foundation
Reviewed by:	hselasky, rlibby, rstone
X-MFC:		to 13 only
Differential Revision: https://reviews.freebsd.org/D29391

(cherry picked from commit 3b1ecc9fa1b57ca7a1c86661e9a323bc41c97ecc)

pms(4): Limit maximum I/O size to 256KB instead of 1MB.

2021-04-23T01:05:42+00:00

There is a weird limit of AGTIAPI_MAX_DMA_SEGS (128) S/G segments per
I/O since the initial driver import.  I don't know why it was added,
can only guess some hardware limitation, but in worst case it means
maximum I/O size of 508KB.  Respect it to be safe, rounding to 256KB.

MFC after:	1 week
Sponsored by:	iXsystems, Inc.

(cherry picked from commit 3e347834200b5d91a33384e696793e4ac20a44d4)

pms(4): Do not return CAM_REQ_CMP on errors.

2021-04-23T01:05:24+00:00

It is a direct request for data corruptions, one report of which we
have received.  I am very surprised that only one.

MFC after:	1 week
Sponsored by:	iXsystems, Inc.

(cherry picked from commit 8434a65ce49bd6bc6779f0e57b0ce0f4bc46f48e)

pms: handle maximum size IO with any alignment

2021-01-20T21:59:49+00:00

Define the maximum numbers of segments to allow for non-page alignment
at the beginning and end of a maxphys size transfer.  Also set
ccb_pathinq.maxio consistent with maxphys.

Reviewed by:	imp
Sponsored by:	Dell EMC Isilon
Differential Revision:	https://reviews.freebsd.org/D28043