src/sys/dev/siis/siis.c, branch main FreeBSD source tree chore: replace {0, 0} with {DEV,KOBJ}METHOD_END 2026-02-25T05:59:34+00:00 Enji Cooper ngie@FreeBSD.org 2026-02-21T06:14:46+00:00 0fc6c3f731a2cca3120798806c330a3081c9424b Both of the aforementioned macros have been present in FreeBSD for well over a decade: 2009 for `KOBJMETHOD_END`; 2011 for `DEVMETHOD_END`. Adapt all hardcoded references of `{0, 0}` with `DEVMETHOD_END` and `KOBJMETHOD_END` as appropriate. This helps ensure that future adaptations to drivers following patterns documented in driver(9) can be made more easily/without issue. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D55414 
Both of the aforementioned macros have been present in FreeBSD
for well over a decade: 2009 for `KOBJMETHOD_END`; 2011 for
`DEVMETHOD_END`.

Adapt all hardcoded references of `{0, 0}` with `DEVMETHOD_END`
and `KOBJMETHOD_END` as appropriate. This helps ensure that
future adaptations to drivers following patterns documented
in driver(9) can be made more easily/without issue.

MFC after:	1 week
Differential Revision:	 https://reviews.freebsd.org/D55414
bus_alloc_resource: Pass rid by value to BUS_ALLOC_RESOURCE DEVMETHOD 2025-12-09T20:00:06+00:00 John Baldwin jhb@FreeBSD.org 2025-12-09T19:59:21+00:00 575639548cef58590a1d70c29e47aae0e8d44153 The wrapper functions such as bus_alloc_resource_any() still support passing the rid by value or pointer, but the underlying implementation now passes by value. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D53402 
The wrapper functions such as bus_alloc_resource_any() still support
passing the rid by value or pointer, but the underlying implementation
now passes by value.

Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D53402
machine/stdarg.h -> sys/stdarg.h 2025-06-11T16:39:02+00:00 Brooks Davis brooks@FreeBSD.org 2025-06-11T16:39:02+00:00 e453e498cbb88570a3ff7b3679de65c88707da95 Switch to using sys/stdarg.h for va_list type and va_* builtins. Make an attempt to insert the include in a sensible place. Where style(9) was followed this is easy, where it was ignored, aim for the first block of sys/*.h headers and don't get too fussy or try to fix other style bugs. Reviewed by: imp Exp-run by: antoine (PR 286274) Pull Request: https://github.com/freebsd/freebsd-src/pull/1595 
Switch to using sys/stdarg.h for va_list type and va_* builtins.

Make an attempt to insert the include in a sensible place.  Where
style(9) was followed this is easy, where it was ignored, aim for the
first block of sys/*.h headers and don't get too fussy or try to fix
other style bugs.

Reviewed by:	imp
Exp-run by:	antoine (PR 286274)
Pull Request:	https://github.com/freebsd/freebsd-src/pull/1595
Use bus_generic_detach instead of device_delete_children in detach 2025-01-02T18:24:28+00:00 John Baldwin jhb@FreeBSD.org 2025-01-02T18:24:28+00:00 3ddaf8200bc90b1410755ebac7b5c979ea90a2f6 While here, check for errors from bus_generic_detach and move it to the start of detach if necessary. Differential Revision: https://reviews.freebsd.org/D47969 
While here, check for errors from bus_generic_detach and move it to
the start of detach if necessary.

Differential Revision:	https://reviews.freebsd.org/D47969
Replace calls to bus_generic_attach with bus_attach_children 2024-12-06T22:26:16+00:00 John Baldwin jhb@FreeBSD.org 2024-12-06T22:26:16+00:00 18250ec6c089c0c50cbd9fd87d78e03ff89916df Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47675 
Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D47675
newbus: globally replace device_add_child(..., -1) with DEVICE_UNIT_ANY 2024-07-25T04:22:58+00:00 Warner Losh imp@FreeBSD.org 2024-07-25T04:22:58+00:00 5b56413d04e608379c9a306373554a8e4d321bc0 Sponsored by: Netflix 
Sponsored by:		Netflix
Fix SATA NCQ error recovery after 25375b1415 2024-06-27T13:29:23+00:00 Alexander Motin mav@FreeBSD.org 2024-06-27T13:29:23+00:00 87085c12ba8fa51f777bc636df67008b45e20d1c Since that commit ahci(4), siis(4) and mvs(4) drivers ended up using wrong command to fetch error information for NCQ commands. Since ATA errors are not very informative to begin with, the only noticeable effect is a lack of retries on those errors by CAM. MFC after: 1 week PR: 279978 
Since that commit ahci(4), siis(4) and mvs(4) drivers ended up
using wrong command to fetch error information for NCQ commands.
Since ATA errors are not very informative to begin with, the only
noticeable effect is a lack of retries on those errors by CAM.

MFC after:	1 week
PR:		279978
siis: Use device_set_desc(f)() 2024-06-02T23:38:41+00:00 Mark Johnston markj@FreeBSD.org 2024-02-04T23:44:11+00:00 17bfbc400f53ff1768c907b35c9cf045d540b8ab No functional change intended. MFC after: 1 week 
No functional change intended.

MFC after:	1 week
new-bus: Remove the 'rid' and 'type' arguments from BUS_RELEASE_RESOURCE 2024-03-13T22:05:54+00:00 John Baldwin jhb@FreeBSD.org 2024-03-13T22:05:54+00:00 9dbf5b0e6876d8c93890754bcc9c748339de79c0 The public bus_release_resource() API still accepts both forms, but the internal kobj method no longer passes the arguments. Implementations which need the rid or type now use rman_get_rid() or rman_get_type() to fetch the value from the allocated resource. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D44131 
The public bus_release_resource() API still accepts both forms, but
the internal kobj method no longer passes the arguments.
Implementations which need the rid or type now use rman_get_rid() or
rman_get_type() to fetch the value from the allocated resource.

Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D44131
sys: Automated cleanup of cdefs and other formatting 2023-11-27T05:24:00+00:00 Warner Losh imp@FreeBSD.org 2023-11-24T20:12:57+00:00 fdafd315ad0d0f28a11b9fb4476a9ab059c62b92 Apply the following automated changes to try to eliminate no-longer-needed sys/cdefs.h includes as well as now-empty blank lines in a row. Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/ Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/ Remove /\n+#if.*\n#endif.*\n+/ Remove /^#if.*\n#endif.*\n/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/ Sponsored by: Netflix 
Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/

Sponsored by:		Netflix