<feed xmlns='http://www.w3.org/2005/Atom'>
<title>src/sys/dev/smartpqi, branch stable/13</title>
<subtitle>FreeBSD source tree</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/'/>
<entry>
<title>smartpqi: Drop spinlock before freeing memory</title>
<updated>2024-02-19T04:07:04+00:00</updated>
<author>
<name>John F. Carr</name>
<email>jfc@mit.edu</email>
</author>
<published>2023-10-19T03:02:42+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=898e02d740741d13a8948cbad4e0d969a768fd30'/>
<id>898e02d740741d13a8948cbad4e0d969a768fd30</id>
<content type='text'>
pqisrc_free_device frees the device softc with the os spinlock
held. This causes crashes when devices are removed because the memory
free might sleep (which is prohibited with spin locks held). Drop the
spinlock before releasing the memory.

MFC After: 2 days
PR: 273289
Reviewed by: imp

This is the alternate fix from the box.

(this is not a cherry pick of b064a4c9eed5b1dd2a40fc4fd2cb7e738b681547)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
pqisrc_free_device frees the device softc with the os spinlock
held. This causes crashes when devices are removed because the memory
free might sleep (which is prohibited with spin locks held). Drop the
spinlock before releasing the memory.

MFC After: 2 days
PR: 273289
Reviewed by: imp

This is the alternate fix from the box.

(this is not a cherry pick of b064a4c9eed5b1dd2a40fc4fd2cb7e738b681547)
</pre>
</div>
</content>
</entry>
<entry>
<title>sys: Remove $FreeBSD$: one-line .c comment pattern</title>
<updated>2023-08-23T17:43:22+00:00</updated>
<author>
<name>Warner Losh</name>
<email>imp@FreeBSD.org</email>
</author>
<published>2023-08-22T01:31:15+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=4fbf14e22d7b83de7080a8e491ba14a5785a0ff4'/>
<id>4fbf14e22d7b83de7080a8e491ba14a5785a0ff4</id>
<content type='text'>
Remove /^/[*/]\s*\$FreeBSD\$.*\n/

Similar commit in current:
(cherry picked from commit 71625ec9ad2a)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove /^/[*/]\s*\$FreeBSD\$.*\n/

Similar commit in current:
(cherry picked from commit 71625ec9ad2a)
</pre>
</div>
</content>
</entry>
<entry>
<title>smartpqi(4): Fix two typos in kernel error messages</title>
<updated>2022-11-08T07:06:34+00:00</updated>
<author>
<name>Gordon Bergling</name>
<email>gbe@FreeBSD.org</email>
</author>
<published>2022-10-25T11:17:20+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=bf72896aae8a01b8ef56a1b75aceb065585df102'/>
<id>bf72896aae8a01b8ef56a1b75aceb065585df102</id>
<content type='text'>
- s/runnning/running/

(cherry picked from commit d53e97bb5490cdedb37bd4e25646c5379b196c93)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- s/runnning/running/

(cherry picked from commit d53e97bb5490cdedb37bd4e25646c5379b196c93)
</pre>
</div>
</content>
</entry>
<entry>
<title>Adjust check_struct_sizes() definition to avoid clang 15 warning</title>
<updated>2022-07-29T18:31:13+00:00</updated>
<author>
<name>Dimitry Andric</name>
<email>dim@FreeBSD.org</email>
</author>
<published>2022-07-26T11:20:58+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=105f9406c95593f0c887932f4087fac490ddefe6'/>
<id>105f9406c95593f0c887932f4087fac490ddefe6</id>
<content type='text'>
With clang 15, the following -Werror warning is produced:

    sys/dev/smartpqi/smartpqi_helper.c:374:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
    check_struct_sizes()
                      ^
                       void

This is because check_struct_sizes() is declared with a (void) argument
list, but defined with an empty argument list. Make the definition match
the declaration.

MFC after:	3 days

(cherry picked from commit fb1c21688c5702d0bc50d67359dee4af12d0c693)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
With clang 15, the following -Werror warning is produced:

    sys/dev/smartpqi/smartpqi_helper.c:374:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
    check_struct_sizes()
                      ^
                       void

This is because check_struct_sizes() is declared with a (void) argument
list, but defined with an empty argument list. Make the definition match
the declaration.

MFC after:	3 days

(cherry picked from commit fb1c21688c5702d0bc50d67359dee4af12d0c693)
</pre>
</div>
</content>
</entry>
<entry>
<title>smartpqi(4): Fix a typo in a source code comment</title>
<updated>2022-04-09T06:17:49+00:00</updated>
<author>
<name>Gordon Bergling</name>
<email>gbe@FreeBSD.org</email>
</author>
<published>2022-04-02T13:21:45+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=85d53cae7a0cbec341178bfbb13c99d2be43bd5e'/>
<id>85d53cae7a0cbec341178bfbb13c99d2be43bd5e</id>
<content type='text'>
- s/commmand/command/

(cherry picked from commit 882d3b24fe055b777efb7de575f8126ab965085b)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- s/commmand/command/

(cherry picked from commit 882d3b24fe055b777efb7de575f8126ab965085b)
</pre>
</div>
</content>
</entry>
<entry>
<title>Update smartqpi driver to vendor's latest submission</title>
<updated>2022-03-09T20:52:23+00:00</updated>
<author>
<name>Warner Losh</name>
<email>imp@FreeBSD.org</email>
</author>
<published>2022-03-09T00:01:04+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=bec8eb5998fc0f6869944150bb34144fe2676243'/>
<id>bec8eb5998fc0f6869944150bb34144fe2676243</id>
<content type='text'>
Newly added features &amp; bug fixes

o Fixed an issue smartpqi debug log messages are flooding kernel logs.
o Fixed an issue where devices are shown as RAID 0 in display info.
o Feature: Changed 32 bit dma address to 64 bit address
o Added new controlller ids.

Submitted by:		Microsemi
Reviewed by:		Scott Benesh (Microsemi), imp
Differential Revision:	https://reviews.freebsd.org/D34469
MFC After:		3 days

Sponsored by:		Netflix

(cherry picked from commit 4f77349d5777c8ac504387e7e6d37c13da222294)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Newly added features &amp; bug fixes

o Fixed an issue smartpqi debug log messages are flooding kernel logs.
o Fixed an issue where devices are shown as RAID 0 in display info.
o Feature: Changed 32 bit dma address to 64 bit address
o Added new controlller ids.

Submitted by:		Microsemi
Reviewed by:		Scott Benesh (Microsemi), imp
Differential Revision:	https://reviews.freebsd.org/D34469
MFC After:		3 days

Sponsored by:		Netflix

(cherry picked from commit 4f77349d5777c8ac504387e7e6d37c13da222294)
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix "set but not used" in smartpqi.  The PCI_MEM macros don't require a</title>
<updated>2022-03-09T20:52:23+00:00</updated>
<author>
<name>Scott Long</name>
<email>scottl@FreeBSD.org</email>
</author>
<published>2022-02-26T17:25:43+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=78564b68723f53bdd854da4e5cedf740289e956e'/>
<id>78564b68723f53bdd854da4e5cedf740289e956e</id>
<content type='text'>
physical/absolute address in FreeBSD, but it looks like the calling
code might be somewhat portable to other OS's that do require this.
Therefore, set the variables to __unused instead of removing the code
entirely.

(cherry picked from commit e28289ca83673d753b7e479810947f6a1015ad39)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
physical/absolute address in FreeBSD, but it looks like the calling
code might be somewhat portable to other OS's that do require this.
Therefore, set the variables to __unused instead of removing the code
entirely.

(cherry picked from commit e28289ca83673d753b7e479810947f6a1015ad39)
</pre>
</div>
</content>
</entry>
<entry>
<title>smartpqi: Remove stray declaration</title>
<updated>2022-03-09T20:52:23+00:00</updated>
<author>
<name>Warner Losh</name>
<email>imp@FreeBSD.org</email>
</author>
<published>2021-06-03T23:44:27+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=8f37a79a9fdd3d72522e4d8d23c3b197f2a916d8'/>
<id>8f37a79a9fdd3d72522e4d8d23c3b197f2a916d8</id>
<content type='text'>
pqisrc_is_firmware_feature_enabled shouldn't be declared inline in a
header, and then static inline in the .c function. Remove this stray
declartion from the header. gcc6 complains, but clang does not.

Sponsored by:		Netflix

(cherry picked from commit eae2ef5a010366c673ad912cae23b426ebb9a8a2)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
pqisrc_is_firmware_feature_enabled shouldn't be declared inline in a
header, and then static inline in the .c function. Remove this stray
declartion from the header. gcc6 complains, but clang does not.

Sponsored by:		Netflix

(cherry picked from commit eae2ef5a010366c673ad912cae23b426ebb9a8a2)
</pre>
</div>
</content>
</entry>
<entry>
<title>smartpqi: clear CCBs allocated on the stack</title>
<updated>2021-06-03T13:53:12+00:00</updated>
<author>
<name>Edward Tomasz Napierala</name>
<email>trasz@FreeBSD.org</email>
</author>
<published>2021-05-28T06:33:37+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=92f49c769b4ef51163151c3991357a08941e232d'/>
<id>92f49c769b4ef51163151c3991357a08941e232d</id>
<content type='text'>
Differential Revision:		https://reviews.freebsd.org/D30299

(cherry picked from commit e20e60be501204c3ba742e266afecc6c6e498a6c)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Differential Revision:		https://reviews.freebsd.org/D30299

(cherry picked from commit e20e60be501204c3ba742e266afecc6c6e498a6c)
</pre>
</div>
</content>
</entry>
<entry>
<title>Newly added features and bug fixes in latest Microchip SmartPQI driver</title>
<updated>2021-06-03T13:53:06+00:00</updated>
<author>
<name>PAPANI SRIKANTH</name>
<email>papani.srikanth@microchip.com</email>
</author>
<published>2021-05-28T06:17:56+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=1569aab1cb38a38fb619f343ed1e47d4b4070ffe'/>
<id>1569aab1cb38a38fb619f343ed1e47d4b4070ffe</id>
<content type='text'>
It includes:

1)Newly added TMF feature.
2)Added newly Huawei &amp; Inspur PCI ID's
3)Fixed smartpqi driver hangs in Z-Pool while running on FreeBSD12.1
4)Fixed flooding dmesg in kernel while the controller is offline during in ioctls.
5)Avoided unnecessary host memory allocation for rcb sg buffers.
6)Fixed race conditions while accessing internal rcb structure.
7)Fixed where Logical volumes exposing two different names to the OS it's due to the system memory is overwritten with DMA stale data.
8)Fixed dynamically unloading a smartpqi driver.
9)Added device_shutdown callback instead of deprecated shutdown_final kernel event in smartpqi driver.
10)Fixed where Os is crashed during physical drive hot removal during heavy IO.
11)Fixed OS crash during controller lockup/offline during heavy IO.
12)Fixed coverity issues in smartpqi driver
13)Fixed system crash while creating and deleting logical volume in a continuous loop.
14)Fixed where the volume size is not exposing to OS when it expands.
15)Added HC3 pci id's.

Reviewed by:		Scott Benesh (microsemi), Murthy Bhat (microsemi), imp
Differential Revision:	https://reviews.freebsd.org/D30182

(cherry picked from commit 9fac68fc3853b696c8479bb3a8181d62cb9f59c9)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It includes:

1)Newly added TMF feature.
2)Added newly Huawei &amp; Inspur PCI ID's
3)Fixed smartpqi driver hangs in Z-Pool while running on FreeBSD12.1
4)Fixed flooding dmesg in kernel while the controller is offline during in ioctls.
5)Avoided unnecessary host memory allocation for rcb sg buffers.
6)Fixed race conditions while accessing internal rcb structure.
7)Fixed where Logical volumes exposing two different names to the OS it's due to the system memory is overwritten with DMA stale data.
8)Fixed dynamically unloading a smartpqi driver.
9)Added device_shutdown callback instead of deprecated shutdown_final kernel event in smartpqi driver.
10)Fixed where Os is crashed during physical drive hot removal during heavy IO.
11)Fixed OS crash during controller lockup/offline during heavy IO.
12)Fixed coverity issues in smartpqi driver
13)Fixed system crash while creating and deleting logical volume in a continuous loop.
14)Fixed where the volume size is not exposing to OS when it expands.
15)Added HC3 pci id's.

Reviewed by:		Scott Benesh (microsemi), Murthy Bhat (microsemi), imp
Differential Revision:	https://reviews.freebsd.org/D30182

(cherry picked from commit 9fac68fc3853b696c8479bb3a8181d62cb9f59c9)
</pre>
</div>
</content>
</entry>
</feed>
