src/sys/dev/speaker/spkr.c, branch main FreeBSD source tree speaker(4): move static data to text 2026-04-24T22:04:43+00:00 Raphael 'kena' Poss knz@thaumogen.net 2026-01-11T21:07:35+00:00 f31e6b198faa98c4f8a7b681b4e01218f8468411 Make this data const (it doesn't change) which will also move it to a text section. Signed-off-by: Raphael Poss <knz@thaumogen.net> Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1922 
Make this data const (it doesn't change) which will also move it to
a text section.

Signed-off-by: Raphael Poss <knz@thaumogen.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1922
Revert "speaker(4): move static data to bss" 2026-04-24T22:04:14+00:00 Warner Losh imp@FreeBSD.org 2026-04-24T22:04:14+00:00 45a12d8a2656bdf38e95f8e481c72aea0db6997f This reverts commit 690ef95b3354ac7a80aa469fa7a8f15f07962f83. The commit message was wrong. 
This reverts commit 690ef95b3354ac7a80aa469fa7a8f15f07962f83.

The commit message was wrong.
speaker(4): enable concurrent opens from different threads 2026-04-24T16:23:07+00:00 Raphael 'kena' Poss knz@thaumogen.net 2026-01-11T21:47:43+00:00 d76523a318d79767225ae020422a8f10046084af Prior to this patch, a thread would get EBUSY on open(2) if another thread had the speaker open. With this patch, two or more threads/processes can use the speaker device at the same time. When two or more threads write to the speaker concurrently, individual melodies--single strings, as written by write(2) or ioctl(2) with command SPKRTONE/SPKRTUNE--are played atomically. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1922 
Prior to this patch, a thread would get EBUSY on open(2) if another
thread had the speaker open.

With this patch, two or more threads/processes can use the speaker
device at the same time. When two or more threads write to the speaker
concurrently, individual melodies--single strings, as written by
write(2) or ioctl(2) with command SPKRTONE/SPKRTUNE--are played
atomically.

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1922
speaker(4): move static data to bss 2026-04-24T16:23:06+00:00 Raphael 'kena' Poss knz@thaumogen.net 2026-01-11T21:07:35+00:00 690ef95b3354ac7a80aa469fa7a8f15f07962f83 Signed-off-by: Raphael Poss <knz@thaumogen.net> Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1922 
Signed-off-by: Raphael Poss <knz@thaumogen.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1922
speaker(4): one ioctl / write at a time 2026-04-24T16:23:06+00:00 Raphael 'kena' Poss knz@thaumogen.net 2026-01-01T16:45:45+00:00 e2199dc33f16332b3e138da3059ba57c25ef713d If two processes are holding a spkr fd, we want orderly access to the allocated tone buffer and the speaker itself. Signed-off-by: Raphael Poss <knz@thaumogen.net> Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1922 
If two processes are holding a spkr fd, we want orderly access to the
allocated tone buffer and the speaker itself.

Signed-off-by: Raphael Poss <knz@thaumogen.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1922
speaker(4): make spkropen thread-safe 2026-04-24T16:23:06+00:00 Raphael 'kena' Poss knz@thaumogen.net 2026-01-01T16:34:44+00:00 a80ec2b51ac6b8f2588b927913e40c7a3d2862e6 Signed-off-by: Raphael Poss <knz@thaumogen.net> Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1922 
Signed-off-by: Raphael Poss <knz@thaumogen.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1922
speaker(4): drop NEEDGIANT 2026-04-24T16:23:06+00:00 Raphael Poss knz@thaumogen.net 2025-12-10T20:12:22+00:00 43b7cf42d425abc84a1313b7eed933438804a051 When the frequency configuration logic was moved to clock.c in 2008, a mutex lock was added there (timer_spkr_setfreq) to serialize accesses to the I/O register. Since then, no more calls to disable/enable_intr were needed in spkr.c than they were needed in the other callers to the same timer_spkr functions in syscons / kern_cons, that is, not at all. This is because there are no other accesses remaining in the kernel to the i8254 timers after boot than through clock.c. For context, see commits e46598588587b4897f6604489364f83fffd4d033 and 93f5134aaf829826dbcbea457bfeb27389761854. Signed-off-by: Raphael Poss <knz@thaumogen.net> Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1922 
When the frequency configuration logic was moved to clock.c in 2008, a
mutex lock was added there (timer_spkr_setfreq) to serialize accesses
to the I/O register.

Since then, no more calls to disable/enable_intr were needed in spkr.c
than they were needed in the other callers to the same timer_spkr
functions in syscons / kern_cons, that is, not at all. This is because
there are no other accesses remaining in the kernel to the i8254
timers after boot than through clock.c.

For context, see commits
e46598588587b4897f6604489364f83fffd4d033
and
93f5134aaf829826dbcbea457bfeb27389761854.

Signed-off-by: Raphael Poss <knz@thaumogen.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1922
speaker(4): Update outdated comments 2026-04-24T16:23:06+00:00 Raphael Poss knz@thaumogen.net 2025-12-10T19:53:21+00:00 03a515e9890b0c6844457254e26dc34333b85127 The comments in tone() were referring to pre-2000 logic that does not exist any more. This patch updates them. Signed-off-by: Raphael Poss <knz@thaumogen.net> Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1922 
The comments in tone() were referring to pre-2000 logic that does not
exist any more. This patch updates them.

Signed-off-by: Raphael Poss <knz@thaumogen.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1922
speaker: Use standard C bool 2024-02-05T23:45:32+00:00 John Baldwin jhb@FreeBSD.org 2024-02-05T23:40:34+00:00 c83d83206a39c7c47139acac46885bea54ee4876 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D43717 
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D43717
sys: Automated cleanup of cdefs and other formatting 2023-11-27T05:24:00+00:00 Warner Losh imp@FreeBSD.org 2023-11-24T20:12:57+00:00 fdafd315ad0d0f28a11b9fb4476a9ab059c62b92 Apply the following automated changes to try to eliminate no-longer-needed sys/cdefs.h includes as well as now-empty blank lines in a row. Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/ Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/ Remove /\n+#if.*\n#endif.*\n+/ Remove /^#if.*\n#endif.*\n/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/ Sponsored by: Netflix 
Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/

Sponsored by:		Netflix