src/sys/dev/speaker, branch stable/14 FreeBSD source tree speaker: Use standard C bool 2024-11-30T13:55:57+00:00 John Baldwin jhb@FreeBSD.org 2024-02-05T23:40:34+00:00 8bebcb26763a8d80c255b2c9367d510e98da17b4 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D43717 (cherry picked from commit c83d83206a39c7c47139acac46885bea54ee4876) 
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D43717

(cherry picked from commit c83d83206a39c7c47139acac46885bea54ee4876)
sys: Remove $FreeBSD$: one-line .c pattern 2023-08-16T17:54:36+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:36+00:00 685dc743dc3b5645e34836464128e1c0558b404b Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ 
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
sys: Remove $FreeBSD$: two-line .h pattern 2023-08-16T17:54:11+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:11+00:00 95ee2897e98f5d444f26ed2334cc7c439f9c16c6 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ 
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
speaker: ansify 2023-02-13T18:28:09+00:00 Mateusz Guzik mjg@FreeBSD.org 2023-02-13T18:28:09+00:00 aa0b46948e92bbfb09002dce083993c0b2465c56 Sponsored by: Rubicon Communications, LLC ("Netgate") 
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Adjust playinit() definition to avoid clang 15 warning 2022-07-26T17:59:55+00:00 Dimitry Andric dim@FreeBSD.org 2022-07-26T11:43:46+00:00 57c46916e145581807333bc06a08e9532721bd8f With clang 15, the following -Werror warning is produced: sys/dev/speaker/spkr.c:182:9: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] playinit() ^ void This is because playinit() is declared with a (void) argument list, but defined with an empty argument list. Make the definition match the declaration. MFC after: 3 days 
With clang 15, the following -Werror warning is produced:

    sys/dev/speaker/spkr.c:182:9: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
    playinit()
            ^
             void

This is because playinit() is declared with a (void) argument list, but
defined with an empty argument list. Make the definition match the
declaration.

MFC after:	3 days
Remove splclock(). It's not useful to keep. 2020-08-28T16:40:33+00:00 Warner Losh imp@FreeBSD.org 2020-08-28T16:40:33+00:00 1f7705606e8286960a2cea3d514a1deb5339047f splclock is used in one driver (spkr) to control access to timer_spkr_* routines. However, nothing else does. So it shows no useful locking info to someone that would want to lock spkr. NOTE: I think there's races with timer_spkr_{acquire,release} since there's no interlock in those routines, despite there being a spin lock to protect the clock. Current other users appear to use no extra locking protocol, though they themselves appear to be at least attempting to make sure that only a single thread calls these routines. I suspect the right answer is to update these routines to take/release the clock spin lock since they are short and to the point, but that's beyond the scope of this commit. 
splclock is used in one driver (spkr) to control access to
timer_spkr_* routines.  However, nothing else does. So it shows no
useful locking info to someone that would want to lock spkr.

NOTE: I think there's races with timer_spkr_{acquire,release} since
there's no interlock in those routines, despite there being a spin
lock to protect the clock. Current other users appear to use no extra
locking protocol, though they themselves appear to be at least
attempting to make sure that only a single thread calls these
routines. I suspect the right answer is to update these routines to
take/release the clock spin lock since they are short and to the
point, but that's beyond the scope of this commit.
Remove register keyword from sys/ and ANSIfy prototypes 2017-05-17T00:34:34+00:00 Ed Maste emaste@FreeBSD.org 2017-05-17T00:34:34+00:00 3e85b721d653d65a5b6ff655ed1551113f0e0d5b A long long time ago the register keyword told the compiler to store the corresponding variable in a CPU register, but it is not relevant for any compiler used in the FreeBSD world today. ANSIfy related prototypes while here. Reviewed by: cem, jhb Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D10193 
A long long time ago the register keyword told the compiler to store
the corresponding variable in a CPU register, but it is not relevant
for any compiler used in the FreeBSD world today.

ANSIfy related prototypes while here.

Reviewed by:	cem, jhb
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D10193
sys/dev: use our nitems() macro when it is avaliable through param.h. 2016-04-19T23:37:24+00:00 Pedro F. Giffuni pfg@FreeBSD.org 2016-04-19T23:37:24+00:00 73a1170a8c41cb848f17cc0a8839e9dcee3d126e No functional change, only trivial cases are done in this sweep, Drivers that can get further enhancements will be done independently. Discussed in: freebsd-current 
No functional change, only trivial cases are done in this sweep,
Drivers that can get further enhancements will be done independently.

Discussed in:	freebsd-current
Do not define bool/true/false if the symbols already exist. 2011-12-12T18:43:24+00:00 Matthew D Fleming mdf@FreeBSD.org 2011-12-12T18:43:24+00:00 103af58f59c0cb69f1872cbebeb4213d4020e4b9 MFC after: 2 weeks Sponsored by: Isilon Systems, LLC 
MFC after:	2 weeks
Sponsored by:	Isilon Systems, LLC
Change the type of uio_resid member of struct uio from int to ssize_t. 2009-06-25T18:46:30+00:00 Konstantin Belousov kib@FreeBSD.org 2009-06-25T18:46:30+00:00 9f80ce043db0c82b6f341ab58bb8b840c0dfd69e Note that this does not actually enable full-range i/o requests for 64 architectures, and is done now to update KBI only. Tested by: pho Reviewed by: jhb, bde (as part of the review of the bigger patch) 
Note that this does not actually enable full-range i/o requests for
64 architectures, and is done now to update KBI only.

Tested by:	pho
Reviewed by:	jhb, bde (as part of the review of the bigger patch)