src/sys/dev/sym, branch stable/13 FreeBSD source tree Fix "set but not used" for the sym driver. 2024-04-18T19:41:36+00:00 Scott Long scottl@FreeBSD.org 2021-12-03T22:18:39+00:00 8ee68ab867785b90a77c9c0e6c2ef92fc8a265b1 Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 5045cb8f18f9f79354f93174ba7f9fd2f7ea6994) 
Sponsored by: Rubicon Communications, LLC ("Netgate")

(cherry picked from commit 5045cb8f18f9f79354f93174ba7f9fd2f7ea6994)
sym(4): Add __diagused to nseg of getbaddrcb() 2024-01-05T22:48:34+00:00 Marius Strobl marius@FreeBSD.org 2023-08-18T14:29:10+00:00 e7550f26f306730304b9c94f4936076be6357e99 The parameter is only used when compiling with INVARIANTS. (cherry picked from commit ae6d4963589418f2116ddc8cabcf93dd2f4bbf3b) 
The parameter is only used when compiling with INVARIANTS.

(cherry picked from commit ae6d4963589418f2116ddc8cabcf93dd2f4bbf3b)
sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23T17:43:25+00:00 Warner Losh imp@FreeBSD.org 2023-08-22T01:31:27+00:00 3bc80996974a61a4223eae4c1ccd47b6ee32a48a Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ Similar commit in current: (cherry picked from commit 685dc743dc3b) 
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

Similar commit in current:
(cherry picked from commit 685dc743dc3b)
sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-23T17:43:22+00:00 Warner Losh imp@FreeBSD.org 2023-08-22T01:31:15+00:00 4fbf14e22d7b83de7080a8e491ba14a5785a0ff4 Remove /^/[*/]\s*\$FreeBSD\$.*\n/ Similar commit in current: (cherry picked from commit 71625ec9ad2a) 
Remove /^/[*/]\s*\$FreeBSD\$.*\n/

Similar commit in current:
(cherry picked from commit 71625ec9ad2a)
sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23T17:43:20+00:00 Warner Losh imp@FreeBSD.org 2023-08-22T01:31:02+00:00 f8167e0404dab9ffeaca95853dd237ab7c587f82 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ Similar commit in current: (cherry picked from commit 95ee2897e98f) 
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

Similar commit in current:
(cherry picked from commit 95ee2897e98f)
sym(4): Fix a typo in a source code comment 2022-04-14T06:17:03+00:00 Gordon Bergling gbe@FreeBSD.org 2022-04-08T19:04:01+00:00 bcdea7f57894869dac18c429fc33c04d650cc7e2 - s/explicitely/explicitly/ (cherry picked from commit 4e27f867331c9db84e9c4cbdac1bbd49927f59d6) 
- s/explicitely/explicitly/

(cherry picked from commit 4e27f867331c9db84e9c4cbdac1bbd49927f59d6)
sym(4): handle mixed tagged/untagged commands gracefully 2021-01-21T23:18:39+00:00 Marius Strobl marius@FreeBSD.org 2021-01-21T22:48:08+00:00 2dcbf0462e17db1b0a8cc99d1f95a7b0ba6437b2 Handle the case of a tagged command arriving when there's an untagged one still outstanding gracefully instead of panicing. While at it: - Replace fancy arithmetics with a simple assignment as busy_itl can only ever be either 0 or 1. - Fix a comment typo in sym_free_ccb(). 
Handle the case of a tagged command arriving when there's an untagged
one still outstanding gracefully instead of panicing.

While at it:
- Replace fancy arithmetics with a simple assignment as busy_itl can
  only ever be either 0 or 1.
- Fix a comment typo in sym_free_ccb().
sym(4): fix nits reported by Coverity 2021-01-21T23:18:39+00:00 Marius Strobl marius@FreeBSD.org 2021-01-21T22:34:19+00:00 e60a0db3b8c922f9bcd085f737508a9cb4eb7f29 - In ___dma_getp(), remove dead code. [1] - In sym_sir_bad_scsi_status(), add missing FALLTHROUGH. [2] While at it: - For getbaddrcb(), remove __unused from the nseg argument as it's in fact used when compiling with INVARIANTS. - In sym_int_sir(), ensure in all branches that cp is not NULL before using it. Reported by: Coverity CID: 1008861 [1], 114996 [2] 
- In ___dma_getp(), remove dead code. [1]
- In sym_sir_bad_scsi_status(), add missing FALLTHROUGH. [2]

While at it:
- For getbaddrcb(), remove __unused from the nseg argument as it's in
  fact used when compiling with INVARIANTS.
- In sym_int_sir(), ensure in all branches that cp is not NULL before
  using it.

Reported by:	Coverity
CID:		1008861 [1], 114996 [2]
sym(4): Remove remainder of SYM_SETUP_LP_PROBE_MAP support 2021-01-16T22:53:12+00:00 Marius Strobl marius@FreeBSD.org 2020-12-27T18:38:58+00:00 d65427ad582cac085428a0b7cf805a8e6996a7a4 Missed in 221ac8f4cd823a2b047c2807e2cf744c7176dd1f and r339575 respectively. 
Missed in 221ac8f4cd823a2b047c2807e2cf744c7176dd1f and r339575
respectively.
Make MAXPHYS tunable. Bump MAXPHYS to 1M. 2020-11-28T12:12:51+00:00 Konstantin Belousov kib@FreeBSD.org 2020-11-28T12:12:51+00:00 cd8537910406e68d4719136a5b0cf6d23bb1b23b Replace MAXPHYS by runtime variable maxphys. It is initialized from MAXPHYS by default, but can be also adjusted with the tunable kern.maxphys. Make b_pages[] array in struct buf flexible. Size b_pages[] for buffer cache buffers exactly to atop(maxbcachebuf) (currently it is sized to atop(MAXPHYS)), and b_pages[] for pbufs is sized to atop(maxphys) + 1. The +1 for pbufs allow several pbuf consumers, among them vmapbuf(), to use unaligned buffers still sized to maxphys, esp. when such buffers come from userspace (*). Overall, we save significant amount of otherwise wasted memory in b_pages[] for buffer cache buffers, while bumping MAXPHYS to desired high value. Eliminate all direct uses of the MAXPHYS constant in kernel and driver sources, except a place which initialize maxphys. Some random (and arguably weird) uses of MAXPHYS, e.g. in linuxolator, are converted straight. Some drivers, which use MAXPHYS to size embeded structures, get private MAXPHYS-like constant; their convertion is out of scope for this work. Changes to cam/, dev/ahci, dev/ata, dev/mpr, dev/mpt, dev/mvs, dev/siis, where either submitted by, or based on changes by mav. Suggested by: mav (*) Reviewed by: imp, mav, imp, mckusick, scottl (intermediate versions) Tested by: pho Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D27225 
Replace MAXPHYS by runtime variable maxphys. It is initialized from
MAXPHYS by default, but can be also adjusted with the tunable kern.maxphys.

Make b_pages[] array in struct buf flexible.  Size b_pages[] for buffer
cache buffers exactly to atop(maxbcachebuf) (currently it is sized to
atop(MAXPHYS)), and b_pages[] for pbufs is sized to atop(maxphys) + 1.
The +1 for pbufs allow several pbuf consumers, among them vmapbuf(),
to use unaligned buffers still sized to maxphys, esp. when such
buffers come from userspace (*).  Overall, we save significant amount
of otherwise wasted memory in b_pages[] for buffer cache buffers,
while bumping MAXPHYS to desired high value.

Eliminate all direct uses of the MAXPHYS constant in kernel and driver
sources, except a place which initialize maxphys.  Some random (and
arguably weird) uses of MAXPHYS, e.g. in linuxolator, are converted
straight.  Some drivers, which use MAXPHYS to size embeded structures,
get private MAXPHYS-like constant; their convertion is out of scope
for this work.

Changes to cam/, dev/ahci, dev/ata, dev/mpr, dev/mpt, dev/mvs,
dev/siis, where either submitted by, or based on changes by mav.

Suggested by: mav (*)
Reviewed by:	imp, mav, imp, mckusick, scottl (intermediate versions)
Tested by:	pho
Sponsored by:	The FreeBSD Foundation
Differential revision:	https://reviews.freebsd.org/D27225