src/sys/dev/sym, branch upstream/11.1.0 FreeBSD source tree MFC r311305 (by asomers): 2017-03-23T06:40:20+00:00 Alexander Motin mav@FreeBSD.org 2017-03-23T06:40:20+00:00 6352900b3df2d8e5409dbf52d6b3d6c494817605 Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name) The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are fixed-length strings. AFAICT the only place they're read is in sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated. However, the kernel doesn't null-terminate them. A bunch of copy-pasted code uses strncpy to write them, and doesn't guarantee null-termination. For at least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually overflows. You can see the result by doing "camcontrol negotiate da0 -v". This change null-terminates those fields everywhere they're set in the kernel. It also shortens a few strings to ensure they'll fit within the 16-character field. PR: 215474 Reported by: Coverity CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005 CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000 CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014 CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021 CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027 CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187 CID: 1010035 1010036 1010042 1010041 1010040 1010039 
Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
fixed-length strings. AFAICT the only place they're read is in
sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
uses strncpy to write them, and doesn't guarantee null-termination. For at
least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
overflows. You can see the result by doing "camcontrol negotiate da0 -v".

This change null-terminates those fields everywhere they're set in the
kernel. It also shortens a few strings to ensure they'll fit within the
16-character field.

PR:		215474
Reported by:    Coverity
CID:            1009997 1010000 1010001 1010002 1010003 1010004 1010005
CID:            1331519 1010006 1215097 1010007 1288967 1010008 1306000
CID:            1211924 1010009 1010010 1010011 1010012 1010013 1010014
CID:            1147190 1010017 1010016 1010018 1216435 1010020 1010021
CID:            1010022 1009666 1018185 1010023 1010025 1010026 1010027
CID:            1010028 1010029 1010030 1010031 1010033 1018186 1018187
CID:            1010035 1010036 1010042 1010041 1010040 1010039
MFC r313982, r314068: 2017-03-14T02:06:03+00:00 Pedro F. Giffuni pfg@FreeBSD.org 2017-03-14T02:06:03+00:00 bd0faecc931277934a72772a410ede5663969cdb sys: Replace zero with NULL for pointers. Found with: devel/coccinelle 
sys: Replace zero with NULL for pointers.

Found with:	devel/coccinelle
MFC r313949: Remove dead mentions of CAM target mode APIs from drivers. 2017-02-28T06:46:41+00:00 Alexander Motin mav@FreeBSD.org 2017-02-28T06:46:41+00:00 f7378b0367fdc1a615fc5d04dddc1adb86b94874 This makes grepping kernel for target mode implementation much easier. 
This makes grepping kernel for target mode implementation much easier.
Add a riscv define. 2016-06-01T14:03:13+00:00 Ruslan Bukin br@FreeBSD.org 2016-06-01T14:03:13+00:00 b217eb93142e25b683c97f1e230aa10c5bf1ed80 Submitted by: Yukishige Shibata <y-shibat@mtd.biglobe.ne.jp> 
Submitted by:	Yukishige Shibata <y-shibat@mtd.biglobe.ne.jp>
Fix a bug in r298340: "sim" was referenced after being unset. 2016-05-13T20:54:54+00:00 Mark Johnston markj@FreeBSD.org 2016-05-13T20:54:54+00:00 ce59ff90af4617beb803cdd6f463dd6a4a3d9cb8 






sys/dev: minor spelling fixes.
2016-05-03T03:41:25+00:00

Pedro F. Giffuni
pfg@FreeBSD.org

2016-05-03T03:41:25+00:00

453130d9bfc1c6d68b366dfcb041689d69f81295

Most affect comments, very few have user-visible effects.





Most affect comments, very few have user-visible effects.







sys/dev: extend use of the howmany() macro when available.
2016-04-26T15:03:15+00:00

Pedro F. Giffuni
pfg@FreeBSD.org

2016-04-26T15:03:15+00:00

057b4402bf634907fd03590e2757e09e975d04c7

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.





We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.







sys: use our roundup2/rounddown2() macros when param.h is available.
2016-04-21T19:57:40+00:00

Pedro F. Giffuni
pfg@FreeBSD.org

2016-04-21T19:57:40+00:00

d9c9c81c083a76a65c6cacf8fcbc0511e2ffa489

rounddown2 tends to produce longer lines than the original code
and when the code has a high indentation level it was not really
advantageous to do the replacement.

This tries to strike a balance between readability using the macros
and flexibility of having the expressions, so not everything is
converted.





rounddown2 tends to produce longer lines than the original code
and when the code has a high indentation level it was not really
advantageous to do the replacement.

This tries to strike a balance between readability using the macros
and flexibility of having the expressions, so not everything is
converted.







sym(4): Don't double-free 'sim' in failure case
2016-04-20T05:13:36+00:00

Conrad Meyer
cem@FreeBSD.org

2016-04-20T05:13:36+00:00

26b5a97a27a2f16512197d3618b5874d183736f4

Reported by:	Coverity
CID:		1006106
Sponsored by:	EMC / Isilon Storage Division





Reported by:	Coverity
CID:		1006106
Sponsored by:	EMC / Isilon Storage Division







Cleanup unnecessary semicolons from the kernel.
2016-04-10T23:07:00+00:00

Pedro F. Giffuni
pfg@FreeBSD.org

2016-04-10T23:07:00+00:00

74b8d63dcc17c07d8cb21e13f6db517698efd49f

Found with devel/coccinelle.





Found with devel/coccinelle.