src/sys/dev/virtio/network, branch releng/13.0

vtnet: fix TSO for TCP/IPv6

2021-03-18T20:35:49+00:00

The decision whether a TCP packet is sent over IPv4 or IPv6 was
based on ethertype, which works correctly. In D27926 the criteria
was changed to checking if the CSUM_IP_TSO flag is set in the
csum-flags and then considering it to be TCP/IPv4.
However, the TCP stack sets the flag to CSUM_TSO for IPv4 and IPv6,
where CSUM_TSO is defined as CSUM_IP_TSO|CSUM_IP6_TSO.
Therefore TCP/IPv6 packets gets mis-classified as TCP/IPv4,
which breaks TSO for TCP/IPv6.
This patch bases the check again on the ethertype.
This fix is instantly MFCed.

Approved by:		re(gjb)
PR:			254366
Sponsored by:		Netflix, Inc.
Differential Revision:	https://reviews.freebsd.org/D29331

(cherry picked from commit d4697a6b56168876fc0ffec1a0bb1b24d25b198e)
(cherry picked from commit 6064ea8172f078c54954bc6e8865625feb7979fe)

virtio: Reduce boilerplate for device driver module definitions

2021-01-21T01:07:23+00:00

Rather than have every device register itself for both virtio_pci and
virtio_mmio, provide a VIRTIO_DRIVER_MODULE wrapper to declare both,
merge VIRTIO_SIMPLE_PNPTABLE with VIRTIO_SIMPLE_PNPINFO and make the
latter register for both buses. This also has the benefit of abstracting
away the available transports and their names.

Reviewed by:	bryanv
Differential Revision:	https://reviews.freebsd.org/D28073

virtio: Handle possible failure of virtio_finalize_features()

2021-01-19T04:55:26+00:00

Try to standardize how drivers negotiate feature and the
function names

Reviewed by: grehan (mentor)
Differential Revision: https://reviews.freebsd.org/D27930

if_vtnet: Add counter for received host LRO

2021-01-19T04:55:26+00:00

Reviewed by: grehan (mentor)
Differential Revision: https://reviews.freebsd.org/D27928

if_vtnet: Misc Tx path cleanup

2021-01-19T04:55:26+00:00

  - Add and fix a few error path counters
  - Improve sysctl descriptions
  - Use flags consistently to determine IPv4 vs IPv6

Reviewed by: grehan (mentor)
Differential Revision: https://reviews.freebsd.org/D27926

if_vtnet: Set lro_nsegs for host LRO packets

2021-01-19T04:55:25+00:00

Reviewed by: grehan (mentor)
Differential Revision: https://reviews.freebsd.org/D27933

if_vtnet: Resort softc fields

2021-01-19T04:55:25+00:00

Reviewed by: grehan (mentor)
Differential Revision: https://reviews.freebsd.org/D27925

if_vtnet: Remove unnecessary TUNABLE_INTs because of CTLFLAG_RDTUN

2021-01-19T04:55:25+00:00

Reviewed by: grehan (mentor)
Differential Revision: https://reviews.freebsd.org/D27923

if_vtnet: Schedule Rx task if pending items when enabling interrupt

2021-01-19T04:55:25+00:00

Prior to V1, the driver would enable interrupts and then notify the
host that DRIVER_OK. Since for V1, DRIVER_OK needs to be set before
notifying the virtqueues, there may be items in the queues waiting
to be processed by the time interrupts are enabled.

This fixes a bug where the Rx queue would appear stuck, only being
usable after an interface down/up cycle.

Reviewed by: grehan (mentor)
Differential Revision: https://reviews.freebsd.org/D27922

if_vtnet: Disable F_MTU feature if MTU is invalid

2021-01-19T04:55:25+00:00

Reviewed by: grehan (mentor)
Differential Revision: https://reviews.freebsd.org/D27931