src/sys/dev/vkbd, branch releng/8.0 FreeBSD source tree Remove unit2minor() use from kernel code. 2008-09-26T14:19:52+00:00 Ed Schouten ed@FreeBSD.org 2008-09-26T14:19:52+00:00 d3ce8327194c0bcf742f2e03b5b0dc8f8cfe7f6b When I changed kern_conf.c three months ago I made device unit numbers equal to (unneeded) device minor numbers. We used to require bitshifting, because there were eight bits in the middle that were reserved for a device major number. Not very long after I turned dev2unit(), minor(), unit2minor() and minor2unit() into macro's. The unit2minor() and minor2unit() macro's were no-ops. We'd better not remove these four macro's from the kernel, because there is a lot of (external) code that may still depend on them. For now it's harmless to remove all invocations of unit2minor() and minor2unit(). Reviewed by: kib 
When I changed kern_conf.c three months ago I made device unit numbers
equal to (unneeded) device minor numbers. We used to require
bitshifting, because there were eight bits in the middle that were
reserved for a device major number. Not very long after I turned
dev2unit(), minor(), unit2minor() and minor2unit() into macro's.
The unit2minor() and minor2unit() macro's were no-ops.

We'd better not remove these four macro's from the kernel, because there
is a lot of (external) code that may still depend on them. For now it's
harmless to remove all invocations of unit2minor() and minor2unit().

Reviewed by:	kib
Don't enforce unique device minor number policy anymore. 2008-06-11T18:55:19+00:00 Ed Schouten ed@FreeBSD.org 2008-06-11T18:55:19+00:00 29d4cb241b5b8d786221402075febdb832fea55a Except for the case where we use the cloner library (clone_create() and friends), there is no reason to enforce a unique device minor number policy. There are various drivers in the source tree that allocate unr pools and such to provide minor numbers, without using them themselves. Because we still need to support unique device minor numbers for the cloner library, introduce a new flag called D_NEEDMINOR. All cdevsw's that are used in combination with the cloner library should be marked with this flag to make the cloning work. This means drivers can now freely use si_drv0 to store their own flags and state, making it effectively the same as si_drv1 and si_drv2. We still keep the minor() and dev2unit() routines around to make drivers happy. The NTFS code also used the minor number in its hash table. We should not do this anymore. If the si_drv0 field would be changed, it would no longer end up in the same list. Approved by: philip (mentor) 
Except for the case where we use the cloner library (clone_create() and
friends), there is no reason to enforce a unique device minor number
policy. There are various drivers in the source tree that allocate unr
pools and such to provide minor numbers, without using them themselves.

Because we still need to support unique device minor numbers for the
cloner library, introduce a new flag called D_NEEDMINOR. All cdevsw's
that are used in combination with the cloner library should be marked
with this flag to make the cloning work.

This means drivers can now freely use si_drv0 to store their own flags
and state, making it effectively the same as si_drv1 and si_drv2. We
still keep the minor() and dev2unit() routines around to make drivers
happy.

The NTFS code also used the minor number in its hash table. We should
not do this anymore. If the si_drv0 field would be changed, it would no
longer end up in the same list.

Approved by:	philip (mentor)
Remove explicit calls to keyboard methods with their respective variants 2007-12-29T21:55:25+00:00 Wojciech A. Koszek wkoszek@FreeBSD.org 2007-12-29T21:55:25+00:00 259699b294163f99205912e9e2ffcd59d1fbf9b8 implemented with macros. This patch improves code readability. Reasoning behind kbdd_* is a "keyboard discipline". List of macros is supposed to be complete--all methods of keyboard_switch should have their respective macros from now on. Functionally, this code should be no-op. My intention is to leave current behaviour of code as is. Glanced at by: rwatson Reviewed by: emax, marcel Approved by: cognet 
implemented with macros. This patch improves code readability. Reasoning
behind kbdd_* is a "keyboard discipline".

List of macros is supposed to be complete--all methods of keyboard_switch
should have their respective macros from now on.

Functionally, this code should be no-op. My intention is to leave current
behaviour of code as is.

Glanced at by:	rwatson
Reviewed by:	emax, marcel
Approved by:	cognet
Fix our ioctl(2) implementation when the argument is "int". New 2006-09-27T19:57:02+00:00 Ruslan Ermilov ru@FreeBSD.org 2006-09-27T19:57:02+00:00 9fddcc6661d2cf7bb8e704308437d2b1674b50be ioctls passing integer arguments should use the _IOWINT() macro. This fixes a lot of ioctl's not working on sparc64, most notable being keyboard/syscons ioctls. Full ABI compatibility is provided, with the bonus of fixing the handling of old ioctls on sparc64. Reviewed by: bde (with contributions) Tested by: emax, marius MFC after: 1 week 
ioctls passing integer arguments should use the _IOWINT() macro.
This fixes a lot of ioctl's not working on sparc64, most notable
being keyboard/syscons ioctls.

Full ABI compatibility is provided, with the bonus of fixing the
handling of old ioctls on sparc64.

Reviewed by:	bde (with contributions)
Tested by:	emax, marius
MFC after:	1 week
Disable custom locking in the vkbd(4) for now and make it rely on the 2006-02-27T06:17:48+00:00 Maksim Yevmenkin emax@FreeBSD.org 2006-02-27T06:17:48+00:00 0722466d60a744570b22bb4f041aabeeac3907e7 Giant mutex (just like the rest of keyboard drivers and syscons(4) do). Tested by: markus MFC after: 1 day 
Giant mutex (just like the rest of keyboard drivers and syscons(4) do).

Tested by:	markus
MFC after:	1 day
Merge the dev_clone and dev_clone_cred event handlers into a single 2005-08-08T19:55:32+00:00 Robert Watson rwatson@FreeBSD.org 2005-08-08T19:55:32+00:00 6a113b3de785c1852adc7ec1bc80413c4e26c8f7 event handler, dev_clone, which accepts a credential argument. Implementors of the event can ignore it if they're not interested, and most do. This avoids having multiple event handler types and fall-back/precedence logic in devfs. This changes the kernel API for /dev cloning, and may affect third party packages containg cloning kernel modules. Requested by: phk MFC after: 3 days 
event handler, dev_clone, which accepts a credential argument.
Implementors of the event can ignore it if they're not interested,
and most do.  This avoids having multiple event handler types and
fall-back/precedence logic in devfs.

This changes the kernel API for /dev cloning, and may affect third
party packages containg cloning kernel modules.

Requested by:	phk
MFC after:	3 days
Fix kernel panic with vkbd(4). Initialize mutex properly (set name), or else 2005-07-21T16:19:08+00:00 Maksim Yevmenkin emax@FreeBSD.org 2005-07-21T16:19:08+00:00 6502441272b3a795c2aadff47851a85a6057e406 WITNESS gets upset. MFC after: 3 days 
WITNESS gets upset.

MFC after:	3 days
Fix yet another cut-and-paste bug. 2005-05-20T23:29:55+00:00 Maksim Yevmenkin emax@FreeBSD.org 2005-05-20T23:29:55+00:00 4f39f90f5fded47a08371e39febd135ad593bc32 kbd was allocated from M_VKBD not from M_DEVBUF 
kbd was allocated from M_VKBD not from M_DEVBUF
Dont clear all flags in vkbd_clear_state_locked(). Clear only COMPOSE flag. 2005-05-16T17:21:10+00:00 Maksim Yevmenkin emax@FreeBSD.org 2005-05-16T17:21:10+00:00 b4b485a5d83a626184c4a45f0cc4490580b4bfab MFC after: 3 days 
MFC after:	3 days
Explicitly hold a reference to the cdev we have just cloned. This 2005-03-31T12:19:44+00:00 Poul-Henning Kamp phk@FreeBSD.org 2005-03-31T12:19:44+00:00 f4f6abcb4ea1f4c91714febe157d0eaaf3e236ec closes the race where the cdev was reclaimed before it ever made it back to devfs lookup. 
closes the race where the cdev was reclaimed before it ever made it
back to devfs lookup.