src/sys/dev/xen, branch stable/10

MFC r314148, r314150

2017-05-30T16:15:52+00:00

r314148:
Misc Coverity fixes in xnb(4)

Most of these are null pointer dereferences or missing error checks in the
unit tests. One is a missing error check in xnb_attach_failed. None can
cause real problems in running systems.

Reported by:	Coverity
CIDs:		1092469 1092468 1092467 2092466 1092465 1092512 1092511 1092510
CIDs:		1092510 1092509 1092508 1092507
Reviewed by:	royger
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D9234

r314150:
Fix the xnb(4) unit tests

One test was inadvertently expecting a bug in the kernel's sscanf
implementation circa 2012. I don't know when that bug got fixed.

Reported by:	royger
Reviewed by:	royger
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D9766

Fix -Wformat issue with r316140, which broke i386/GENERIC

2017-03-29T17:11:41+00:00

Since r316140 was a direct commit to ^/stable/10, this too is a direct commit
to ^/stable/10.

Reported by:	Jenkins (FreeBSD-stable-10-i386-build job)
Tested with:	amd64, i386
Sponsored by:	Dell EMC Isilon

xen/netfront: release resources on removal

2017-03-29T15:34:52+00:00

Current netfront code doesn't release the resources (grants and mbufs) on
removal. Add a new helper that releases the resources, so FreeBSD doesn't run
out of grants or memory when performing heavy hotplug/unplug of Xen PV nic
devices.

This is a direct commit to stable/10 because the code in newer branches has
been completely refactored and no longer has this issue.

Reviewed by:		royger
Submitted by:		Ouyangzhaowei 
Differential review:	https://reviews.freebsd.org/D10088

MFC r314840:

2017-03-21T09:38:59+00:00

xen: add support for canceled suspend

Submitted by:	Liuyingdong 
Reviewed by:	royger

MFC r314841:

2017-03-21T09:27:24+00:00

xenstore: fix suspension when using the xenstore device

Submitted by:	Liuyingdong 
Reviewed by:	royger

MFC r283291: don't use CALLOUT_MPSAFE with callout_init()

2017-03-04T13:03:31+00:00

The main purpose of this MFC is to reduce conflicts for other merges.
Parts of the original change have already "trickled down" via individual MFCs.

MFC r310013 (by cperciva):

2016-12-18T14:31:11+00:00

Check that blkfront devices have a non-zero number of sectors and a
non-zero sector size.  Such a device would be a virtual disk of zero
bytes; clearly not useful, and not something we should try to attach.

As a fortuitous side effect, checking that these values are non-zero
here results in them not *becoming* zero later on the function.  This
odd behaviour began with r309124 (clang 3.9.0) but is challenging to
debug; making any changes to this function whatsoever seems to affect
the llvm optimizer behaviour enough to make the unexpected zeroing of
the sector_size variable cease.

PR:		215209
Security:	The potential for variables to unexpectedly become zero
		has worrying consequences for security in general, but
		not so much in this particular context.

MFC r310086:

In xbd_connect(), use correct scanf conversion specifiers for the
feature_barrier and feature_flush variables.  Otherwise, adjacent
variables on the stack, such as sector_size, may be overwritten, with
disastrous results.

Note that I did not see a good reason to revert the addition of zero
checks introduced in r310013.  Better safe than sorry.

PR:		215209
Tested by:	royger

MFC r297522: Pass through some new block device features.

2016-05-03T07:52:06+00:00

MFC r267858:

2015-12-30T08:15:43+00:00

xen/virtio: fix balloon drivers to not mark pages as WIRED

In the Xen case make sure pages are zeroed before giving them back to the
hypervisor, or else we might be leaking data. Also remove the
balloon_{append/retrieve} and link pages directly into the ballooned_pages
queue using the plinks.q field in the page struct.

Sponsored by:	Citrix Systems R&D
Requested by:	bapt

MFC r291024:

2015-12-03T11:05:35+00:00

xen: fix dropping bitmap IPIs during resume

Sponsored by:		Citrix Systems R&D