src/sys/netinet/netdump, branch main

netdump: Check the return value of ifunit_ref()

2023-10-02T12:09:26+00:00

We may fail to match if the specific interface doesn't exist or was
renamed.

PR:		273715
Reported by:	grembo
MFC after:	1 week

sys: Remove $FreeBSD$: one-line .c pattern

2023-08-16T17:54:36+00:00

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

sys: Remove $FreeBSD$: two-line .h pattern

2023-08-16T17:54:11+00:00

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

IfAPI: Explicitly include in netstack

2023-01-31T20:02:16+00:00

Summary:
In preparation of making if_t completely opaque outside of the netstack,
explicitly include the header.   will stop including the
header in the future.

Sponsored by:	Juniper Networks, Inc.
Reviewed by:	glebius, melifaro
Differential Revision: https://reviews.freebsd.org/D38200

netdump(4): Correct a typo in source code comment

2022-09-04T10:59:29+00:00

- s/occured/occurred/

MFC after:	3 days

ddb: use _FLAGS command macros where appropriate

2022-07-05T14:56:55+00:00

Some command definitions were forced to use DB_FUNC in order to specify
their required flags, CS_OWN or CS_MORE. Use the new macros to simplify
these.

Reviewed by:	markj, jhb
MFC after:	3 days
Sponsored by:	Juniper Networks, Inc.
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D35582

netdump: check the support status of the interface

2022-05-14T13:27:53+00:00

If the interface does not support debugnet(4) we should bail early,
rather than having the user find this out at the time of the panic.
dumpon(8) already expects this return value and will print a helpful
error message.

Reviewed by:	cem, markj
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D35180

kerneldump: remove physical argument from d_dumper

2022-05-13T13:42:48+00:00

The physical address argument is essentially ignored by every dumper
method. In addition, the dump routines don't actually pass a real
address; every call to dump_append() passes a value of zero for
physical.

Reviewed by:	markj
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D35173

Remove 12.x ABI compat for kernel dump ioctls

2022-04-15T15:06:05+00:00

This code was marked gone_in(14), so it can now be removed.

The only consumer of this interface is dumpon(8). We do not maintain
strict backwards compatibility for this utility because a) it
can't/shouldn't be used from a jail or chroot and b) it is highly
specific interface unique to FreeBSD. The host's (presumably more
up-to-date) copy of dumpon(8) should be used to configure kernel dump
devices.

Reviewed by:	markj, emaste
MFC after:	never
Differential Revision:	https://reviews.freebsd.org/D34914

Remove 11.x ABI compat for kernel dump ioctls

2022-04-15T15:06:04+00:00

This code was marked gone_in(13), so its time has passed.

The only consumer of this interface is dumpon(8). We do not maintain
strict backwards compatibility for this utility because a) it
can't/shouldn't be used from a jail or chroot and b) it is highly
specific interface unique to FreeBSD. The host's (presumably more
up-to-date) copy of dumpon(8) should be used to configure kernel dump
devices.

Reviewed by:	markj, emaste
MFC after:	3 days
Differential Revision:	https://reviews.freebsd.org/D34913