src/sys/netinet/tcp_usrreq.c, branch release/5.3.0_cvs FreeBSD source tree This commit was manufactured by cvs2svn to create tag 2004-11-04T19:12:42+00:00 cvs2svn cvs2svn@FreeBSD.org 2004-11-04T19:12:42+00:00 3f86d8a2ea3f3265afaa1fd263b0004c5c000e69 'RELENG_5_3_0_RELEASE'. This commit was manufactured to restore the state of the 5.3-RELEASE image. 
'RELENG_5_3_0_RELEASE'.

This commit was manufactured to restore the state of the 5.3-RELEASE image.
White space cleanup for netinet before branch: 2004-08-16T18:32:07+00:00 Robert Watson rwatson@FreeBSD.org 2004-08-16T18:32:07+00:00 a4f757cd5dc1421d90d72a34853247e0c2c18cce - Trailing tab/space cleanup - Remove spurious spaces between or before tabs This change avoids touching files that Andre likely has in his working set for PFIL hooks changes for IPFW/DUMMYNET. Approved by: re (scottl) Submitted by: Xin LI <delphij@frontfree.net> 
- Trailing tab/space cleanup
- Remove spurious spaces between or before tabs

This change avoids touching files that Andre likely has in his working
set for PFIL hooks changes for IPFW/DUMMYNET.

Approved by:	re (scottl)
Submitted by:	Xin LI <delphij@frontfree.net>
Get rid of the RANDOM_IP_ID option and make it a sysctl. NetBSD 2004-08-14T15:32:40+00:00 David Malone dwmalone@FreeBSD.org 2004-08-14T15:32:40+00:00 1f44b0a1b539198ce55bf97e73d51ded20a55ab4 have already done this, so I have styled the patch on their work: 1) introduce a ip_newid() static inline function that checks the sysctl and then decides if it should return a sequential or random IP ID. 2) named the sysctl net.inet.ip.random_id 3) IPv6 flow IDs and fragment IDs are now always random. Flow IDs and frag IDs are significantly less common in the IPv6 world (ie. rarely generated per-packet), so there should be smaller performance concerns. The sysctl defaults to 0 (sequential IP IDs). Reviewed by: andre, silby, mlaier, ume Based on: NetBSD MFC after: 2 months 
have already done this, so I have styled the patch on their work:

        1) introduce a ip_newid() static inline function that checks
        the sysctl and then decides if it should return a sequential
        or random IP ID.

        2) named the sysctl net.inet.ip.random_id

        3) IPv6 flow IDs and fragment IDs are now always random.
        Flow IDs and frag IDs are significantly less common in the
        IPv6 world (ie. rarely generated per-packet), so there should
        be smaller performance concerns.

The sysctl defaults to 0 (sequential IP IDs).

Reviewed by:	andre, silby, mlaier, ume
Based on:	NetBSD
MFC after:	2 months
compare pointer against NULL, not 0 2004-07-26T21:29:56+00:00 John-Mark Gurney jmg@FreeBSD.org 2004-07-26T21:29:56+00:00 0aa8ce5012b1efda43ae6bba078ca6a70e46673c when inpcb is NULL, this is no longer invalid since jlemon added the tcp_twstart function... this prevents close "failing" w/ EINVAL when it really was successful... Reviewed by: jeremy (NetBSD) 
when inpcb is NULL, this is no longer invalid since jlemon added the
tcp_twstart function... this prevents close "failing" w/ EINVAL when it
really was successful...

Reviewed by:	jeremy (NetBSD)
when IN6P_AUTOFLOWLABEL is set, the flowlabel is not set on 2004-07-16T18:08:13+00:00 Hajimu UMEMOTO ume@FreeBSD.org 2004-07-16T18:08:13+00:00 8a59da300c504e8912eb08442b9ae184b89ce455 outgoing tcp connections. Reported by: Orla McGann <orly@cnri.dit.ie> Reviewed by: Orla McGann <orly@cnri.dit.ie> Obtained from: KAME 
outgoing tcp connections.

Reported by:	Orla McGann <orly@cnri.dit.ie>
Reviewed by:	Orla McGann <orly@cnri.dit.ie>
Obtained from:	KAME
Remove spl's from TCP protocol entry points. While not all locking 2004-06-26T17:50:50+00:00 Robert Watson rwatson@FreeBSD.org 2004-06-26T17:50:50+00:00 3f9d1ef905eb87fabafac78f96a4dd99f269e0ef is merged here yet, this will ease the merge process by bringing the locked and unlocked versions into sync. 
is merged here yet, this will ease the merge process by bringing the
locked and unlocked versions into sync.
In tcp_ctloutput(), don't hold the inpcb lock over a call to 2004-06-18T20:22:21+00:00 Robert Watson rwatson@FreeBSD.org 2004-06-18T20:22:21+00:00 4e397bc5248408c7fa6aba7431d6c70b58183a7b ip_ctloutput(), as it may need to perform blocking memory allocations. This also improves consistency with locking relative to other points that call into ip_ctloutput(). Bumped into by: Grover Lines <grover@ceribus.net> 
ip_ctloutput(), as it may need to perform blocking memory allocations.
This also improves consistency with locking relative to other points
that call into ip_ctloutput().

Bumped into by:	Grover Lines <grover@ceribus.net>
The socket field so_state is used to hold a variety of socket related 2004-06-14T18:16:22+00:00 Robert Watson rwatson@FreeBSD.org 2004-06-14T18:16:22+00:00 c0b99ffa021c0be74d6ab90a6eccfe511be8bb19 flags relating to several aspects of socket functionality. This change breaks out several bits relating to send and receive operation into a new per-socket buffer field, sb_state, in order to facilitate locking. This is required because, in order to provide more granular locking of sockets, different state fields have different locking properties. The following fields are moved to sb_state: SS_CANTRCVMORE (so_state) SS_CANTSENDMORE (so_state) SS_RCVATMARK (so_state) Rename respectively to: SBS_CANTRCVMORE (so_rcv.sb_state) SBS_CANTSENDMORE (so_snd.sb_state) SBS_RCVATMARK (so_rcv.sb_state) This facilitates locking by isolating fields to be located with other identically locked fields, and permits greater granularity in socket locking by avoiding storing fields with different locking semantics in the same short (avoiding locking conflicts). In the future, we may wish to coallesce sb_state and sb_flags; for the time being I leave them separate and there is no additional memory overhead due to the packing/alignment of shorts in the socket buffer structure. 
flags relating to several aspects of socket functionality.  This change
breaks out several bits relating to send and receive operation into a
new per-socket buffer field, sb_state, in order to facilitate locking.
This is required because, in order to provide more granular locking of
sockets, different state fields have different locking properties.  The
following fields are moved to sb_state:

  SS_CANTRCVMORE            (so_state)
  SS_CANTSENDMORE           (so_state)
  SS_RCVATMARK              (so_state)

Rename respectively to:

  SBS_CANTRCVMORE           (so_rcv.sb_state)
  SBS_CANTSENDMORE          (so_snd.sb_state)
  SBS_RCVATMARK             (so_rcv.sb_state)

This facilitates locking by isolating fields to be located with other
identically locked fields, and permits greater granularity in socket
locking by avoiding storing fields with different locking semantics in
the same short (avoiding locking conflicts).  In the future, we may
wish to coallesce sb_state and sb_flags; for the time being I leave
them separate and there is no additional memory overhead due to the
packing/alignment of shorts in the socket buffer structure.
Remove advertising clause from University of California Regent's 2004-04-07T20:46:16+00:00 Warner Losh imp@FreeBSD.org 2004-04-07T20:46:16+00:00 f36cfd49adb62472fd7009ecd4f0927c126ff785 license, per letter dated July 22, 1999 and email from Peter Wemm, Alan Cox and Robert Watson. Approved by: core, peter, alc, rwatson 
license, per letter dated July 22, 1999 and email from Peter Wemm,
Alan Cox and Robert Watson.

Approved by: core, peter, alc, rwatson
Fix a panic possibility caused by returning without releasing locks. 2004-04-04T20:14:55+00:00 Pawel Jakub Dawidek pjd@FreeBSD.org 2004-04-04T20:14:55+00:00 52710de1cbf22f18044f9a9180955a2313009df5 It was fixed by moving problemetic checks, as well as checks that doesn't need locking before locks are acquired. Submitted by: Ryan Sommers <ryans@gamersimpact.com> In co-operation with: cperciva, maxim, mlaier, sam Tested by: submitter (previous patch), me (current patch) Reviewed by: cperciva, mlaier (previous patch), sam (current patch) Approved by: sam Dedicated to: enough! 
It was fixed by moving problemetic checks, as well as checks that
doesn't need locking before locks are acquired.

Submitted by:		Ryan Sommers <ryans@gamersimpact.com>
In co-operation with:	cperciva, maxim, mlaier, sam
Tested by:		submitter (previous patch), me (current patch)
Reviewed by:		cperciva, mlaier (previous patch), sam (current patch)
Approved by:		sam
Dedicated to:		enough!