src/sys/opencrypto/cryptodev.c, branch release/5.3.0_cvs

This commit was manufactured by cvs2svn to create tag

2004-11-04T19:12:42+00:00

'RELENG_5_3_0_RELEASE'.

This commit was manufactured to restore the state of the 5.3-RELEASE image.

Don't acquire Giant in cryptof_close(), as the code is intended to be

2004-08-10T03:26:17+00:00

able to run MPsafe (and appears to be MPsafe).

Discussed with (some time ago):	sam

Push acquisition of Giant from fdrop_closed() into fo_close() so that

2004-07-22T18:35:43+00:00

individual file object implementations can optionally acquire Giant if
they require it:

- soo_close(): depends on debug.mpsafenet
- pipe_close(): Giant not acquired
- kqueue_close(): Giant required
- vn_close(): Giant required
- cryptof_close(): Giant required (conservative)

Notes:

  Giant is still acquired in close() even when closing MPSAFE objects
  due to kqueue requiring Giant in the calling closef() code.
  Microbenchmarks indicate that this removal of Giant cuts 3%-3% off
  of pipe create/destroy pairs from user space with SMP compiled into
  the kernel.

  The cryptodev and opencrypto code appears MPSAFE, but I'm unable to
  test it extensively and so have left Giant over fo_close().  It can
  probably be removed given some testing and review.

Do the dreaded s/dev_t/struct cdev */

2004-06-16T09:47:26+00:00

Bump __FreeBSD_version accordingly.

add missing #include

2004-05-30T20:27:19+00:00

Device megapatch 4/6:

2004-02-21T21:10:55+00:00

Introduce d_version field in struct cdevsw, this must always be
initialized to D_VERSION.

Flip sense of D_NOGIANT flag to D_NEEDGIANT, this involves removing
four D_NOGIANT flags and adding 145 D_NEEDGIANT flags.

eliminate an unnecessary 8Kbyte bzero that was being done for each

2003-11-19T22:42:34+00:00

submitted operation

Submitted by:	Thor Lancelot Simon
Reviewed by:	jhb
Approved by:	re (jhb)

falloc allocates a file structure and adds it to the file descriptor

2003-10-19T20:41:07+00:00

table, acquiring the necessary locks as it works. It usually returns
two references to the new descriptor: one in the descriptor table
and one via a pointer argument.

As falloc releases the FILEDESC lock before returning, there is a
potential for a process to close the reference in the file descriptor
table before falloc's caller gets to use the file. I don't think this
can happen in practice at the moment, because Giant indirectly protects
closes.

To stop the file being completly closed in this situation, this change
makes falloc set the refcount to two when both references are returned.
This makes life easier for several of falloc's callers, because the
first thing they previously did was grab an extra reference on the
file.

Reviewed by:	iedowse
Idea run past:	jhb

The present defaults for the open and close for device drivers which

2003-09-27T12:01:01+00:00

provide no methods does not make any sense, and is not used by any
driver.

It is a pretty hard to come up with even a theoretical concept of
a device driver which would always fail open and close with ENODEV.

Change the defaults to be nullopen() and nullclose() which simply
does nothing.

Remove explicit initializations to these from the drivers which
already used them.

Initialize struct fileops with C99 sparse initialization.

2003-06-18T18:16:40+00:00