FreeBSD source tree http://cgit.freebsd.org/src/atom?h=main 2025-06-24T22:29:03Z 2025-06-24T22:29:03Z Gleb Smirnoff glebius@FreeBSD.org 2025-06-24T22:28:07Z urn:sha1:994bec47ee7f38bd20366b812313b2ea0714ef19 The test arms timer for 500 msec and then sleeps 1 second and expects that the timer would always fire exactly 2 times. However, it has a chance to legitimately fire only once. This makes the test flaky. Fix the test reducing sleep time down to 495 msec. The problem started to show up recently, and I attribute that to 626ea75ed2e9. Before this revision sleep(3) was almost always sleeping over 1000 msec, now it can sleep exactly 1000 msec. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D50996 2023-08-16T17:54:16Z Warner Losh imp@FreeBSD.org 2023-08-16T17:54:16Z urn:sha1:b3e7694832e81d7a904a10f525f8797b753bf0d3 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ 2022-05-25T00:16:32Z Mark Johnston markj@FreeBSD.org 2022-05-25T00:16:32Z urn:sha1:d6d4f9b45e0be306bdaf53b2133b2cd0f7642167 One of the tests exposes the regression reported in PR 264131. One test is disabled because FreeBSD does not support setting EV_ONESHOT on an already-added periodic timer. Though, in this case the flag is simply ignored, which isn't ideal. One test is slightly modified to set EV_ADD when reconfiguring a disabled timer per some commentary in PR 258412. Ideally we would re-import the test suite from libkqueue but there is a fair bit of divergence so this will require some effort. This just gets us one small step closer while increasing test coverage. PR: 258412 MFC after: 2 weeks Sponsored by: The FreeBSD Foundation 2021-10-01T18:17:30Z Kyle Evans kevans@FreeBSD.org 2021-10-01T16:59:31Z urn:sha1:2f4dbe279f6b5eb87ec493d96f6943ffdb603ba0 NOTE_ABSTIME may also have a zero timeout, which indicates that we should still fire immediately as an absolute time in the past. A test has been added for this one as well. Fixes: 9c999a259f00 ("kqueue: don't arbitrarily restrict long-past...") Point hat: kevans Reported by: syzbot+1c8d1154f560b3930042@syzkaller.appspotmail.com 2021-10-01T02:31:24Z Kyle Evans kevans@FreeBSD.org 2021-09-29T19:55:59Z urn:sha1:9c999a259f00b35f0467acd351fea9157ed7e1e4 NOTE_ABSTIME values are converted to values relative to boottime in filt_timervalidate(), and negative values are currently rejected. We don't reject times in the past in general, so clamp this up to 0 as needed such that the timer fires immediately rather than imposing what looks like an arbitrary restriction. Another possible scenario is that the system clock had to be adjusted by ~minutes or ~hours and we have less than that in terms of uptime, making a reasonable short-timeout suddenly invalid. Firing it is still a valid choice in this scenario so that applications can at least expect a consistent behavior. Reviewed by: kib, markj Discussed with: allanjude Differential Revision: https://reviews.freebsd.org/D32230 2020-04-20T00:47:28Z Kyle Evans kevans@FreeBSD.org 2020-04-20T00:47:28Z urn:sha1:0fbdc3726a50a2e5f8530f08da858d3ff175d960 There were ultimately two separate problems here: - a 32-bit long cannot represent microseconds since 1970 (noted by ian) - time_t is 32-bit on i386, so now() was wrong anyways even with the correct return type. For the first, just explicitly use a uint64_t for now() and all of the callers. For the second, we need to explicitly cast tv_sec to uint64_t before it gets multiplied in the SEC_TO_US macro. Casting this instance rather than generally in the macro was arbitrarily chosen simply because all other uses are converting small relative time values. The tests now pass on i386, at least; presumably other ILP32 will be fine now as well. 2020-04-18T12:54:47Z Alex Richardson arichardson@FreeBSD.org 2020-04-18T12:54:47Z urn:sha1:c9c283bd3045c909671fc9aab250c35fe124ef35 Reviewed By: kevans Differential Revision: https://reviews.freebsd.org/D24296 2020-04-17T02:22:15Z Kyle Evans kevans@FreeBSD.org 2020-04-17T02:22:15Z urn:sha1:c17dd0e88b5db94cf641e862f50bdad436704598 Originally noticed while attempting to run the kqueue tests under qemu-user-static, this apparently just happens sometimes when running in a jail in general -- the timer will fire off "too early," but it's really just the result of imprecise measurements (noted by cem). Kicking this over to NOTE_USECONDS still tests the correct thing while allowing it to work more consistently; a basic sanity test reveals that we often end up coming in just less than 200 microseconds after the timer fired off. MFC after: 3 days 2020-04-06T23:08:07Z Kyle Evans kevans@FreeBSD.org 2020-04-06T23:08:07Z urn:sha1:ce6a89e27cd190313be39bb479880aeda4778436 vnode_fd and kqfd are both shared among multiple CU; define them exactly once. In the case of vnode_fd, it was simply the declaration that needed correction. -fno-common will become the default in GCC10/LLVM11. MFC after: 3 days 2018-11-27T15:12:34Z David Bright dab@FreeBSD.org 2018-11-27T15:12:34Z urn:sha1:d34048812292b714a0bf99967270d18fe3097c62 After r337820, which "corrected" some spaces-instead-of-tab whitespace issues in the libkqueue tests, jmg@ pointed out that these files were originally space-based, not tab-spaced, and so the correction should have been to get rid of the tabs that had been introduced in previous changes, not the spaces. This change does that. This is a whitespace only change; no functional change is intended. Reported by: jmg@ MFC after: 3 days Sponsored by: Dell EMC Isilon