src/tests/sys/kqueue, branch main FreeBSD source tree tests/kqueue: repair flaky test 2025-06-24T22:29:03+00:00 Gleb Smirnoff glebius@FreeBSD.org 2025-06-24T22:28:07+00:00 994bec47ee7f38bd20366b812313b2ea0714ef19 The test arms timer for 500 msec and then sleeps 1 second and expects that the timer would always fire exactly 2 times. However, it has a chance to legitimately fire only once. This makes the test flaky. Fix the test reducing sleep time down to 495 msec. The problem started to show up recently, and I attribute that to 626ea75ed2e9. Before this revision sleep(3) was almost always sleeping over 1000 msec, now it can sleep exactly 1000 msec. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D50996 
The test arms timer for 500 msec and then sleeps 1 second and expects that
the timer would always fire exactly 2 times.  However, it has a chance to
legitimately fire only once.  This makes the test flaky.  Fix the test
reducing sleep time down to 495 msec.

The problem started to show up recently, and I attribute that to
626ea75ed2e9.  Before this revision sleep(3) was almost always sleeping
over 1000 msec, now it can sleep exactly 1000 msec.

Reviewed by:		markj
Differential Revision:	https://reviews.freebsd.org/D50996
Remove residual blank line at start of Makefile 2024-07-15T22:43:39+00:00 Warner Losh imp@FreeBSD.org 2024-07-15T04:46:32+00:00 e9ac41698b2f322d55ccf9da50a3596edb2c1800 This is a residual of the $FreeBSD$ removal. MFC After: 3 days (though I'll just run the command on the branches) Sponsored by: Netflix 
This is a residual of the $FreeBSD$ removal.

MFC After: 3 days (though I'll just run the command on the branches)
Sponsored by: Netflix
kqueue tests: Add a regression test 2024-01-27T18:51:13+00:00 Mark Johnston markj@FreeBSD.org 2023-11-24T15:28:13+00:00 f5463265955b829775bbb32e1fd0bc11dafc36ce Based on the test case submitted by Andreas Bock for PR 275286. PR: 275286 MFC after: 2 weeks 
Based on the test case submitted by Andreas Bock for PR 275286.

PR:		275286
MFC after:	2 weeks
Remove $FreeBSD$: one-line sh pattern 2023-08-16T17:55:03+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:55:03+00:00 d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ 
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
Remove $FreeBSD$: one-line .c comment pattern 2023-08-16T17:54:29+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:29+00:00 2a63c3be158216222d89a073dcbd6a72ee4aab5a Remove /^/[*/]\s*\$FreeBSD\$.*\n/ 
Remove /^/[*/]\s*\$FreeBSD\$.*\n/
Remove $FreeBSD$: two-line .h pattern 2023-08-16T17:54:16+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:16+00:00 b3e7694832e81d7a904a10f525f8797b753bf0d3 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ 
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
kqueue tests: Simplify the test runner 2022-05-25T00:17:41+00:00 Mark Johnston markj@FreeBSD.org 2022-05-25T00:17:04+00:00 68fe988a40ca5dedec426735f52471d9af7bddbd Just invoke the test program directly instead of trying to convert its output to TAP format. The test suite is all or nothing; there's no way to enumerate individual test cases, so there's no advantage in trying to massage its output, and doing so throws away information that's useful when diagnosing test failures. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation 
Just invoke the test program directly instead of trying to convert its
output to TAP format.  The test suite is all or nothing; there's no way
to enumerate individual test cases, so there's no advantage in trying to
massage its output, and doing so throws away information that's useful
when diagnosing test failures.

MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
kqueue tests: Add new EVFILT_TIMER regression tests from upstream 2022-05-25T00:16:32+00:00 Mark Johnston markj@FreeBSD.org 2022-05-25T00:16:32+00:00 d6d4f9b45e0be306bdaf53b2133b2cd0f7642167 One of the tests exposes the regression reported in PR 264131. One test is disabled because FreeBSD does not support setting EV_ONESHOT on an already-added periodic timer. Though, in this case the flag is simply ignored, which isn't ideal. One test is slightly modified to set EV_ADD when reconfiguring a disabled timer per some commentary in PR 258412. Ideally we would re-import the test suite from libkqueue but there is a fair bit of divergence so this will require some effort. This just gets us one small step closer while increasing test coverage. PR: 258412 MFC after: 2 weeks Sponsored by: The FreeBSD Foundation 
One of the tests exposes the regression reported in PR 264131.

One test is disabled because FreeBSD does not support setting EV_ONESHOT
on an already-added periodic timer.  Though, in this case the flag is
simply ignored, which isn't ideal.

One test is slightly modified to set EV_ADD when reconfiguring a
disabled timer per some commentary in PR 258412.

Ideally we would re-import the test suite from libkqueue but there is a
fair bit of divergence so this will require some effort.  This just gets
us one small step closer while increasing test coverage.

PR:		258412
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
kqueue tests: Add file and line info to some test failure output 2022-05-25T00:14:20+00:00 Mark Johnston markj@FreeBSD.org 2022-05-25T00:14:20+00:00 c728c56c870abe230e45cee5c477f0d890ebacef This brings us slightly closer to upstream and is useful when debugging test failures. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation 
This brings us slightly closer to upstream and is useful when debugging
test failures.

MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
kqueue tests: Re-enable kqueue proc tests 2022-05-25T00:14:10+00:00 Mark Johnston markj@FreeBSD.org 2022-05-25T00:14:10+00:00 bc7512cc58af2e8bbe5bbf5ca0059b1daa1da897 - Some EVFILT_PROC bugs were fixed around the time that the tests were disabled. - I can't reproduce any failures locally. - Jenkins logs referenced from the PR are gone, so let's re-enable the tests and see whether a problem persists. PR: 233586 MFC after: 2 weeks Sponsored by: The FreeBSD Foundation 
- Some EVFILT_PROC bugs were fixed around the time that the tests were
  disabled.
- I can't reproduce any failures locally.
- Jenkins logs referenced from the PR are gone, so let's re-enable the
  tests and see whether a problem persists.

PR:		233586
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation