FreeBSD source tree http://cgit.freebsd.org/src/atom?h=main 2026-07-29T17:45:02Z 2026-07-29T17:45:02Z Mark Johnston markj@FreeBSD.org 2026-07-27T15:28:50Z urn:sha1:d8bdcb08d0ebe8cdc7f589cf05283882bff94d3a knotes with a non-trivial f_copy implementation may be activated before kqueue_fork_copy_knote() is finished. In particular, it may be enqueued at the time that kqueue_fork_copy_knote() calls knote_enqueue(). Guard against this. Add a test case which triggers the race. Fix several other problems with the replication of knote state: - Make sure only the KN_ACTIVE and KN_DISABLED status flags are inherited, the rest should not be copied. - Ignore marker knotes. - Ignore knotes for kqueues. They cannot be safely copied into the child without more work, as kqueues are inherently local to a process; on fork, we need to ensure that such knotes are patched to reference the new kqueue, not the original. - Try to keep knote state stable by holding the kqueue and knlist locks while copying. Approved by: so Security: FreeBSD-SA-26:50.kqueue Security: CVE-2026-58083 Reviewed by: kib Reported by: Hazley Samsudin of GovTech CSG Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58223 2026-04-17T03:57:06Z Kyle Evans kevans@FreeBSD.org 2026-04-17T03:57:06Z urn:sha1:51d2c38010824b90d7462711896a88165db9d015 Notably, confirm in the child that our close-on-fork fd is actually closed, and break RECV_ALL out into a table and check each bit individually to provide a better message when the test fails. While we're here, just switch to waitid() rather than trying to identify the point where we have to make the switch. This reduces maintenance slightly, as keeping our assertion static would require still adding to a _RECV_ALL mask *just* for that purpose. Reviewed by: kib, markj (both slightly earlier version) Differential Revision: https://reviews.freebsd.org/D56372 2026-04-09T02:37:11Z Kyle Evans kevans@FreeBSD.org 2026-04-09T02:37:00Z urn:sha1:0c9cec8b66e7033f50059329704515d5222b9ff4 Just copy over a timer and a write-filter, be sure that we can observe both in the child. Maybe the timer should check for a minimum time passed, but I don't know that we'd be likely to get that wrong. This also adds a negative test with a kqueue that is *not* set for CPONFORK being added to the first one, made readable, and confirming that we don't see a knote for it in the child. Some other improvements to the test noted in the review are planned in the short term, but they're not particularly worth blocking adding this as a basic sanity check. Reviewed by: kib, markj Differential Revision: https://reviews.freebsd.org/D56223 2025-06-24T22:29:03Z Gleb Smirnoff glebius@FreeBSD.org 2025-06-24T22:28:07Z urn:sha1:994bec47ee7f38bd20366b812313b2ea0714ef19 The test arms timer for 500 msec and then sleeps 1 second and expects that the timer would always fire exactly 2 times. However, it has a chance to legitimately fire only once. This makes the test flaky. Fix the test reducing sleep time down to 495 msec. The problem started to show up recently, and I attribute that to 626ea75ed2e9. Before this revision sleep(3) was almost always sleeping over 1000 msec, now it can sleep exactly 1000 msec. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D50996 2024-07-15T22:43:39Z Warner Losh imp@FreeBSD.org 2024-07-15T04:46:32Z urn:sha1:e9ac41698b2f322d55ccf9da50a3596edb2c1800 This is a residual of the $FreeBSD$ removal. MFC After: 3 days (though I'll just run the command on the branches) Sponsored by: Netflix 2024-01-27T18:51:13Z Mark Johnston markj@FreeBSD.org 2023-11-24T15:28:13Z urn:sha1:f5463265955b829775bbb32e1fd0bc11dafc36ce Based on the test case submitted by Andreas Bock for PR 275286. PR: 275286 MFC after: 2 weeks 2023-08-16T17:55:03Z Warner Losh imp@FreeBSD.org 2023-08-16T17:55:03Z urn:sha1:d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ 2023-08-16T17:54:29Z Warner Losh imp@FreeBSD.org 2023-08-16T17:54:29Z urn:sha1:2a63c3be158216222d89a073dcbd6a72ee4aab5a Remove /^/[*/]\s*\$FreeBSD\$.*\n/ 2023-08-16T17:54:16Z Warner Losh imp@FreeBSD.org 2023-08-16T17:54:16Z urn:sha1:b3e7694832e81d7a904a10f525f8797b753bf0d3 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ 2022-05-25T00:17:41Z Mark Johnston markj@FreeBSD.org 2022-05-25T00:17:04Z urn:sha1:68fe988a40ca5dedec426735f52471d9af7bddbd Just invoke the test program directly instead of trying to convert its output to TAP format. The test suite is all or nothing; there's no way to enumerate individual test cases, so there's no advantage in trying to massage its output, and doing so throws away information that's useful when diagnosing test failures. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation