src/usr.bin/bsdiff, branch stable/10 FreeBSD source tree MFC bspatch Capsicumization and improvements 2016-09-22T21:16:54+00:00 Ed Maste emaste@FreeBSD.org 2016-09-22T21:16:54+00:00 f2a1b4c2d22389ca9547fdf43e2972618072a86a r304691: bspatch: apply style(9) Make style changes (and trivial refactoring of open calls) now in order to reduce noise in diffs for future capsicum changes. r304807 (allanjude): Capsicumize bspatch Move all of the fopen() and open() calls to the top of main() Restrict each FD to least privilege (read/seek only, write only, etc) cap_enter(), and make all except the output FD read/seek only. r304821: bspatch: remove output file in the case of error r305486: bspatch: add sanity checks on sizes to avoid integer overflow Note that this introduces an explicit 2GB limit, but this was already implicit in variable and function argument types. This is based on the "non-cryptanalytic attacks against freebsd update components" anonymous gist. Further refinement is planned. r305737: bspatch: remove superfluous newlines from errx strings r305822: bspatch: use #define for header size instead of magic number r306026: bspatch: Remove backwards-compatibility sys/capability.h support bspatch previously included sys/capability.h or sys/capsicum.h based on __FreeBSD_version, as FreeBSD is the upstream for bsdiff and we may see this file incorporated into other third-party software. The Capsicum header is now installed as sys/capsicum.h in stable/10 and FreeBSD 10.3, so we can just use sys/capsicum.h and simplify the logic. 
r304691: bspatch: apply style(9)

Make style changes (and trivial refactoring of open calls) now in order
to reduce noise in diffs for future capsicum changes.

r304807 (allanjude): Capsicumize bspatch

Move all of the fopen() and open() calls to the top of main()

Restrict each FD to least privilege (read/seek only, write only, etc)

cap_enter(), and make all except the output FD read/seek only.

r304821: bspatch: remove output file in the case of error

r305486: bspatch: add sanity checks on sizes to avoid integer overflow

Note that this introduces an explicit 2GB limit, but this was already
implicit in variable and function argument types.

This is based on the "non-cryptanalytic attacks against freebsd
update components" anonymous gist. Further refinement is planned.

r305737: bspatch: remove superfluous newlines from errx strings

r305822: bspatch: use #define for header size instead of magic number

r306026: bspatch: Remove backwards-compatibility sys/capability.h support

bspatch previously included sys/capability.h or sys/capsicum.h based
on __FreeBSD_version, as FreeBSD is the upstream for bsdiff and we may
see this file incorporated into other third-party software.

The Capsicum header is now installed as sys/capsicum.h in stable/10 and
FreeBSD 10.3, so we can just use sys/capsicum.h and simplify the logic.
MFC r264823 (ed): Make usage printing more consistent with other tools. 2016-09-22T21:14:00+00:00 Ed Maste emaste@FreeBSD.org 2016-09-22T21:14:00+00:00 5236d63380e2755519dfc97ac9313eebeda222df - Introduce a separate usage() function. - Don't use argv[0]. Directly name the application, as we do elsewhere. - Don't prepend the application name. - Don't print two newlines. Also apply the unnecessary semicolon cleanup from r298089 
- Introduce a separate usage() function.
- Don't use argv[0]. Directly name the application, as we do elsewhere.
- Don't prepend the application name.
- Don't print two newlines.

Also apply the unnecessary semicolon cleanup from r298089
Fix bspatch heap overflow vulnerability. 2016-07-25T14:53:04+00:00 Xin LI delphij@FreeBSD.org 2016-07-25T14:53:04+00:00 82589ea7665a7299f2823e7a924b022a239f9415 Obtained from: Chromium Reported by: Lu Tung-Pin Security: FreeBSD-SA-16:25.bspatch 
Obtained from:	Chromium
Reported by:	Lu Tung-Pin
Security:	FreeBSD-SA-16:25.bspatch
MFC: r290329,r290336 2015-11-08T14:22:57+00:00 Andrey A. Chernov ache@FreeBSD.org 2015-11-08T14:22:57+00:00 20ec4f2fe89ae8cfdfa950287c9e2ef63561ed37 PR: 204230 r290329: Use meaningful errno for ssize_t overflow in read(). Catch size_t overflow in malloc(). r290336: Check for (old|new)size + 1 overflows off_t. 
PR: 204230

r290329:

Use meaningful errno for ssize_t overflow in read().
Catch size_t overflow in malloc().

r290336:

Check for (old|new)size + 1 overflows off_t.
Remove trailing whitespace per mdoc lint warning 2012-03-29T05:02:12+00:00 Eitan Adler eadler@FreeBSD.org 2012-03-29T05:02:12+00:00 50d675f7a9fca2f3fba3a23ac41a8ae2c0162e4e Disussed with: gavin No objection from: doc Approved by: joel MFC after: 3 days 
Disussed with:	gavin
No objection from:	doc
Approved by:	joel
MFC after:	3 days
Silence bogus warning when compiling with gcc46: 2012-01-10T02:58:44+00:00 Eitan Adler eadler@FreeBSD.org 2012-01-10T02:58:44+00:00 c9515560358431ea4c061fbaebfd680e9dd2df10 error: 'pos' may be used uninitialized in this function Reviewed by: cperciva Approved by: dim MFC after: 3 days 
	 error: 'pos' may be used uninitialized in this function

Reviewed by:	cperciva
Approved by:	dim
MFC after:      3 days
mdoc: move CAVEATS, BUGS and SECURITY CONSIDERATIONS sections to the 2010-05-13T12:07:55+00:00 Ulrich Spörlein uqs@FreeBSD.org 2010-05-13T12:07:55+00:00 0afc94c17a8772df34294778904e816258542498 bottom of the manpages and order them consistently. GNU groff doesn't care about the ordering, and doesn't even mention CAVEATS and SECURITY CONSIDERATIONS as common sections and where to put them. Found by: mdocml lint run Reviewed by: ru 
bottom of the manpages and order them consistently.

GNU groff doesn't care about the ordering, and doesn't even mention
CAVEATS and SECURITY CONSIDERATIONS as common sections and where to put
them.

Found by:	mdocml lint run
Reviewed by:	ru
Build usr.bin/ with WARNS=6 by default. 2010-01-02T10:27:05+00:00 Ed Schouten ed@FreeBSD.org 2010-01-02T10:27:05+00:00 b7946da96b4498519f66f3f5fe72d1474bf13f7d Also add some missing $FreeBSD$ to keep svn happy. 
Also add some missing $FreeBSD$ to keep svn happy.
Add notes pointing out that bsdiff does not store file hashes and 2009-10-30T11:13:00+00:00 Colin Percival cperciva@FreeBSD.org 2009-10-30T11:13:00+00:00 2bc706c6482adb2f598386e3cb86b3fb2da90b29 bspatch thus does not verify file hashes, and that consequently it is recommended that users store hashes separately and verify files before and after running bspatch. Requested by: BugMagnet MFC after: 1 week 
bspatch thus does not verify file hashes, and that consequently it
is recommended that users store hashes separately and verify files
before and after running bspatch.

Requested by:	BugMagnet
MFC after:	1 week
Portability fix for non-POSIX operating systems: Open files in binary mode. 2006-12-05T20:22:14+00:00 Colin Percival cperciva@FreeBSD.org 2006-12-05T20:22:14+00:00 8904d5ecb17e4411a521d0f4f399e5b260179bfc PR: bin/106358 Submitted by: techtonik at php dot net 
PR:		bin/106358
Submitted by:	techtonik at php dot net