src/usr.bin/procstat, branch releng/14.3 FreeBSD source tree cred: Hide internal flag CRED_FLAG_CAPMODE 2025-04-08T13:38:14+00:00 Olivier Certner olce@FreeBSD.org 2024-07-16T16:07:40+00:00 f9fa6cb391f8811d12e566dbc91b34c8d6117d88 This flag is used in field 'cr_flags', which is never directly visible outside the kernel. That field is however exported through 'struct kinfo_proc' objects (field 'ki_cr_flags'), either from the kernel via sysctls or from libkvm, and is supposed to contain exported flags prefixed with KI_CRF_ (currently, KI_CRF_CAPABILITY_MODE and KI_CRF_GRP_OVERFLOW, this second one being a purely userland one signaling overflow of 'ki_groups'). Make sure that KI_CRF_CAPABILITY_MODE is the flag actually exported and tested by userland programs, and hide the internal CRED_FLAG_CAPMODE. As both flags are currently defined to the same value, this doesn't change the KBI, but of course does change the KPI. A code search via GitHub and Google fortunately doesn't reveal any outside uses for CRED_FLAG_CAPMODE. While here, move assignment of 'ki_uid' to a more logical place in kvm_proclist(), and definition of XU_NGROUPS as well in 'sys/ucred.h' (no functional/interface changes intended). Reviewed by: mhorne Approved by: markj (mentor) MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46909 (cherry picked from commit 09290c3a0c82524138973b14f393379edf733753) A ports exp-run (PR 283410) showed one port to be affected (sysutils/procs), which has been fixed upstream and in the ports tree. All additional indirect references to CRED_FLAG_CAPMODE we found after the code search mentioned in the original commit message are automatically generated from our headers by FFI mechanisms, so automatically disappear at recompilation (and the KBI is not changed, as explained above, so recompilation is not needed). 
This flag is used in field 'cr_flags', which is never directly visible
outside the kernel.  That field is however exported through 'struct
kinfo_proc' objects (field 'ki_cr_flags'), either from the kernel via
sysctls or from libkvm, and is supposed to contain exported flags
prefixed with KI_CRF_ (currently, KI_CRF_CAPABILITY_MODE and
KI_CRF_GRP_OVERFLOW, this second one being a purely userland one
signaling overflow of 'ki_groups').

Make sure that KI_CRF_CAPABILITY_MODE is the flag actually exported and
tested by userland programs, and hide the internal CRED_FLAG_CAPMODE.
As both flags are currently defined to the same value, this doesn't
change the KBI, but of course does change the KPI.  A code search via
GitHub and Google fortunately doesn't reveal any outside uses for
CRED_FLAG_CAPMODE.

While here, move assignment of 'ki_uid' to a more logical place in
kvm_proclist(), and definition of XU_NGROUPS as well in 'sys/ucred.h'
(no functional/interface changes intended).

Reviewed by:    mhorne
Approved by:    markj (mentor)
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D46909

(cherry picked from commit 09290c3a0c82524138973b14f393379edf733753)

A ports exp-run (PR 283410) showed one port to be affected
(sysutils/procs), which has been fixed upstream and in the ports tree.
All additional indirect references to CRED_FLAG_CAPMODE we found after
the code search mentioned in the original commit message are
automatically generated from our headers by FFI mechanisms, so
automatically disappear at recompilation (and the KBI is not changed, as
explained above, so recompilation is not needed).
procstat.1: document kqueues 2025-04-07T01:28:21+00:00 Konstantin Belousov kib@FreeBSD.org 2025-03-09T16:32:10+00:00 451fca2e9f9132ce726959864dbacc1c6184da8e (cherry picked from commit d76a31ca74cffda4aea63b1276f92c039ca76053) 
(cherry picked from commit d76a31ca74cffda4aea63b1276f92c039ca76053)
procstat(1): dump kqueues 2025-04-07T01:28:21+00:00 Konstantin Belousov kib@FreeBSD.org 2025-02-26T00:29:49+00:00 a15cae4c746ac076c5e273d8d31b16f25632a963 (cherry picked from commit 28f4cf9217c27edea42c5c024c9e71816890bb3c) 
(cherry picked from commit 28f4cf9217c27edea42c5c024c9e71816890bb3c)
procstat.1: document local SOCK_SEQPACKET socket display 2025-03-31T02:41:32+00:00 Konstantin Belousov kib@FreeBSD.org 2025-03-27T09:06:25+00:00 04e4dda94f21a114409958c4948edaaaf2ad4721 (cherry picked from commit 03dfb8d0211cf9d7405c4fd7d541dde28047001c) 
(cherry picked from commit 03dfb8d0211cf9d7405c4fd7d541dde28047001c)
procstat.1: correct local socket types descriptions. 2025-03-31T02:41:32+00:00 Konstantin Belousov kib@FreeBSD.org 2025-03-27T09:02:21+00:00 a02f377d9579e4335d50c7b38ad8cdcdcb2653b2 (cherry picked from commit 991329f507a893076a4119c90bb463de0ac15be9) 
(cherry picked from commit 991329f507a893076a4119c90bb463de0ac15be9)
procstat: decode SOCK_SEQPACKET unix domain socket type 2025-03-31T02:41:32+00:00 Konstantin Belousov kib@FreeBSD.org 2025-03-26T18:42:31+00:00 fb8c944d2b1f704f1762d0757315db1b898f3413 (cherry picked from commit 8011df62f57f021a1b4f62d9beea4c25d9b37a23) 
(cherry picked from commit 8011df62f57f021a1b4f62d9beea4c25d9b37a23)
procstat.1: document rlimitusage 2025-03-20T03:13:39+00:00 Konstantin Belousov kib@FreeBSD.org 2025-03-09T16:31:19+00:00 8025c3957bc630545aab9786f76552fce6d15d00 (cherry picked from commit 82897058342e9bfe7193283421055e3f07ac9b8f) 
(cherry picked from commit 82897058342e9bfe7193283421055e3f07ac9b8f)
procstat.1: sort subcommands 2025-03-20T03:13:38+00:00 Konstantin Belousov kib@FreeBSD.org 2025-03-01T21:43:40+00:00 d9b7d0a54846bbc7b922982df08659fcc3c6b92e (cherry picked from commit 0832381247d7e6e93ae9ba1639d07f33a6f07882) 
(cherry picked from commit 0832381247d7e6e93ae9ba1639d07f33a6f07882)
procstat vm: report posix shm segment mapping 2024-10-15T14:50:17+00:00 Konstantin Belousov kib@FreeBSD.org 2024-10-07T01:59:53+00:00 a6188cd25039b77571ad3212a1fc0c914d55f48a (cherry picked from commit a1258191d5e21736e25010c85eb01b5f995cc1d2) 
(cherry picked from commit a1258191d5e21736e25010c85eb01b5f995cc1d2)
procstat vm: report SysV shm segment mapping 2024-10-15T14:50:16+00:00 Konstantin Belousov kib@FreeBSD.org 2024-10-05T09:34:59+00:00 cde459e2206c834a8b11ca7a257fadab10c4cac1 (cherry picked from commit 65b832eb6ff76464a65cbf6ba730a54364a5fdc2) 
(cherry picked from commit 65b832eb6ff76464a65cbf6ba730a54364a5fdc2)