src/usr.sbin/bhyvectl/bhyvectl.c, branch main FreeBSD source tree bhyvectl: fix build without BHYVE_SNAPSHOT 2025-12-13T12:28:15+00:00 Roman Bogorodskiy novel@FreeBSD.org 2025-12-13T12:25:22+00:00 9d9974457ce8c6cf9023884ab457d4712dcc237f Build fails without BHYVE_SNAPSHOT due to undeclared identifier 'checkpoint_file'. Wrap that with a proper #ifdef. Reported by: dhw 
Build fails without BHYVE_SNAPSHOT due to undeclared identifier
'checkpoint_file'. Wrap that with a proper #ifdef.

Reported by:	dhw
bhyvectl: improve options error handling 2025-12-13T09:27:00+00:00 Roman Bogorodskiy novel@FreeBSD.org 2025-12-05T18:45:03+00:00 148111d3775eb159d71a36e3a8b4c5c1bf53392c Currently, it is possible to execute bhyvectl(8) with mutually exclusive options, such as "--destroy" and "--suspend", and it will print out obscure errors, e.g.: bhyvectl --suspend=/var/run/vms/my_vm --destroy --vm my_vm connect() failed: Connection refused Address that by failing early if mutually exclusive options were specified. Additionally, move the BHYVE_SNAPSHOT block before the errors are printed, so its errors are also displayed. Approved by: markj Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D54092 
Currently, it is possible to execute bhyvectl(8) with mutually exclusive
options, such as "--destroy" and "--suspend", and it will print out
obscure errors, e.g.:

 bhyvectl --suspend=/var/run/vms/my_vm --destroy --vm my_vm
 connect() failed: Connection refused

Address that by failing early if mutually exclusive options were
specified.

Additionally, move the BHYVE_SNAPSHOT block before the errors are
printed, so its errors are also displayed.

Approved by:		markj
Sponsored by:		The FreeBSD Foundation
MFC after:		2 weeks
Differential Revision:	https://reviews.freebsd.org/D54092
bhyvectl: Convert to use vm_openf() 2024-11-05T01:40:41+00:00 Mark Johnston markj@FreeBSD.org 2024-11-05T01:36:52+00:00 c2b34d060705879d78bbce7e62f9fb35fb13bc55 Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D47031 
Reviewed by:	jhb
Differential Revision:	https://reviews.freebsd.org/D47031
bhyvectl: Prepare to add arm64 support 2024-05-01T12:31:00+00:00 Mark Johnston markj@FreeBSD.org 2024-05-01T12:31:00+00:00 1c4ee7dfb8affed302171232b0f612e6bcba3c10 Move MD code into a separate directory and add a simple interface which lets the MD bits register options and handle them. No functional change intended. Reviewed by: jhb Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D44932 
Move MD code into a separate directory and add a simple interface which
lets the MD bits register options and handle them.

No functional change intended.

Reviewed by:	jhb
Sponsored by:	Innovate UK
Differential Revision:	https://reviews.freebsd.org/D44932
bhyvectl: generate usage from options table 2024-04-08T13:08:54+00:00 Rob Norris robn@despairlabs.com 2024-04-08T13:07:32+00:00 b9fa1500cb2265b95927e19b9d2119ca26d65be3 The usage text had fallen out of sync with the actually available options. Rather than keep them in sync by hand, just generate usage from the available options. Signed-off-by: Rob Norris <robn@despairlabs.com> Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D44641 
The usage text had fallen out of sync with the actually available
options. Rather than keep them in sync by hand, just generate usage from
the available options.

Signed-off-by: Rob Norris <robn@despairlabs.com>

Reviewed by:	markj
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D44641
usr.sbin: Automated cleanup of cdefs and other formatting 2023-11-27T05:24:01+00:00 Warner Losh imp@FreeBSD.org 2023-11-24T20:12:57+00:00 4d65a7c6951cea0333f1a0c1b32c38489cdfa6c5 Apply the following automated changes to try to eliminate no-longer-needed sys/cdefs.h includes as well as now-empty blank lines in a row. Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/ Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/ Remove /\n+#if.*\n#endif.*\n+/ Remove /^#if.*\n#endif.*\n/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/ Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/ Sponsored by: Netflix 
Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/

Sponsored by:		Netflix
Remove $FreeBSD$: one-line .c pattern 2023-08-16T17:54:42+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:42+00:00 1d386b48a555f61cb7325543adbbb5c3f3407a66 Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ 
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
Remove $FreeBSD$: two-line .h pattern 2023-08-16T17:54:16+00:00 Warner Losh imp@FreeBSD.org 2023-08-16T17:54:16+00:00 b3e7694832e81d7a904a10f525f8797b753bf0d3 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ 
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
bhyvectl: Add '--get-debug-cpus' command 2023-07-25T12:03:54+00:00 Vitaliy Gusev gusev.vitaliy@gmail.com 2023-07-25T12:03:54+00:00 65f8467e3351c38a9d57b538b85cf6c5fab5818e vmm and libvmmapi already have handlers for that. When adding debug cpus, they were only used for the debug stub. Over time, they were reused by other parts like snapshots or idle APs. Reviewed by: corvink, jhb MFC after: 1 week Sponsored by: vStack Differential Revision: https://reviews.freebsd.org/D40804 
vmm and libvmmapi already have handlers for that. When adding debug
cpus, they were only used for the debug stub. Over time, they were
reused by other parts like snapshots or idle APs.

Reviewed by:		corvink, jhb
MFC after:		1 week
Sponsored by:		vStack
Differential Revision:	https://reviews.freebsd.org/D40804
Revert "bhyve: add command line parameter and parsing for migration" 2023-06-21T06:55:34+00:00 Corvin Köhne corvink@FreeBSD.org 2023-06-21T06:55:34+00:00 1e8d0c6cf644f4c2d6e85f8f370651f0ce46d0ac Unfortunately, this feature didn't receive much feedback in the past. However, after committing this, some people came up and complain that this feature requires some more discussion before upstreaming it. Additionally, it wasn't a good idea to start this new feature by adding a new command line parameter as it fixes the user interface. This reverts commit c9fdd4f3cc18c03683de85318ba8d318f96b58c4. 
Unfortunately, this feature didn't receive much feedback in the past.
However, after committing this, some people came up and complain that
this feature requires some more discussion before upstreaming it.
Additionally, it wasn't a good idea to start this new feature by adding
a new command line parameter as it fixes the user interface.

This reverts commit c9fdd4f3cc18c03683de85318ba8d318f96b58c4.