<feed xmlns='http://www.w3.org/2005/Atom'>
<title>src/usr.sbin/bsdinstall/partedit, branch main</title>
<subtitle>FreeBSD source tree</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/'/>
<entry>
<title>bsdinstall: Fix newfs bsddialog menu</title>
<updated>2025-11-08T15:01:35+00:00</updated>
<author>
<name>Ed Maste</name>
<email>emaste@FreeBSD.org</email>
</author>
<published>2025-11-07T22:53:01+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=4e36942420712c2ab6ebc2c646e61d47b2b68e7b'/>
<id>4e36942420712c2ab6ebc2c646e61d47b2b68e7b</id>
<content type='text'>
The second and third members of struct bsddialog_menuitem are `bool on`
and `unsigned int depth`. The newfs dialog options in bsdinstall's
partition tool had these two swapped, so the default selection did not
work.

PR: 290857
Reviewed by: asiciliano
Fixes: 50e244964e9b ("bsdinstall/partedit: Replace libdialog with libbsddialog")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53639
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The second and third members of struct bsddialog_menuitem are `bool on`
and `unsigned int depth`. The newfs dialog options in bsdinstall's
partition tool had these two swapped, so the default selection did not
work.

PR: 290857
Reviewed by: asiciliano
Fixes: 50e244964e9b ("bsdinstall/partedit: Replace libdialog with libbsddialog")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53639
</pre>
</div>
</content>
</entry>
<entry>
<title>bsdinstall: Limit default swap to maximum supported by kernel</title>
<updated>2025-10-15T16:29:56+00:00</updated>
<author>
<name>Ed Maste</name>
<email>emaste@FreeBSD.org</email>
</author>
<published>2023-03-06T20:24:05+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=52f9722e6ffff6fee309e6040b7b5313499a03ef'/>
<id>52f9722e6ffff6fee309e6040b7b5313499a03ef</id>
<content type='text'>
PR:		251993
Reviewed by:	cperciva
Sponsored by:	The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53106
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR:		251993
Reviewed by:	cperciva
Sponsored by:	The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53106
</pre>
</div>
</content>
</entry>
<entry>
<title>partedit: make minimum FreeBSD install size just under 1 GiB</title>
<updated>2025-04-18T13:09:05+00:00</updated>
<author>
<name>Ed Maste</name>
<email>emaste@FreeBSD.org</email>
</author>
<published>2023-03-02T23:35:33+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=57e12d397387542b13f175d4c0b8b5adca198690'/>
<id>57e12d397387542b13f175d4c0b8b5adca198690</id>
<content type='text'>
1 GiB is a convenient disk image size for testing.  It is also the
installer's minimum size, but the minimum applies to the partition
rather than the whole disk.  Testing with a 1 GiB image resulted in the
counterintuitive error "There is not enough free space on &lt;disk&gt; to
install FreeBSD (1.0 GB free, 1.0 GB required)."

Reduce the installer's minimum size slightly to support this case.

Reviewed by:	brd
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D38881
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
1 GiB is a convenient disk image size for testing.  It is also the
installer's minimum size, but the minimum applies to the partition
rather than the whole disk.  Testing with a 1 GiB image resulted in the
counterintuitive error "There is not enough free space on &lt;disk&gt; to
install FreeBSD (1.0 GB free, 1.0 GB required)."

Reduce the installer's minimum size slightly to support this case.

Reviewed by:	brd
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D38881
</pre>
</div>
</content>
</entry>
<entry>
<title>Update Makefile.depend files</title>
<updated>2024-10-14T17:26:17+00:00</updated>
<author>
<name>Simon J. Gerraty</name>
<email>sjg@FreeBSD.org</email>
</author>
<published>2024-10-14T17:24:54+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=a64729f5077d77e13b9497cb33ecb3c82e606ee8'/>
<id>a64729f5077d77e13b9497cb33ecb3c82e606ee8</id>
<content type='text'>
After building packages we have a number of new
and updated Makefile.depend files

Reviewed by:	stevek
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
After building packages we have a number of new
and updated Makefile.depend files

Reviewed by:	stevek
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove residual blank line at start of Makefile</title>
<updated>2024-07-15T22:43:39+00:00</updated>
<author>
<name>Warner Losh</name>
<email>imp@FreeBSD.org</email>
</author>
<published>2024-07-15T04:46:32+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=e9ac41698b2f322d55ccf9da50a3596edb2c1800'/>
<id>e9ac41698b2f322d55ccf9da50a3596edb2c1800</id>
<content type='text'>
This is a residual of the $FreeBSD$ removal.

MFC After: 3 days (though I'll just run the command on the branches)
Sponsored by: Netflix
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is a residual of the $FreeBSD$ removal.

MFC After: 3 days (though I'll just run the command on the branches)
Sponsored by: Netflix
</pre>
</div>
</content>
</entry>
<entry>
<title>bsdinstall: complete whitelabeling the installer</title>
<updated>2024-02-04T12:01:08+00:00</updated>
<author>
<name>Mariusz Zaborski</name>
<email>oshogbo@FreeBSD.org</email>
</author>
<published>2024-02-04T11:59:07+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=cd724c25928d0d30761d118690b4ac75ca931b63'/>
<id>cd724c25928d0d30761d118690b4ac75ca931b63</id>
<content type='text'>
The commit 147585b4893bc38698aaa971af336b241477eac3 introduces
whitlabeling. This commit addresses couple more places where the
os name was missed.

Reviewed by:	imp, asiciliano, brd
Differential Revision:	https://reviews.freebsd.org/D43638
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The commit 147585b4893bc38698aaa971af336b241477eac3 introduces
whitlabeling. This commit addresses couple more places where the
os name was missed.

Reviewed by:	imp, asiciliano, brd
Differential Revision:	https://reviews.freebsd.org/D43638
</pre>
</div>
</content>
</entry>
<entry>
<title>bsdinstall generate opt_osname.h in include</title>
<updated>2023-12-07T02:34:52+00:00</updated>
<author>
<name>Simon J. Gerraty</name>
<email>sjg@FreeBSD.org</email>
</author>
<published>2023-12-07T02:34:52+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=83d0b8c089d807d6d4c50cba40ae2d0fedb3bf1b'/>
<id>83d0b8c089d807d6d4c50cba40ae2d0fedb3bf1b</id>
<content type='text'>
This allows the subdirs that do more work to run in parallel

Reviewed by:	jrtc27
Differential Revision:	https://reviews.freebsd.org/D42947
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows the subdirs that do more work to run in parallel

Reviewed by:	jrtc27
Differential Revision:	https://reviews.freebsd.org/D42947
</pre>
</div>
</content>
</entry>
<entry>
<title>bsdinstall partedit: Use snprintf instead of sprintf for error messages</title>
<updated>2023-10-16T23:25:38+00:00</updated>
<author>
<name>John Baldwin</name>
<email>jhb@FreeBSD.org</email>
</author>
<published>2023-10-16T23:25:38+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=6e8bf24073a1867c4b21bd84438a8b01ce91d82d'/>
<id>6e8bf24073a1867c4b21bd84438a8b01ce91d82d</id>
<content type='text'>
When generating a message for a dialog box into a static buffer, use
snprintf instead of sprintf to avoid buffer overflows.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D42240
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When generating a message for a dialog box into a static buffer, use
snprintf instead of sprintf to avoid buffer overflows.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D42240
</pre>
</div>
</content>
</entry>
<entry>
<title>bsdinstall partedit: Use asprintf to build wrapper command for newfs</title>
<updated>2023-10-16T23:25:25+00:00</updated>
<author>
<name>John Baldwin</name>
<email>jhb@FreeBSD.org</email>
</author>
<published>2023-10-16T23:25:25+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=a8676bf367b099dcc97ff61031cbf4ceb5e37899'/>
<id>a8676bf367b099dcc97ff61031cbf4ceb5e37899</id>
<content type='text'>
Don't abuse the message[] static buffer used elsewhere for error
messages to generate the command that actually newfs's each
filesystem.  Use asprintf to a more aptly-named 'char *command'
variable to construct the string instead.  This avoids potential bugs
from truncation of the command string.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D42239
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Don't abuse the message[] static buffer used elsewhere for error
messages to generate the command that actually newfs's each
filesystem.  Use asprintf to a more aptly-named 'char *command'
variable to construct the string instead.  This avoids potential bugs
from truncation of the command string.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D42239
</pre>
</div>
</content>
</entry>
<entry>
<title>bsdinstall partedit: Replace malloc + sprintf with asprintf</title>
<updated>2023-10-16T23:25:15+00:00</updated>
<author>
<name>John Baldwin</name>
<email>jhb@FreeBSD.org</email>
</author>
<published>2023-10-16T23:25:15+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.freebsd.org/src/commit/?id=51749e05e96eb07134a38984a8c06608b20f07ea'/>
<id>51749e05e96eb07134a38984a8c06608b20f07ea</id>
<content type='text'>
This avoids potential bugs with the length passed to malloc not
matching the string written via sprintf.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D42238
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This avoids potential bugs with the length passed to malloc not
matching the string written via sprintf.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D42238
</pre>
</div>
</content>
</entry>
</feed>
