src/usr.sbin/bsnmpd/tools, branch main

bsnmpd: avoid warnings about too-long initializer strings

2025-12-26T13:27:23+00:00

Mark `UTC` as `__non_string`, to avoid a warning from clang 21 similar
to:

    usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c:339:29: error: initializer-string for character array is too long, array size is 3 but initializer has size 4 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
    --- all_subdir_usr.sbin ---
      339 |         static const char UTC[3] = "UTC";
          |                                    ^~~~~

MFC after:	3 days

libbsnmp: make binding of client UNIX socket optional and configurable

2025-07-25T20:10:17+00:00

Before this change snmp_open(3) would always bind(2) client socket to a
random "/tmp/snmpXXXXXXXXXXXXXX" name.  However, this binding is not
required for SOCK_STREAM transport.  Also, any attempt to specify a
different name would fail, as open_client_local() would blindly rewrite
the name to the default.

Make this binding optional.  If application had initialized
snmp_client.local_path, then try to bind to the specified pathname,
otherwise perform the random name binding only if we are in the
SOCK_DGRAM mode.

While here change snmp_client.local_path size to SUNPATHLEN, so that any
legitimate local socket name can be used.  This requires library version
bump.

Note that this code has been broken by 81e0e7b9e36d for three years, thus
it is known not to be widely used.

Reviewed by:		harti
Differential Revision:	https://reviews.freebsd.org/D51070

bsnmpget: print SNMP library reported error on failures

2025-07-17T16:00:15+00:00

Reviewed by:		syrinx, harti
Differential Revision:	https://reviews.freebsd.org/D51073

libbsnmp: define SNMP_DEFAULT_LOCAL that matches default server config

2025-07-17T15:59:44+00:00

The default /etc/snmpd.config we install for decades has:

begemotSnmpdLocalPortStatus."/var/run/snmpd.sock" = 1
begemotSnmpdLocalPortType."/var/run/snmpd.sock" = 4

However, libbsnmp internally used DEFAULT_LOCAL set to
"/var/run/snmp.sock" (note missing "d") to fill server pathname in case if
API user didn't provide one.  This results with default server config
never working with an application that uses default initializer.  The
libbsnmptools has a workaround for that, it defines internally
SNMP_DEFAULT_LOCAL that matches /etc/snmpd.config.

Bring this all to an order:
- Make a public define SNMP_DEFAULT_LOCAL in libbsnmp.
- Point it to what /etc/snmpd.config has in.
- Remove workaround from libbsnmptools.

Reviewed by:		harti
Differential Revision:	https://reviews.freebsd.org/D51071

libbsnmptools: avoid uninitialized snmptoolctx->passwd with empty password

2025-01-11T05:08:02+00:00

The removed check left snmptoolctx->passwd pointer to uninitialized
memory.  Always calling strlcpy(3) would guarantee that with empty
password it will point to empty string.

Submitted by:	markj
PR:		283909

bsnmpwalk: Fix crash on invalid data

2025-01-10T20:47:06+00:00

PR:		258570
Reported by:	Robert Morris 
Reviewed by:	emaste, markj
Differential Revision: https://reviews.freebsd.org/D48422

Remove $FreeBSD$: two-line nroff pattern

2023-08-16T17:55:10+00:00

Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/

Remove $FreeBSD$: one-line sh pattern

2023-08-16T17:55:03+00:00

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/

Remove $FreeBSD$: two-line .h pattern

2023-08-16T17:54:16+00:00

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

libbsnmptools: Fully comment out set but unused count variable.

2023-06-27T17:19:32+00:00

These functions all end with 'return (2/* count */);'.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D40670