src/usr.sbin/rpcbind, branch stable/12

RPCBIND: skip ipv6 link local when request is not from link local address

2021-10-11T16:21:00+00:00

RPCINFO on macOS behaves different compared to other linux clients and
doesn't provide request address in rpcb structure of the
RPCBPROC_GETADDRLIST call which doesn't seem to be forbidden.

In this case RPCBIND uses RPC call's source address and picks a
closest corresponding local address. If there are no addresses in the
same subnet as the source address, return of RPCBIND may vary
depending on the order of addresses returned in getifaddrs. If a link
local precedes global address it may be returned even if the request
comes from neither a link local nor from link local in a different
scope, which will prevent services like nfs from working in tpc6
scenario on macOS clients. Issue can be seen only on FreeBSD rpcbind
port due to changes in workflow of addrmerge call.

Submitted by:	Dmitry Ovsyannikov (Dmitry.Ovsyannikov@dell.com)
Sponsored by:	Dell EMC

(cherry picked from commit d18c9a91979543adc182c7b28819691b64fda388)

Add Makefile.depend.options

2019-12-19T04:58:11+00:00

Leaf directories that have dependencies impacted
by options need a Makefile.depend.options file
to avoid churn in Makefile.depend

DIRDEPS for cases such as OPENSSL, TCP_WRAPPERS etc
can be set in local.dirdeps-options.mk
which can add to those set in Makefile.depend.options

See share/mk/dirdeps-options.mk

Also update affected Makefile.depend files.

MFC of r355616 and r355617

Reviewed by:	 bdrewery
Sponsored by:   Juniper Networks
Differential Revision:  https://reviews.freebsd.org/D22469

Plug a possible memory leak.

2018-03-19T05:49:26+00:00

MFC after:	2 weeks

- Remove extra NULL check before free().

2018-03-05T03:38:31+00:00

- Fix null pointer dereference in netbuffree() and use netbuffree()
  where applicable.

Partially back out changes in r327464. stdlib.h is used when

2018-03-05T03:34:01+00:00

RPCBIND_DEBUG is enabled.

rpcbind: Fix race in signal termination

2018-01-02T17:25:13+00:00

If a signal was delivered while the main thread was not in poll(2) and after
check was performed, we could reenter poll and never detect termination. Fix
this with the pipefd trick.  (This race was introduced very recently, in
r327482.)

PR:		224503
Reported by:	kib
Reviewed by:	kib, markj
Sponsored by:	Dell EMC Isilon

rpcbind: Fix build

2018-01-02T01:48:11+00:00

Add missed unistd.h include.  Not sure where it was lost; I believe it
compiled before I submitted the change.

PR:		224503
Reported by:	Cy Schubert 
Sponsored by:	Dell EMC Isilon

rpcbind: Do not use signal-unsafe functions in SIGTERM handler

2018-01-02T00:48:19+00:00

syslog(3), routines used in write_warmstart(), and exit(3) are all
signal-unsafe.  Instead, set a signal-safe flag and check the flag in the
rpcbind main loop to shutdown safely.

PR:		224503
Reviewed by:	kib, markj
Sponsored by:	Dell EMC Isilon
Differential Revision:	https://reviews.freebsd.org/D13728

Remove unused includes.

2018-01-01T09:41:18+00:00

various: general adoption of SPDX licensing ID tags.

2017-11-27T15:37:16+00:00

Mainly focus on files that use BSD 2-Clause license, however the tool I
was using misidentified many licenses so this was mostly a manual - error
prone - task.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

No functional change intended.