diff options
| author | Ed Maste <emaste@FreeBSD.org> | 2021-08-10 16:01:23 +0000 |
|---|---|---|
| committer | Ed Maste <emaste@FreeBSD.org> | 2021-08-10 21:03:05 +0000 |
| commit | 6fd5f57d0613a9f6d1816a912f21728b0d12435a (patch) | |
| tree | 336f83346a55dc5e3ee6ae0bb9f986c4d3a1caeb | |
| parent | 3ee4a81aa38a821eb9195b37cf3189eb132b28b7 (diff) | |
| download | ports-6fd5f57d0613a9f6d1816a912f21728b0d12435a.tar.gz ports-6fd5f57d0613a9f6d1816a912f21728b0d12435a.zip | |
math/lapack: remove superfluous and broken ranlib invocation
FreeBSD's base system ar and ranlib have a bug where they exit with
status 0 (success) even in case of fatal errors. This hid the fact that
math/lapacke was invoking ranlib on a non-existent file. (Presumably the
ranlib invocation was correct when introduced, but broken by some
rework of lapack's upstream build system).
Use of ranlib is generally unncessary, assuming the -s flag is passed to
ar (as is typical, and as done here), so just delete the invocation.
See PR 257599 and review D31402 for the ar/ranlib base system bug.
PR: 257599, 257744
Reviewed by: jrm
Tested by: jrm
Approved by: kevans (ports), portmgr (implicit, blanket: build fix)
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D31492
| -rw-r--r-- | math/lapack/files/static.mk | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/math/lapack/files/static.mk b/math/lapack/files/static.mk index 704423c2fe45..3e0d17a5088d 100644 --- a/math/lapack/files/static.mk +++ b/math/lapack/files/static.mk @@ -1,3 +1,2 @@ build-static: cd SRC && $(AR) $(ARFLAGS) lib%%LIB%%.a $(%%LIB%%_OBJECTS) - $(RANLIB) SRC/lib%%LIB%%.a |